From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Nishanth Menon <nm@ti.com>, Lee Jones <lee.jones@linaro.org>
Cc: florian.vaussard@epfl.ch, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 1/3] mfd: twl6040: Select i2c fast mode as default with regmap patch
Date: Thu, 27 Feb 2014 16:33:09 +0200 [thread overview]
Message-ID: <530F4CA5.6030502@ti.com> (raw)
In-Reply-To: <530F4A84.9070906@ti.com>
On 02/27/2014 04:24 PM, Nishanth Menon wrote:
>
> we should ideally have been using highspeed for i2c bus.
>
> is'nt it better if i2c_check_functionality (and adding required flags
> for func) be used to check the adapter speed and decide this in the
> driver instead of hardcoding the bus speed within TWL6040 -
> considering that 6040 can infact do max high speed as well?
Yeah, I was thinking of something similar. Just did not found the API to get
the speed the i2c bus has been configured to.
I'll check this.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Nishanth Menon <nm@ti.com>, Lee Jones <lee.jones@linaro.org>
Cc: <florian.vaussard@epfl.ch>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 1/3] mfd: twl6040: Select i2c fast mode as default with regmap patch
Date: Thu, 27 Feb 2014 16:33:09 +0200 [thread overview]
Message-ID: <530F4CA5.6030502@ti.com> (raw)
In-Reply-To: <530F4A84.9070906@ti.com>
On 02/27/2014 04:24 PM, Nishanth Menon wrote:
>
> we should ideally have been using highspeed for i2c bus.
>
> is'nt it better if i2c_check_functionality (and adding required flags
> for func) be used to check the adapter speed and decide this in the
> driver instead of hardcoding the bus speed within TWL6040 -
> considering that 6040 can infact do max high speed as well?
Yeah, I was thinking of something similar. Just did not found the API to get
the speed the i2c bus has been configured to.
I'll check this.
--
Péter
next prev parent reply other threads:[~2014-02-27 14:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 13:56 [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock Peter Ujfalusi
2014-02-27 13:56 ` Peter Ujfalusi
2014-02-27 13:56 ` [PATCH 1/3] mfd: twl6040: Select i2c fast mode as default with regmap patch Peter Ujfalusi
2014-02-27 13:56 ` Peter Ujfalusi
2014-02-27 14:24 ` Nishanth Menon
2014-02-27 14:24 ` Nishanth Menon
2014-02-27 14:33 ` Peter Ujfalusi [this message]
2014-02-27 14:33 ` Peter Ujfalusi
2014-02-27 15:00 ` Nishanth Menon
2014-02-27 15:00 ` Nishanth Menon
2014-02-28 7:39 ` Peter Ujfalusi
2014-02-28 7:39 ` Peter Ujfalusi
2014-02-28 13:30 ` Nishanth Menon
2014-02-28 13:30 ` Nishanth Menon
2014-02-28 14:26 ` Peter Ujfalusi
2014-02-28 14:26 ` Peter Ujfalusi
2014-02-28 15:07 ` Nishanth Menon
2014-02-28 15:07 ` Nishanth Menon
2014-03-03 11:30 ` Peter Ujfalusi
2014-03-03 11:30 ` Peter Ujfalusi
2014-02-27 13:56 ` [PATCH 2/3] mfd: twl6040: Move register patching earlier in probe Peter Ujfalusi
2014-02-27 13:56 ` Peter Ujfalusi
2014-02-27 13:56 ` [PATCH 3/3] mfd: twl6040: Clear the interrupt ID register before requesting IRQ Peter Ujfalusi
2014-02-27 13:56 ` Peter Ujfalusi
2014-02-27 15:11 ` [PATCH 0/3] mfd: twl6040: Updates for i2s speed and fix for chip deadlock Florian Vaussard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F4CA5.6030502@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=florian.vaussard@epfl.ch \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.