From: "H. Peter Anvin" <hpa@zytor.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andi Kleen <ak@linux.intel.com>,
Stefani Seibold <stefani@seibold.net>, X86 ML <x86@kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
John Stultz <john.stultz@linaro.org>,
Pavel Emelyanov <xemul@parallels.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
andriy.shevchenko@linux.intel.com,
Martin.Runge@rohde-schwarz.com, Andreas.Brief@rohde-schwarz.com
Subject: Re: [PATCH 1/2] x86: Mark __vdso entries as asmlinkage
Date: Thu, 27 Feb 2014 15:12:17 -0800 [thread overview]
Message-ID: <530FC651.8090102@zytor.com> (raw)
In-Reply-To: <CALCETrWXO8zxvjbT9usjghkM_MEzGOa9_18x7xXPcOOPYeXijA@mail.gmail.com>
On 02/27/2014 12:11 PM, Andy Lutomirski wrote:
>
> Hmm. This sort of goes against existing x86_32 practice where,
> AFAICT, things that need a particular calling convention specify
> asmlinkage and everything else uses regparm(3) if config/kbuild thinks
> it's appropriate.
>
That is not really true for things that aren't part of the kernel image
proper (e.g. the real mode code and so on.) This is a very special case.
> But I'm happy to resubmit the patch if you prefer the CFLAGS approach
> for the 32-bit vdso. I don't think anything will break, since I don't
> think that the 32-bit vdso has any other exported C code.
I think it is the better way to go.
>> It isn't any faster if the C library has to provide a wrapper just to
>> marshal parameters.
>
> Probably true, given that the glibc wrapper could, in principle, use
> an optimized tail call. Also, I see no reason why vdso functions,
> alone of all userspace code, should be special.
Yes, let's stick to the standard ABI. The syscall entry point was very
special.
-hpa
next prev parent reply other threads:[~2014-02-27 23:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 19:34 Final: Add 32 bit VDSO time function support Stefani Seibold
2014-02-26 20:10 ` Andy Lutomirski
2014-02-26 20:45 ` Greg KH
2014-02-26 20:54 ` Andy Lutomirski
2014-02-27 0:55 ` Andy Lutomirski
2014-02-27 1:02 ` [PATCH 0/2] Improvements/fixes to 32-bit vdso timing Andy Lutomirski
2014-02-27 1:02 ` [PATCH 1/2] x86: Mark __vdso entries as asmlinkage Andy Lutomirski
2014-02-27 3:25 ` H. Peter Anvin
2014-02-27 3:39 ` Andi Kleen
2014-02-27 5:06 ` H. Peter Anvin
2014-02-27 5:19 ` Andy Lutomirski
2014-02-27 5:22 ` H. Peter Anvin
2014-02-27 20:11 ` Andy Lutomirski
2014-02-27 23:12 ` H. Peter Anvin [this message]
2014-02-27 5:07 ` H. Peter Anvin
2014-02-27 1:02 ` [PATCH 2/2] x86: Inline the CLOCK_MONOTONIC vdso code Andy Lutomirski
2014-02-28 0:18 ` [PATCH v2 0/4] vDSO fixes, on top of tip/x86/vdso Andy Lutomirski
2014-02-28 0:18 ` [PATCH v2 1/4] x86: Use the default ABI for the 32-bit vDSO Andy Lutomirski
2014-02-28 7:28 ` Stefani Seibold
2014-02-28 15:06 ` H. Peter Anvin
2014-02-28 20:19 ` Andy Lutomirski
2014-03-01 13:43 ` Stefani Seibold
2014-02-28 0:18 ` [PATCH v2 2/4] x86: Inline the CLOCK_MONOTONIC vdso code Andy Lutomirski
2014-02-28 0:18 ` [PATCH v2 3/4] x86: Patch alternatives in the 32-bit vDSO Andy Lutomirski
2014-02-28 7:22 ` Stefani Seibold
2014-03-01 14:04 ` Stefani Seibold
2014-02-28 0:18 ` [PATCH v2 4/4] x86: Zero-pad the VVAR page Andy Lutomirski
2014-02-28 7:33 ` [PATCH v2 0/4] vDSO fixes, on top of tip/x86/vdso Stefani Seibold
2014-02-28 20:15 ` Andy Lutomirski
2014-03-01 14:02 ` Stefani Seibold
2014-02-28 7:22 ` Final: Add 32 bit VDSO time function support Stefani Seibold
2014-03-01 2:00 ` Andy Lutomirski
2014-03-01 22:56 ` H. Peter Anvin
2014-03-02 8:01 ` Stefani Seibold
2014-02-27 5:07 ` H. Peter Anvin
2014-02-27 12:14 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530FC651.8090102@zytor.com \
--to=hpa@zytor.com \
--cc=Andreas.Brief@rohde-schwarz.com \
--cc=Martin.Runge@rohde-schwarz.com \
--cc=aarcange@redhat.com \
--cc=ak@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gorcunov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=stefani@seibold.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.