From: Stephen Boyd <sboyd@codeaurora.org>
To: Sebastian Capella <sebastian.capella@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linaro-kernel@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
"Russ Dill" <Russ.Dill@ti.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Russell King" <linux@arm.linux.org.uk>,
"Len Brown" <len.brown@intel.com>,
"Nicolas Pitre" <nico@linaro.org>,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
"Will Deacon" <will.deacon@arm.com>,
"Jonathan Austin" <jonathan.austin@arm.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v6 2/2] ARM hibernation / suspend-to-disk
Date: Thu, 27 Feb 2014 16:09:51 -0800 [thread overview]
Message-ID: <530FD3CF.2040900@codeaurora.org> (raw)
In-Reply-To: <1393545478-14908-3-git-send-email-sebastian.capella@linaro.org>
On 02/27/14 15:57, Sebastian Capella wrote:
> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
> index 8756e4b..1079ea8 100644
> --- a/arch/arm/include/asm/memory.h
> +++ b/arch/arm/include/asm/memory.h
> @@ -291,6 +291,7 @@ static inline void *phys_to_virt(phys_addr_t x)
> */
> #define __pa(x) __virt_to_phys((unsigned long)(x))
> #define __va(x) ((void *)__phys_to_virt((phys_addr_t)(x)))
> +#define __pa_symbol(x) __pa(RELOC_HIDE((unsigned long)(x), 0))
Just curious, is there a reason for the RELOC_HIDE() here? Or
__pa_symbol() for that matter? It looks like only x86 uses this on the
__nosave_{begin,end} symbol. Maybe it's copy-pasta?
I also wonder if anyone has thought about making a __weak
pfn_is_nosave() function so that architectures don't need to implement
the same thing every time. Consolidating those shouldn't be part of this
patch though.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 2/2] ARM hibernation / suspend-to-disk
Date: Thu, 27 Feb 2014 16:09:51 -0800 [thread overview]
Message-ID: <530FD3CF.2040900@codeaurora.org> (raw)
In-Reply-To: <1393545478-14908-3-git-send-email-sebastian.capella@linaro.org>
On 02/27/14 15:57, Sebastian Capella wrote:
> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
> index 8756e4b..1079ea8 100644
> --- a/arch/arm/include/asm/memory.h
> +++ b/arch/arm/include/asm/memory.h
> @@ -291,6 +291,7 @@ static inline void *phys_to_virt(phys_addr_t x)
> */
> #define __pa(x) __virt_to_phys((unsigned long)(x))
> #define __va(x) ((void *)__phys_to_virt((phys_addr_t)(x)))
> +#define __pa_symbol(x) __pa(RELOC_HIDE((unsigned long)(x), 0))
Just curious, is there a reason for the RELOC_HIDE() here? Or
__pa_symbol() for that matter? It looks like only x86 uses this on the
__nosave_{begin,end} symbol. Maybe it's copy-pasta?
I also wonder if anyone has thought about making a __weak
pfn_is_nosave() function so that architectures don't need to implement
the same thing every time. Consolidating those shouldn't be part of this
patch though.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-28 0:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 23:57 [PATCH v6 0/2] hibernation support on ARM Sebastian Capella
2014-02-27 23:57 ` Sebastian Capella
2014-02-27 23:57 ` [PATCH v6 1/2] ARM: avoid tracers in soft_restart Sebastian Capella
2014-02-27 23:57 ` Sebastian Capella
2014-02-27 23:57 ` [PATCH v6 2/2] ARM hibernation / suspend-to-disk Sebastian Capella
2014-02-27 23:57 ` Sebastian Capella
2014-02-28 0:09 ` Stephen Boyd [this message]
2014-02-28 0:09 ` Stephen Boyd
2014-02-28 1:47 ` Russ Dill
2014-02-28 1:47 ` Russ Dill
2014-02-28 1:47 ` Russ Dill
2014-02-28 2:19 ` Stephen Boyd
2014-02-28 2:19 ` Stephen Boyd
2014-02-28 10:20 ` Russell King - ARM Linux
2014-02-28 10:20 ` Russell King - ARM Linux
[not found] ` <20140228181731.29118.41809@capellas-linux>
2014-03-05 2:28 ` Sebastian Capella
2014-03-05 2:28 ` Sebastian Capella
2014-03-05 2:28 ` Sebastian Capella
2014-06-02 16:57 ` Sebastian Capella
2014-06-02 16:57 ` Sebastian Capella
2014-02-28 9:50 ` Lorenzo Pieralisi
2014-02-28 9:50 ` Lorenzo Pieralisi
2014-02-28 20:15 ` Sebastian Capella
2014-02-28 20:15 ` Sebastian Capella
2014-02-28 22:49 ` Lorenzo Pieralisi
2014-02-28 22:49 ` Lorenzo Pieralisi
2014-02-28 23:38 ` Sebastian Capella
2014-02-28 23:38 ` Sebastian Capella
2014-03-04 9:55 ` Sebastian Capella
2014-03-04 9:55 ` Sebastian Capella
2014-03-04 11:17 ` Lorenzo Pieralisi
2014-03-04 11:17 ` Lorenzo Pieralisi
2014-03-05 0:18 ` Sebastian Capella
2014-03-05 0:18 ` Sebastian Capella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530FD3CF.2040900@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Russ.Dill@ti.com \
--cc=catalin.marinas@arm.com \
--cc=jonathan.austin@arm.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=nico@linaro.org \
--cc=rjw@rjwysocki.net \
--cc=santosh.shilimkar@ti.com \
--cc=sebastian.capella@linaro.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.