From: Richard Weinberger <richard@nod.at>
To: Christoph Hellwig <hch@infradead.org>,
Andrew Ruder <andrew.ruder@elecsyscorp.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [HACK] fs/super.c: sync ro remount after blocking writers
Date: Fri, 28 Feb 2014 10:25:24 +0100 [thread overview]
Message-ID: <53105604.4050501@nod.at> (raw)
In-Reply-To: <20140203102303.GB11829@infradead.org>
Andrew,
Am 03.02.2014 11:23, schrieb Christoph Hellwig:
> On Thu, Jan 30, 2014 at 09:26:54AM -0600, Andrew Ruder wrote:
>> Move sync_filesystem() after sb_prepare_remount_readonly(). If writers
>> sneak in anywhere from sync_filesystem() to sb_prepare_remount_readonly()
>> it can cause inodes to be dirtied and writeback to occur well after
>> sys_mount() has completely successfully.
>>
>> This was spotted by corrupted ubifs filesystems on reboot, but appears
>> that it can cause issues with any filesystem using writeback.
>
> From the link that Richard posted it seems like you have a testcase.
> Can you please integrate it into xfstests so that we can properly
> regression test for this issue from now on?
Is it possible to create such a test case?
I don't know whether it is possible to trigger the issue on
a regular filesystem.
But as hch noted, it would be nice to have. :)
Thanks,
//richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Christoph Hellwig <hch@infradead.org>,
Andrew Ruder <andrew.ruder@elecsyscorp.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [HACK] fs/super.c: sync ro remount after blocking writers
Date: Fri, 28 Feb 2014 10:25:24 +0100 [thread overview]
Message-ID: <53105604.4050501@nod.at> (raw)
In-Reply-To: <20140203102303.GB11829@infradead.org>
Andrew,
Am 03.02.2014 11:23, schrieb Christoph Hellwig:
> On Thu, Jan 30, 2014 at 09:26:54AM -0600, Andrew Ruder wrote:
>> Move sync_filesystem() after sb_prepare_remount_readonly(). If writers
>> sneak in anywhere from sync_filesystem() to sb_prepare_remount_readonly()
>> it can cause inodes to be dirtied and writeback to occur well after
>> sys_mount() has completely successfully.
>>
>> This was spotted by corrupted ubifs filesystems on reboot, but appears
>> that it can cause issues with any filesystem using writeback.
>
> From the link that Richard posted it seems like you have a testcase.
> Can you please integrate it into xfstests so that we can properly
> regression test for this issue from now on?
Is it possible to create such a test case?
I don't know whether it is possible to trigger the issue on
a regular filesystem.
But as hch noted, it would be nice to have. :)
Thanks,
//richard
next prev parent reply other threads:[~2014-02-28 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 15:26 [HACK] fs/super.c: sync ro remount after blocking writers Andrew Ruder
2014-01-30 15:26 ` Andrew Ruder
2014-01-31 8:20 ` Richard Weinberger
2014-01-31 8:20 ` Richard Weinberger
2014-02-03 10:23 ` Christoph Hellwig
2014-02-03 10:23 ` Christoph Hellwig
2014-02-28 9:25 ` Richard Weinberger [this message]
2014-02-28 9:25 ` Richard Weinberger
2014-03-03 21:12 ` Andrew Ruder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53105604.4050501@nod.at \
--to=richard@nod.at \
--cc=andrew.ruder@elecsyscorp.com \
--cc=dedekind1@gmail.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.