From: "Andreas Färber" <afaerber@suse.de>
To: "Jason J. Herne" <jjherne@us.ibm.com>, borntraeger@de.ibm.com
Cc: agraf@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements
Date: Fri, 28 Feb 2014 17:30:11 +0100 [thread overview]
Message-ID: <5310B993.6080809@suse.de> (raw)
In-Reply-To: <1393435114-26374-3-git-send-email-jjherne@us.ibm.com>
Am 26.02.2014 18:18, schrieb Jason J. Herne:
> From: "Jason J. Herne" <jjherne@us.ibm.com>
>
> Modify s390_cpu_addr2state to allow fetching state information for cpu addresses
> above smp_cpus. Hotplug requires this capability.
>
> Also add s390_cpu_set_state function to allow modification of ipi_state entries
> during hotplug.
>
> Signed-off-by: Jason J. Herne <jjherne@us.ibm.com>
This patch is *still* present despite your previous response that you
incorporated my review comments. You are adding a custom s390x API here
rather than reusing the generic QOM API as requested. I don't even read
further in such cases - like I pointed out, a pure resend is not helping
address review feedback!
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-02-28 16:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 17:18 [Qemu-devel] [PATCH 0/4] s390 cpu-hotplug implementation Jason J. Herne
2014-02-26 17:18 ` [Qemu-devel] [PATCH 1/4] s390: Storage key global access Jason J. Herne
2014-02-26 17:18 ` [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements Jason J. Herne
2014-02-28 16:30 ` Andreas Färber [this message]
2014-03-06 14:54 ` Jason J. Herne
2014-03-06 16:23 ` Jason J. Herne
2014-02-26 17:18 ` [Qemu-devel] [PATCH 3/4] s390-cpu: s390 cpu init improvements for hotplug Jason J. Herne
2014-02-26 17:18 ` [Qemu-devel] [PATCH 4/4] s390-hotplug: Implement hot_add_cpu hook Jason J. Herne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310B993.6080809@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=jjherne@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.