All of lore.kernel.org
 help / color / mirror / Atom feed
* [Powertop] [PATCH] Add csstosh.sh to EXTRA_DIST
@ 2014-06-13 12:07 Tobias Klauser
  0 siblings, 0 replies; 2+ messages in thread
From: Tobias Klauser @ 2014-06-13 12:07 UTC (permalink / raw)
  To: powertop

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

Since css.h is in CLEANFILES, `make clean' will delete it and thus
cause the build to fail afterwards due to a missing csstoh.sh to
regenerate it. Fix this by adding csstoh.sh to EXTRA_DIST which will
cause it to be included in the tarball.

Signed-off-by: Tobias Klauser <tklauser(a)distanz.ch>
---
 src/Makefile.am |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/Makefile.am b/src/Makefile.am
index 9d053a4..6886388 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -52,3 +52,4 @@ CLEANFILES = css.h
 css.h: powertop.css
 	$(SHELL) ${srcdir}/csstoh.sh ${srcdir}/powertop.css css.h
 
+EXTRA_DIST = ${srcdir}/csstoh.sh
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Powertop] [PATCH] Add csstosh.sh to EXTRA_DIST
@ 2014-06-18 19:26 Alexandra Yates
  0 siblings, 0 replies; 2+ messages in thread
From: Alexandra Yates @ 2014-06-18 19:26 UTC (permalink / raw)
  To: powertop

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]


> Since css.h is in CLEANFILES, `make clean' will delete it and thus
> cause the build to fail afterwards due to a missing csstoh.sh to
> regenerate it. Fix this by adding csstoh.sh to EXTRA_DIST which will
> cause it to be included in the tarball.
>
> Signed-off-by: Tobias Klauser <tklauser(a)distanz.ch>
> ---
>  src/Makefile.am |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 9d053a4..6886388 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -52,3 +52,4 @@ CLEANFILES = css.h
>  css.h: powertop.css
>  	$(SHELL) ${srcdir}/csstoh.sh ${srcdir}/powertop.css css.h
>
> +EXTRA_DIST = ${srcdir}/csstoh.sh
> --
> 1.7.9.5
>
>
> _______________________________________________
> PowerTop mailing list
> PowerTop(a)lists.01.org
> https://lists.01.org/mailman/listinfo/powertop
>

Hi Tobias,

I tested your patch in two boxes, it did the trick.

Thank you for fixing the bug.

Alexandra.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-06-18 19:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-18 19:26 [Powertop] [PATCH] Add csstosh.sh to EXTRA_DIST Alexandra Yates
  -- strict thread matches above, loose matches on Subject: below --
2014-06-13 12:07 Tobias Klauser

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.