Re: [PATCH 0/7] mfd: AXP20x: Add support for AXP202 and AXP209

[Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Hi Carlo,

Great work, thanks for all the time you're putting into this!

I've 2 questions:

1) What dependencies does this patch-set have? Obviously it needs the NMI irq
patches for A20, anything else ?  I no longer see any use of a special flag
for ack on unmask, is that no longer needed ?

2) No poweroff functionality ? That would be really great to have.

Regards,

Hans




On 03/01/2014 05:45 PM, Carlo Caione wrote:
> AXP209 and AXP202 are the PMUs (Power Management Unit) used by A10, A13
> and A20 SoCs and developed by X-Powers, a sister company of Allwinner.
> AXP20x comprises an adaptive USB-Compatible PWM charger, 2 BUCK DC-DC
> converters, 5 LDOs, multiple 12-bit ADCs of voltage, current and temperature
> as well as 4 configurable GPIOs. 
> 
> This set of patches introduces the core driver and support for two different
> subsystems:
> 	- Regulators
> 	- PEK (Power Enable Key)
> 
> Support for AXP209 in Cubieboard2 is also added.
> 
> Carlo Caione (7):
>   mfd: AXP20x: Add mfd driver for AXP20x PMIC
>   mfd: AXP20x: Add bindings documentation
>   ARM: dts: cubieboard2: Add AXP209 support
>   input: misc: Add driver for AXP20x Power Enable Key
>   input: misc: Add ABI docs for AXP20x PEK
>   regulator: AXP20x: Add support for regulators subsystem
>   ARM: dts: Cubieboard2: Add support for AXP209 regulators
> 
>  .../ABI/testing/sysfs-driver-input-axp-pek         |  11 +
>  Documentation/devicetree/bindings/mfd/axp20x.txt   |  93 ++++++
>  arch/arm/boot/dts/sun7i-a20-cubieboard2.dts        |  58 ++++
>  arch/arm/configs/sunxi_defconfig                   |   4 +
>  drivers/input/misc/Kconfig                         |  11 +
>  drivers/input/misc/Makefile                        |   1 +
>  drivers/input/misc/axp20x-pek.c                    | 265 ++++++++++++++++
>  drivers/mfd/Kconfig                                |  12 +
>  drivers/mfd/Makefile                               |   1 +
>  drivers/mfd/axp20x.c                               | 250 +++++++++++++++
>  drivers/regulator/Kconfig                          |   7 +
>  drivers/regulator/Makefile                         |   1 +
>  drivers/regulator/axp20x-regulator.c               | 349 +++++++++++++++++++++
>  include/linux/mfd/axp20x.h                         | 180 +++++++++++
>  14 files changed, 1243 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-input-axp-pek
>  create mode 100644 Documentation/devicetree/bindings/mfd/axp20x.txt
>  create mode 100644 drivers/input/misc/axp20x-pek.c
>  create mode 100644 drivers/mfd/axp20x.c
>  create mode 100644 drivers/regulator/axp20x-regulator.c
>  create mode 100644 include/linux/mfd/axp20x.h
>