From: Alex Elder <elder@ieee.org>
To: "Yan, Zheng" <ukernel@gmail.com>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>,
ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] ceph: fix ceph_dir_llseek()
Date: Sat, 01 Mar 2014 19:06:55 -0600 [thread overview]
Message-ID: <5312842F.9040505@ieee.org> (raw)
In-Reply-To: <CAAM7YAk+6jo6x0M3Hm1vxpkGaXVDpCORyWK0Xwa6+23m6j3GsQ@mail.gmail.com>
On 02/28/2014 06:14 PM, Yan, Zheng wrote:
>>> >>@@ -474,7 +474,7 @@ static loff_t ceph_dir_llseek(struct file *file, loff_t offset, int whence)
>>> >> {
>>> >> struct ceph_file_info *fi = file->private_data;
>>> >> struct inode *inode = file->f_mapping->host;
>>> >>- loff_t old_offset = offset;
>>> >>+ loff_t old_offset = ceph_make_fpos(fi->frag, fi->next_offset);
>> >
>> >Should this be named "next_offset" (or maybe "current_offset")?
>> >It doesn't seem "old" to me, though I do realize it doesn't
>> >necessarily represent where the "next" file position will be.
>> >
> No. next_offset is the position where next readdir request will be.
I guess "old_next_offset" is what it is but in any case looking
again I see what you mean now. Thanks.
-Alex
prev parent reply other threads:[~2014-03-02 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 9:07 [PATCH] ceph: fix ceph_dir_llseek() Yan, Zheng
2014-02-28 14:05 ` Alex Elder
2014-03-01 0:14 ` Yan, Zheng
2014-03-02 1:06 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5312842F.9040505@ieee.org \
--to=elder@ieee.org \
--cc=ceph-devel@vger.kernel.org \
--cc=ukernel@gmail.com \
--cc=zheng.z.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.