[U-Boot] logo part Makefile doesn't work as expected

[U-Boot] logo part Makefile doesn't work as expected

[Bo Shen]

Hi Masahiro Yamada,
   Today, I tested with u-boot master branch, I found the u-boot logo is 
not set as we expected. The following line's do not executed as 
expected, as the BOARD and VENDOR parameter value is not passed to 
<tools/Makefile>. So, if not define LOGO_BMP, it always take the first 
value.
   I try some method to fix it, it works, however I am not familiar with 
whole build system, so can you help to fix it? Thanks.

--->8---
# Generic logo
ifeq ($(LOGO_BMP),)
LOGO_BMP= $(srctree)/$(src)/logos/denx.bmp

# Use board logo and fallback to vendor
ifneq ($(wildcard logos/$(BOARD).bmp),)
LOGO_BMP= $(srctree)/$(src)/logos/$(BOARD).bmp
else
ifneq ($(wildcard logos/$(VENDOR).bmp),)
LOGO_BMP= $(srctree)/$(src)/logos/$(VENDOR).bmp
endif
endif
---8<---

Best Regards,
Bo Shen

[U-Boot] logo part Makefile doesn't work as expected

[Masahiro Yamada]

Hello Bo,

On Mon, 3 Mar 2014 17:09:03 +0800
Bo Shen <voice.shen@atmel.com> wrote:

> Hi Masahiro Yamada,
>    Today, I tested with u-boot master branch, I found the u-boot logo is not set as we expected. The following line's do not executed as expected, as the BOARD and VENDOR parameter value is not passed to <tools/Makefile>. So, if not define LOGO_BMP, it always take the first value.
>    I try some method to fix it, it works, however I am not familiar with whole build system, so can you help to fix it? Thanks.
> 
> --->8---
> # Generic logo
> ifeq ($(LOGO_BMP),)
> LOGO_BMP= $(srctree)/$(src)/logos/denx.bmp
> 
> # Use board logo and fallback to vendor
> ifneq ($(wildcard logos/$(BOARD).bmp),)
> LOGO_BMP= $(srctree)/$(src)/logos/$(BOARD).bmp
> else
> ifneq ($(wildcard logos/$(VENDOR).bmp),)
> LOGO_BMP= $(srctree)/$(src)/logos/$(VENDOR).bmp
> endif
> endif
> ---8<---

Sorry.
As you say, this is a bug introduced by Kbuild series.

BOARD and VENDOR parameter value is passed
to <tools/Makefile>, but $(wildcard ...) was not described
correctly.

I have posted a patch with your Reported-by credit.

Thanks for your reporting!

Best Regards
Masahiro Yamada