All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Alexandre Courbot
	<acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] ARM: tegra: add device tree for SHIELD
Date: Mon, 03 Mar 2014 10:00:43 -0700	[thread overview]
Message-ID: <5314B53B.4010107@wwwdotorg.org> (raw)
In-Reply-To: <1393818596-26775-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

On 03/02/2014 08:49 PM, Alexandre Courbot wrote:
> Add a device tree for NVIDIA SHIELD. The set of enabled features is
> still minimal with no display option and USB requiring external power.
> 
> A default kernel command-line as well as initrd addresses are hardcoded
> to match the static values the bootloader is known to use. This allows
> booting from an appended DTB without having to alter it at boot time,
> since the bootloader has no Device Tree support.

This and the TN7 patch look fine. Hopefully I'll apply them soon,
pending the ti,irq-externally-inverted discussion.

> +	/* SD card */

Oh, that's all you meant by wanting to add comments? I guess I just
recognize SD-vs-eMMC by the bus width, but adding the comments is a good
idea.

WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: tegra: add device tree for SHIELD
Date: Mon, 03 Mar 2014 10:00:43 -0700	[thread overview]
Message-ID: <5314B53B.4010107@wwwdotorg.org> (raw)
In-Reply-To: <1393818596-26775-1-git-send-email-acourbot@nvidia.com>

On 03/02/2014 08:49 PM, Alexandre Courbot wrote:
> Add a device tree for NVIDIA SHIELD. The set of enabled features is
> still minimal with no display option and USB requiring external power.
> 
> A default kernel command-line as well as initrd addresses are hardcoded
> to match the static values the bootloader is known to use. This allows
> booting from an appended DTB without having to alter it at boot time,
> since the bootloader has no Device Tree support.

This and the TN7 patch look fine. Hopefully I'll apply them soon,
pending the ti,irq-externally-inverted discussion.

> +	/* SD card */

Oh, that's all you meant by wanting to add comments? I guess I just
recognize SD-vs-eMMC by the bus width, but adding the comments is a good
idea.

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren@wwwdotorg.org>
To: Alexandre Courbot <acourbot@nvidia.com>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
	gnurou@gmail.com
Subject: Re: [PATCH] ARM: tegra: add device tree for SHIELD
Date: Mon, 03 Mar 2014 10:00:43 -0700	[thread overview]
Message-ID: <5314B53B.4010107@wwwdotorg.org> (raw)
In-Reply-To: <1393818596-26775-1-git-send-email-acourbot@nvidia.com>

On 03/02/2014 08:49 PM, Alexandre Courbot wrote:
> Add a device tree for NVIDIA SHIELD. The set of enabled features is
> still minimal with no display option and USB requiring external power.
> 
> A default kernel command-line as well as initrd addresses are hardcoded
> to match the static values the bootloader is known to use. This allows
> booting from an appended DTB without having to alter it at boot time,
> since the bootloader has no Device Tree support.

This and the TN7 patch look fine. Hopefully I'll apply them soon,
pending the ti,irq-externally-inverted discussion.

> +	/* SD card */

Oh, that's all you meant by wanting to add comments? I guess I just
recognize SD-vs-eMMC by the bus width, but adding the comments is a good
idea.

  parent reply	other threads:[~2014-03-03 17:00 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03  3:49 [PATCH] ARM: tegra: add device tree for SHIELD Alexandre Courbot
2014-03-03  3:49 ` Alexandre Courbot
2014-03-03  3:49 ` Alexandre Courbot
     [not found] ` <1393818596-26775-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-03-03  3:53   ` Alexandre Courbot
2014-03-03  3:53     ` Alexandre Courbot
2014-03-03  3:53     ` Alexandre Courbot
2014-03-03 17:00   ` Stephen Warren [this message]
2014-03-03 17:00     ` Stephen Warren
2014-03-03 17:00     ` Stephen Warren
2014-03-04  1:24     ` Alexandre Courbot
2014-03-04  1:24       ` Alexandre Courbot
2014-03-04  1:24       ` Alexandre Courbot
  -- strict thread matches above, loose matches on Subject: below --
2014-02-24 10:26 Alexandre Courbot
2014-02-24 10:26 ` Alexandre Courbot
2014-02-24 10:26 ` Alexandre Courbot
     [not found] ` <1393237593-28121-1-git-send-email-acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-24 18:53   ` Stephen Warren
2014-02-24 18:53     ` Stephen Warren
2014-02-24 18:53     ` Stephen Warren
2014-02-25  2:13     ` Alexandre Courbot
2014-02-25  2:13       ` Alexandre Courbot
2014-02-25  2:13       ` Alexandre Courbot
     [not found]       ` <530BFC58.6020003-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-25  9:52         ` Arend van Spriel
2014-02-25  9:52           ` Arend van Spriel
2014-02-25  9:52           ` Arend van Spriel
     [not found]           ` <530C67F4.7010208-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2014-02-26  4:52             ` Alexandre Courbot
2014-02-26  4:52               ` Alexandre Courbot
2014-02-26  4:52               ` Alexandre Courbot
2014-02-26 21:10               ` Arend van Spriel
2014-02-26 21:10                 ` Arend van Spriel
2014-02-25 22:38         ` Stephen Warren
2014-02-25 22:38           ` Stephen Warren
2014-02-25 22:38           ` Stephen Warren
     [not found]           ` <530D1B7A.9070209-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2014-02-26  4:58             ` Alexandre Courbot
2014-02-26  4:58               ` Alexandre Courbot
2014-02-26  4:58               ` Alexandre Courbot
     [not found]               ` <530D748D.6010802-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2014-02-26  5:02                 ` Stephen Warren
2014-02-26  5:02                   ` Stephen Warren
2014-02-26  5:02                   ` Stephen Warren
2014-02-26  5:12                   ` Alexandre Courbot
2014-02-26  5:12                     ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5314B53B.4010107@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.