From: Stefan Weil <sw@weilnetz.de>
To: Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] git build from clean broken?
Date: Tue, 04 Mar 2014 07:57:47 +0100 [thread overview]
Message-ID: <5315796B.4050001@weilnetz.de> (raw)
In-Reply-To: <CAFEAcA_DnaGr52onn9C8WE4wUuE4nJe78u+vcKUFKXRa8+4gNw@mail.gmail.com>
Am 04.03.2014 00:50, schrieb Peter Maydell:
>
> Do we have a definite version of this fix which everybody is happy
> with yet? I've got confused with the various versions and review
> comments on them. I'd like to apply the buildfix before I apply
> any further pull requests...
>
> thanks
> -- PMM
Simply take the version without confusing review comments:
http://patchwork.ozlabs.org/patch/324909/. :-)
To be honest: the other patch fixes one build regression and introduces
a new one, so it would not improve the situation.
Paolo noticed that Makefile is a mess in some parts, and I agree. But
that is something which can be handled separately.
Regards
Stefan
next prev parent reply other threads:[~2014-03-04 6:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 19:38 [Qemu-devel] git build from clean broken? Peter Maydell
2014-02-27 19:57 ` Stefan Weil
2014-02-27 21:50 ` Paolo Bonzini
2014-02-27 22:17 ` Peter Maydell
2014-02-27 22:23 ` Paolo Bonzini
2014-02-27 22:55 ` Peter Maydell
2014-03-03 23:50 ` Peter Maydell
2014-03-04 6:57 ` Stefan Weil [this message]
2014-03-04 7:10 ` Paolo Bonzini
2014-02-27 20:01 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315796B.4050001@weilnetz.de \
--to=sw@weilnetz.de \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.