Re: [PATCH v2] IOMMU: enhance dmar to support device hotplug

[Yijing Wang <wangyijing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>]

On 2014/3/4 22:31, Joerg Roedel wrote:
> On Thu, Nov 21, 2013 at 04:21:56PM +0800, Yijing Wang wrote:
>> @@ -3641,21 +3681,42 @@ static int device_notifier(struct notifier_block *nb,
>>  	struct device *dev = data;
>>  	struct pci_dev *pdev = to_pci_dev(dev);
>>  	struct dmar_domain *domain;
>> +	struct dmar_device *dmar_dev;
>> +	struct dmar_drhd_unit *drhd;
>>  
>> -	if (iommu_no_mapping(dev))
>> -		return 0;
>> -
>> -	domain = find_domain(pdev);
>> -	if (!domain)
>> -		return 0;
>> +	switch (action) {
>> +	case BUS_NOTIFY_ADD_DEVICE:
>> +		for_each_drhd_unit(drhd)
>> +			list_for_each_entry(dmar_dev, &drhd->devices, list)
>> +				if (dmar_dev->segment == pci_domain_nr(pdev->bus)
>> +					&& dmar_dev->bus == pdev->bus->number
>> +					&& dmar_dev->devfn == pdev->devfn)
>> +					dmar_dev->pdev = pci_dev_get(pdev);
>> +		break;
>> +	case BUS_NOTIFY_DEL_DEVICE:
>> +		for_each_drhd_unit(drhd)
>> +			list_for_each_entry(dmar_dev, &drhd->devices, list)
>> +				if (dmar_dev->pdev == pdev) {
>> +					pci_dev_put(pdev);
>> +					dmar_dev->pdev = NULL;
>> +				}
> 
> How is that synchronized with other users of this dmar_dev structure.
> Could it happen that you drop the device reference while other parts of
> the driver still use it?

Hi Joerg,
   Thanks for your review and comments!
We use original struct dmar_drhd_unit->devices to attach the pci device to specific DMAR,
eg. use dmar_find_matched_drhd_unit() to find the attached DMAR by pci_dev * pointer.
So if the related pci_dev was removed, I think we can safely set dmar_dev->pdev = NULL;
No pci device will use it again until the new pci device hot add.

One problem in this solution is PCI bus number maybe changed after device hotplug,
so use the bus,device,function id to update the dmar device scope maybe unreliable.

Jiang Liu also provide a solution to fix this problem by save device scope pathes,
I think that's a good idea.

link:http://lkml.org/lkml/2014/1/7/108

Thanks!
Yijing.


> 
> 
> 	Joerg
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
> .
> 


-- 
Thanks!
Yijing