All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Mauro Carvalho Chehab
	<m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Russell King - ARM Linux
	<linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sylwester Nawrocki
	<s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Laurent Pinchart
	<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>,
	Guennadi Liakhovetski
	<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>,
	Kyungmin Park
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Date: Wed, 5 Mar 2014 13:35:28 +0200	[thread overview]
Message-ID: <53170C00.20200@ti.com> (raw)
In-Reply-To: <1394011242-16783-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]

Hi,

On 05/03/14 11:20, Philipp Zabel wrote:
> Hi,
> 
> this version of the OF graph helper move series further addresses a few of
> Tomi's and Sylwester's comments.
> 
> Changes since v5:
>  - Fixed spelling errors and a wrong device node name in the link section
>  - Added parentless previous endpoint's full name to warning
>  - Fixed documentation comment for of_graph_parse_endpoint
>  - Unrolled for-loop in of_graph_get_remote_port_parent
> 
> Philipp Zabel (8):
>   [media] of: move graph helpers from drivers/media/v4l2-core to
>     drivers/of
>   Documentation: of: Document graph bindings
>   of: Warn if of_graph_get_next_endpoint is called with the root node
>   of: Reduce indentation in of_graph_get_next_endpoint
>   [media] of: move common endpoint parsing to drivers/of
>   of: Implement simplified graph binding for single port devices
>   of: Document simplified graph binding for single port devices
>   of: Warn if of_graph_parse_endpoint is called with the root node

So, as I've pointed out, I don't agree with the API, as it's too limited
and I can't use it, but as this series is (mostly) about moving the
current API to a common place, it's fine for me.

Acked-by: Tomi Valkeinen <tomi.valkeinen-l0cyMroinI0@public.gmane.org>

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Grant Likely <grant.likely@linaro.org>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Rob Herring <robh+dt@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of
Date: Wed, 5 Mar 2014 13:35:28 +0200	[thread overview]
Message-ID: <53170C00.20200@ti.com> (raw)
In-Reply-To: <1394011242-16783-1-git-send-email-p.zabel@pengutronix.de>

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

Hi,

On 05/03/14 11:20, Philipp Zabel wrote:
> Hi,
> 
> this version of the OF graph helper move series further addresses a few of
> Tomi's and Sylwester's comments.
> 
> Changes since v5:
>  - Fixed spelling errors and a wrong device node name in the link section
>  - Added parentless previous endpoint's full name to warning
>  - Fixed documentation comment for of_graph_parse_endpoint
>  - Unrolled for-loop in of_graph_get_remote_port_parent
> 
> Philipp Zabel (8):
>   [media] of: move graph helpers from drivers/media/v4l2-core to
>     drivers/of
>   Documentation: of: Document graph bindings
>   of: Warn if of_graph_get_next_endpoint is called with the root node
>   of: Reduce indentation in of_graph_get_next_endpoint
>   [media] of: move common endpoint parsing to drivers/of
>   of: Implement simplified graph binding for single port devices
>   of: Document simplified graph binding for single port devices
>   of: Warn if of_graph_parse_endpoint is called with the root node

So, as I've pointed out, I don't agree with the API, as it's too limited
and I can't use it, but as this series is (mostly) about moving the
current API to a common place, it's fine for me.

Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]

  parent reply	other threads:[~2014-03-05 11:35 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05  9:20 [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of Philipp Zabel
2014-03-05  9:20 ` Philipp Zabel
     [not found] ` < 20140306152414.GC21483@n2100.arm.linux.org.uk>
2014-03-05  9:20 ` [PATCH v6 1/8] [media] of: move graph helpers from drivers/media/v4l2-core " Philipp Zabel
2014-03-07 18:25   ` Grant Likely
2014-03-07 18:25     ` Grant Likely
2014-03-05  9:20 ` [PATCH v6 4/8] of: Reduce indentation in of_graph_get_next_endpoint Philipp Zabel
2014-03-07  0:12   ` Laurent Pinchart
2014-03-07 17:40     ` Philipp Zabel
     [not found]       ` <1394214054.16309.45.camel-+qGW7pzALmz7o/J7KWpOmN53zsg1cpMQ@public.gmane.org>
2014-03-10 19:19         ` Laurent Pinchart
2014-03-10 19:19           ` Laurent Pinchart
2014-03-11 11:06           ` Philipp Zabel
2014-03-07 18:30   ` Grant Likely
2014-03-07 18:30     ` Grant Likely
2014-03-05  9:20 ` [PATCH v6 6/8] of: Implement simplified graph binding for single port devices Philipp Zabel
2014-03-07 18:38   ` Grant Likely
2014-03-07 18:38     ` Grant Likely
2014-03-09 19:21     ` Philipp Zabel
     [not found] ` <1394011242-16783-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-03-05  9:20   ` [PATCH v6 2/8] Documentation: of: Document graph bindings Philipp Zabel
2014-03-05  9:20     ` Philipp Zabel
2014-03-07 18:27     ` Grant Likely
2014-03-07 18:27       ` Grant Likely
2014-03-10  9:28       ` Philipp Zabel
     [not found]         ` <1394443690.7380.10.camel-+qGW7pzALmz7o/J7KWpOmN53zsg1cpMQ@public.gmane.org>
2014-03-10 11:37           ` Laurent Pinchart
2014-03-10 11:37             ` Laurent Pinchart
2014-03-10 13:57             ` Philipp Zabel
2014-03-05  9:20   ` [PATCH v6 3/8] of: Warn if of_graph_get_next_endpoint is called with the root node Philipp Zabel
2014-03-05  9:20     ` Philipp Zabel
2014-03-07 18:28     ` Grant Likely
2014-03-07 18:28       ` Grant Likely
2014-03-05  9:20   ` [PATCH v6 5/8] [media] of: move common endpoint parsing to drivers/of Philipp Zabel
2014-03-05  9:20     ` Philipp Zabel
2014-03-05  9:20   ` [PATCH v6 7/8] of: Document simplified graph binding for single port devices Philipp Zabel
2014-03-05  9:20     ` Philipp Zabel
2014-03-05  9:20   ` [PATCH v6 8/8] of: Warn if of_graph_parse_endpoint is called with the root node Philipp Zabel
2014-03-05  9:20     ` Philipp Zabel
2014-03-05 11:35   ` Tomi Valkeinen [this message]
2014-03-05 11:35     ` [PATCH v6 0/8] Move device tree graph parsing helpers to drivers/of Tomi Valkeinen
2014-03-05 14:42     ` Philipp Zabel
2014-03-06 14:16       ` Russell King - ARM Linux
     [not found]         ` <20140306141657.GB21483-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-03-06 15:17           ` Mauro Carvalho Chehab
2014-03-06 15:17             ` Mauro Carvalho Chehab
     [not found]             ` <20140306121721.6186dafb-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-06 15:47               ` Sylwester Nawrocki
2014-03-06 15:47                 ` Sylwester Nawrocki
2014-03-06 16:21                 ` Philipp Zabel
     [not found]                   ` <1394122879.3622.47.camel-+qGW7pzALmz7o/J7KWpOmN53zsg1cpMQ@public.gmane.org>
2014-03-06 16:32                     ` Sylwester Nawrocki
2014-03-06 16:32                       ` Sylwester Nawrocki
2014-03-06 16:50                       ` Philipp Zabel
2014-03-07 12:06                         ` Russell King - ARM Linux
2014-03-07  0:16                 ` Laurent Pinchart
2014-03-07 18:41             ` Grant Likely
2014-03-06 15:24 ` Russell King - ARM Linux
2014-03-06 15:39   ` Philipp Zabel
2014-03-06 15:50     ` Russell King - ARM Linux
     [not found]       ` <20140306155018.GD21483-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-03-07 18:49         ` Grant Likely
2014-03-07 18:49           ` Grant Likely
     [not found] ` < 1394011242-16783-6-git-send-email-p.zabel@pengutronix.de>
     [not found]   ` <1394011242-16783-6-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-03-07 18:32     ` [PATCH v6 5/8] [media] of: move common endpoint parsing " Grant Likely
2014-03-07 18:32       ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53170C00.20200@ti.com \
    --to=tomi.valkeinen-l0cymroini0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.chehab-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.