* [PATCH] musicbrainz: Build with B=S
@ 2014-03-01 17:54 mike.looijmans
2014-03-05 18:08 ` Martin Jansa
0 siblings, 1 reply; 4+ messages in thread
From: mike.looijmans @ 2014-03-01 17:54 UTC (permalink / raw)
To: openembedded-devel; +Cc: Mike Looijmans
From: Mike Looijmans <milo-software@users.sourceforge.net>
This recipe doesn't work when B!=S, so force B=$S to fix the failure.
Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
---
.../musicbrainz/libmusicbrainz_git.bb | 3 +++
1 file changed, 3 insertions(+)
diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
index f6a8f53..4cc04b8 100644
--- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
+++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
@@ -37,3 +37,6 @@ do_configure_prepend() {
EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
-DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake"
+
+# out-of-tree building doesn't appear to work for this package.
+B = "${S}"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] musicbrainz: Build with B=S
2014-03-01 17:54 [PATCH] musicbrainz: Build with B=S mike.looijmans
@ 2014-03-05 18:08 ` Martin Jansa
2014-03-05 19:49 ` Mike Looijmans
0 siblings, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2014-03-05 18:08 UTC (permalink / raw)
To: openembedded-devel; +Cc: Mike Looijmans
[-- Attachment #1: Type: text/plain, Size: 1400 bytes --]
On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijmans@topic.nl wrote:
> From: Mike Looijmans <milo-software@users.sourceforge.net>
>
> This recipe doesn't work when B!=S, so force B=$S to fix the failure.
>
> Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
What's the relation of this change to
http://patchwork.openembedded.org/patch/67597/
?
> ---
> .../musicbrainz/libmusicbrainz_git.bb | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> index f6a8f53..4cc04b8 100644
> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
> @@ -37,3 +37,6 @@ do_configure_prepend() {
>
> EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
> -DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake"
> +
> +# out-of-tree building doesn't appear to work for this package.
> +B = "${S}"
> --
> 1.7.9.5
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] musicbrainz: Build with B=S
2014-03-05 18:08 ` Martin Jansa
@ 2014-03-05 19:49 ` Mike Looijmans
2014-03-09 4:54 ` Tim Orling
0 siblings, 1 reply; 4+ messages in thread
From: Mike Looijmans @ 2014-03-05 19:49 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-devel, Mike Looijmans
On 5-3-2014 19:08, Martin Jansa wrote:
> On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijmans@topic.nl wrote:
>> From: Mike Looijmans <milo-software@users.sourceforge.net>
>>
>> This recipe doesn't work when B!=S, so force B=$S to fix the failure.
>>
>> Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
> What's the relation of this change to
> http://patchwork.openembedded.org/patch/67597/
> ?
I suspect they both accomplish the same: Make the project compile again.
Mine is the simplistic approach I guess - I did the least I could
possible get away with... "Theirs" looks more like they actually
understand what's going on
Mike.
>> ---
>> .../musicbrainz/libmusicbrainz_git.bb | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> index f6a8f53..4cc04b8 100644
>> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusicbrainz_git.bb
>> @@ -37,3 +37,6 @@ do_configure_prepend() {
>>
>> EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
>> -DIMPORT_EXECUTABLES=build-native/ImportExecutables.cmake"
>> +
>> +# out-of-tree building doesn't appear to work for this package.
>> +B = "${S}"
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Mike Looijmans
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] musicbrainz: Build with B=S
2014-03-05 19:49 ` Mike Looijmans
@ 2014-03-09 4:54 ` Tim Orling
0 siblings, 0 replies; 4+ messages in thread
From: Tim Orling @ 2014-03-09 4:54 UTC (permalink / raw)
To: openembedded-devel
I may have gone extra steps to get to the bottom of the build error, but my
solution is not even slightly pretty. If it works to just set $B=$S that is
simpler than my do_configure hack. Otherwise we'd have to look into a
change in cmake class which I doubt is justified--or further patch
libmusicbrainz.
KISS.
--Tim
On Wed, Mar 5, 2014 at 11:49 AM, Mike Looijmans <mike.looijmans@topic.nl>wrote:
> On 5-3-2014 19:08, Martin Jansa wrote:
>
>> On Sat, Mar 01, 2014 at 06:54:47PM +0100, mike.looijmans@topic.nl wrote:
>>
>>> From: Mike Looijmans <milo-software@users.sourceforge.net>
>>>
>>> This recipe doesn't work when B!=S, so force B=$S to fix the failure.
>>>
>>> Signed-off-by: Mike Looijmans <milo-software@users.sourceforge.net>
>>>
>> What's the relation of this change to
>> http://patchwork.openembedded.org/patch/67597/
>> ?
>>
>
> I suspect they both accomplish the same: Make the project compile again.
> Mine is the simplistic approach I guess - I did the least I could possible
> get away with... "Theirs" looks more like they actually understand what's
> going on
>
> Mike.
>
>
>
> ---
>>> .../musicbrainz/libmusicbrainz_git.bb | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb b/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb
>>> index f6a8f53..4cc04b8 100644
>>> --- a/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb
>>> +++ b/meta-multimedia/recipes-multimedia/musicbrainz/libmusi
>>> cbrainz_git.bb
>>> @@ -37,3 +37,6 @@ do_configure_prepend() {
>>> EXTRA_OECMAKE = "-DLIB_INSTALL_DIR:PATH=${libdir} \
>>> -DIMPORT_EXECUTABLES=build-native/ImportExecutables.
>>> cmake"
>>> +
>>> +# out-of-tree building doesn't appear to work for this package.
>>> +B = "${S}"
>>> --
>>> 1.7.9.5
>>>
>>> _______________________________________________
>>> Openembedded-devel mailing list
>>> Openembedded-devel@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>>
>>
>
> --
> Mike Looijmans
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-09 4:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-01 17:54 [PATCH] musicbrainz: Build with B=S mike.looijmans
2014-03-05 18:08 ` Martin Jansa
2014-03-05 19:49 ` Mike Looijmans
2014-03-09 4:54 ` Tim Orling
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.