From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: kernel: respect device tree status of cpu nodes
Date: Wed, 05 Mar 2014 12:33:07 -0800 [thread overview]
Message-ID: <53178A03.3090004@codeaurora.org> (raw)
In-Reply-To: <1393240960-31846-1-git-send-email-j@bitron.ch>
+Lorenzo
On 02/24/14 03:22, J?rg Billeter wrote:
> Skip 'disabled' cpu nodes when building the cpu logical map. This avoids
> booting cpus that have been disabled in the device tree.
>
> Signed-off-by: J?rg Billeter <j@bitron.ch>
> Reviewed-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/kernel/devtree.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
> index 739c3df..9aed299 100644
> --- a/arch/arm/kernel/devtree.c
> +++ b/arch/arm/kernel/devtree.c
> @@ -95,6 +95,10 @@ void __init arm_dt_init_cpu_maps(void)
> if (of_node_cmp(cpu->type, "cpu"))
> continue;
>
> + /* Check if CPU is enabled */
> + if (!of_device_is_available(cpu))
> + continue;
> +
> pr_debug(" * %s...\n", cpu->full_name);
> /*
> * A device tree containing CPU nodes with missing "reg"
This doesn't follow the ePAPR spec. According to ePAPR status="disabled"
in a cpu node means "the cpu is in a quiescent state" and one can enable
it by using the "enable-method". At the least, we should document this
in bindings/arm/cpus.txt if we can all agree that we want this
definition of disabled.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: "Jürg Billeter" <j@bitron.ch>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@lists.codethink.co.uk, devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] ARM: kernel: respect device tree status of cpu nodes
Date: Wed, 05 Mar 2014 12:33:07 -0800 [thread overview]
Message-ID: <53178A03.3090004@codeaurora.org> (raw)
In-Reply-To: <1393240960-31846-1-git-send-email-j@bitron.ch>
+Lorenzo
On 02/24/14 03:22, Jürg Billeter wrote:
> Skip 'disabled' cpu nodes when building the cpu logical map. This avoids
> booting cpus that have been disabled in the device tree.
>
> Signed-off-by: Jürg Billeter <j@bitron.ch>
> Reviewed-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> arch/arm/kernel/devtree.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/kernel/devtree.c b/arch/arm/kernel/devtree.c
> index 739c3df..9aed299 100644
> --- a/arch/arm/kernel/devtree.c
> +++ b/arch/arm/kernel/devtree.c
> @@ -95,6 +95,10 @@ void __init arm_dt_init_cpu_maps(void)
> if (of_node_cmp(cpu->type, "cpu"))
> continue;
>
> + /* Check if CPU is enabled */
> + if (!of_device_is_available(cpu))
> + continue;
> +
> pr_debug(" * %s...\n", cpu->full_name);
> /*
> * A device tree containing CPU nodes with missing "reg"
This doesn't follow the ePAPR spec. According to ePAPR status="disabled"
in a cpu node means "the cpu is in a quiescent state" and one can enable
it by using the "enable-method". At the least, we should document this
in bindings/arm/cpus.txt if we can all agree that we want this
definition of disabled.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-03-05 20:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 11:22 [PATCH] ARM: kernel: respect device tree status of cpu nodes Jürg Billeter
2014-02-24 11:22 ` Jürg Billeter
2014-02-24 11:22 ` Jürg Billeter
2014-03-05 20:33 ` Stephen Boyd [this message]
2014-03-05 20:33 ` Stephen Boyd
[not found] ` <53178A03.3090004-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-03-06 10:00 ` [Linux-kernel] " Ben Dooks
2014-03-06 10:00 ` Ben Dooks
[not found] ` <5318472A.5060700-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-03-06 16:51 ` Lorenzo Pieralisi
2014-03-06 16:51 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53178A03.3090004@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.