From: Suravee Suthikulanit <suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
To: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
jay.cornwall-5C7GfCeVMHo@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kim.naru-5C7GfCeVMHo@public.gmane.org
Subject: Re: [PATCH] iommu/amd: Fix logics to determine and checking max PASID
Date: Wed, 5 Mar 2014 17:08:41 -0600 [thread overview]
Message-ID: <5317AE79.6090606@amd.com> (raw)
In-Reply-To: <20140305223544.GA2813-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
On 3/5/2014 4:35 PM, Joerg Roedel wrote:
>> - cmd->data[1] = pasid & PASID_MASK;
>> >+ cmd->data[1] = pasid & amd_iommu_max_pasid;
> ... masking out the other bits is redundant.
>
>
> Joerg
Agree. I can take out the masking stuff here, but I think we should be
using the amd_iommu_max_pasid instead of hard coded PASID_MASK for the rest.
Suravee
WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: <iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>, <kim.naru@amd.com>,
<jay.cornwall@amd.com>
Subject: Re: [PATCH] iommu/amd: Fix logics to determine and checking max PASID
Date: Wed, 5 Mar 2014 17:08:41 -0600 [thread overview]
Message-ID: <5317AE79.6090606@amd.com> (raw)
In-Reply-To: <20140305223544.GA2813@8bytes.org>
On 3/5/2014 4:35 PM, Joerg Roedel wrote:
>> - cmd->data[1] = pasid & PASID_MASK;
>> >+ cmd->data[1] = pasid & amd_iommu_max_pasid;
> ... masking out the other bits is redundant.
>
>
> Joerg
Agree. I can take out the masking stuff here, but I think we should be
using the amd_iommu_max_pasid instead of hard coded PASID_MASK for the rest.
Suravee
next prev parent reply other threads:[~2014-03-05 23:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 19:01 [PATCH] iommu/amd: Fix logics to determine and checking max PASID suravee.suthikulpanit-5C7GfCeVMHo
2014-03-05 19:01 ` suravee.suthikulpanit
[not found] ` <1394046068-3858-1-git-send-email-suravee.suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2014-03-05 22:35 ` Joerg Roedel
2014-03-05 22:35 ` Joerg Roedel
[not found] ` <20140305223544.GA2813-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2014-03-05 22:46 ` Suravee Suthikulanit
2014-03-05 22:46 ` Suravee Suthikulanit
2014-03-05 23:08 ` Suravee Suthikulanit [this message]
2014-03-05 23:08 ` Suravee Suthikulanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5317AE79.6090606@amd.com \
--to=suravee.suthikulpanit-5c7gfcevmho@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=jay.cornwall-5C7GfCeVMHo@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=kim.naru-5C7GfCeVMHo@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.