From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974
Date: Thu, 06 Mar 2014 05:53:43 +0000 [thread overview]
Message-ID: <53180D67.3080205@roeck-us.net> (raw)
In-Reply-To: <1394083580-26077-1-git-send-email-linux@roeck-us.net>
On 03/05/2014 09:37 PM, Robert Coulson wrote:
> Thank you Guenter.
>
> Reviewed-by: Robert Coulson <rob.coulson@gmail.com <mailto:rob.coulson@gmail.com>>
>
Thanks ... but don't top-post, please :-)
Guenter
>
> On Wed, Mar 5, 2014 at 9:26 PM, Guenter Roeck <linux@roeck-us.net <mailto:linux@roeck-us.net>> wrote:
>
> LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net <mailto:linux@roeck-us.net>>
> ---
> v2: Mark old revision ID as _REV1.
>
> drivers/hwmon/pmbus/ltc2978.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c
> index de3c152..629bfe0 100644
> --- a/drivers/hwmon/pmbus/ltc2978.c
> +++ b/drivers/hwmon/pmbus/ltc2978.c
> @@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883 };
> /* LTC3883 only */
> #define LTC3883_MFR_IIN_PEAK 0xe1
>
> -#define LTC2974_ID 0x0212
> +#define LTC2974_ID_REV1 0x0212
> +#define LTC2974_ID_REV2 0x0213
> #define LTC2977_ID 0x0130
> #define LTC2978_ID_REV1 0x0121
> #define LTC2978_ID_REV2 0x0122
> @@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
> if (chip_id < 0)
> return chip_id;
>
> - if (chip_id = LTC2974_ID) {
> + if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2) {
> data->id = ltc2974;
> } else if (chip_id = LTC2977_ID) {
> data->id = ltc2977;
> --
> 1.7.9.7
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org <mailto:lm-sensors@lm-sensors.org>
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2014-03-06 5:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 5:26 [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974 Guenter Roeck
2014-03-06 5:37 ` Robert Coulson
2014-03-06 5:53 ` Guenter Roeck [this message]
2014-03-07 15:46 ` Robert Coulson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53180D67.3080205@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.