* [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974
@ 2014-03-06 5:26 Guenter Roeck
2014-03-06 5:37 ` Robert Coulson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-03-06 5:26 UTC (permalink / raw)
To: lm-sensors
LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
v2: Mark old revision ID as _REV1.
drivers/hwmon/pmbus/ltc2978.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c
index de3c152..629bfe0 100644
--- a/drivers/hwmon/pmbus/ltc2978.c
+++ b/drivers/hwmon/pmbus/ltc2978.c
@@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883 };
/* LTC3883 only */
#define LTC3883_MFR_IIN_PEAK 0xe1
-#define LTC2974_ID 0x0212
+#define LTC2974_ID_REV1 0x0212
+#define LTC2974_ID_REV2 0x0213
#define LTC2977_ID 0x0130
#define LTC2978_ID_REV1 0x0121
#define LTC2978_ID_REV2 0x0122
@@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
if (chip_id < 0)
return chip_id;
- if (chip_id = LTC2974_ID) {
+ if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2) {
data->id = ltc2974;
} else if (chip_id = LTC2977_ID) {
data->id = ltc2977;
--
1.7.9.7
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974
2014-03-06 5:26 [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974 Guenter Roeck
@ 2014-03-06 5:37 ` Robert Coulson
2014-03-06 5:53 ` Guenter Roeck
2014-03-07 15:46 ` Robert Coulson
2 siblings, 0 replies; 4+ messages in thread
From: Robert Coulson @ 2014-03-06 5:37 UTC (permalink / raw)
To: lm-sensors
Thank you Guenter.
Reviewed-by: Robert Coulson <rob.coulson@gmail.com>
On Wed, Mar 5, 2014 at 9:26 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> v2: Mark old revision ID as _REV1.
>
> drivers/hwmon/pmbus/ltc2978.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c
> index de3c152..629bfe0 100644
> --- a/drivers/hwmon/pmbus/ltc2978.c
> +++ b/drivers/hwmon/pmbus/ltc2978.c
> @@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883
> };
> /* LTC3883 only */
> #define LTC3883_MFR_IIN_PEAK 0xe1
>
> -#define LTC2974_ID 0x0212
> +#define LTC2974_ID_REV1 0x0212
> +#define LTC2974_ID_REV2 0x0213
> #define LTC2977_ID 0x0130
> #define LTC2978_ID_REV1 0x0121
> #define LTC2978_ID_REV2 0x0122
> @@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
> if (chip_id < 0)
> return chip_id;
>
> - if (chip_id = LTC2974_ID) {
> + if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2) {
> data->id = ltc2974;
> } else if (chip_id = LTC2977_ID) {
> data->id = ltc2977;
> --
> 1.7.9.7
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974
2014-03-06 5:26 [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974 Guenter Roeck
2014-03-06 5:37 ` Robert Coulson
@ 2014-03-06 5:53 ` Guenter Roeck
2014-03-07 15:46 ` Robert Coulson
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2014-03-06 5:53 UTC (permalink / raw)
To: lm-sensors
On 03/05/2014 09:37 PM, Robert Coulson wrote:
> Thank you Guenter.
>
> Reviewed-by: Robert Coulson <rob.coulson@gmail.com <mailto:rob.coulson@gmail.com>>
>
Thanks ... but don't top-post, please :-)
Guenter
>
> On Wed, Mar 5, 2014 at 9:26 PM, Guenter Roeck <linux@roeck-us.net <mailto:linux@roeck-us.net>> wrote:
>
> LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net <mailto:linux@roeck-us.net>>
> ---
> v2: Mark old revision ID as _REV1.
>
> drivers/hwmon/pmbus/ltc2978.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/ltc2978.c b/drivers/hwmon/pmbus/ltc2978.c
> index de3c152..629bfe0 100644
> --- a/drivers/hwmon/pmbus/ltc2978.c
> +++ b/drivers/hwmon/pmbus/ltc2978.c
> @@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880, ltc3883 };
> /* LTC3883 only */
> #define LTC3883_MFR_IIN_PEAK 0xe1
>
> -#define LTC2974_ID 0x0212
> +#define LTC2974_ID_REV1 0x0212
> +#define LTC2974_ID_REV2 0x0213
> #define LTC2977_ID 0x0130
> #define LTC2978_ID_REV1 0x0121
> #define LTC2978_ID_REV2 0x0122
> @@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client *client,
> if (chip_id < 0)
> return chip_id;
>
> - if (chip_id = LTC2974_ID) {
> + if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2) {
> data->id = ltc2974;
> } else if (chip_id = LTC2977_ID) {
> data->id = ltc2977;
> --
> 1.7.9.7
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org <mailto:lm-sensors@lm-sensors.org>
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974
2014-03-06 5:26 [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974 Guenter Roeck
2014-03-06 5:37 ` Robert Coulson
2014-03-06 5:53 ` Guenter Roeck
@ 2014-03-07 15:46 ` Robert Coulson
2 siblings, 0 replies; 4+ messages in thread
From: Robert Coulson @ 2014-03-07 15:46 UTC (permalink / raw)
To: lm-sensors
On Wed, Mar 5, 2014 at 9:53 PM, Guenter Roeck <linux@roeck-us.net> wrote:
> On 03/05/2014 09:37 PM, Robert Coulson wrote:
>
>> Thank you Guenter.
>>
>> Reviewed-by: Robert Coulson <rob.coulson@gmail.com <mailto:
>> rob.coulson@gmail.com>>
>>
>> Thanks ... but don't top-post, please :-)
>
> Guenter
>
Your welcome .. your right and I'll remember next time. (-:
*** Rob.
>
>
>> On Wed, Mar 5, 2014 at 9:26 PM, Guenter Roeck <linux@roeck-us.net<mailto:
>> linux@roeck-us.net>> wrote:
>>
>> LTC2974 datasheet revision C lists the chip ID for LTC2974 as 0x0213.
>>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net <mailto:
>> linux@roeck-us.net>>
>>
>> ---
>> v2: Mark old revision ID as _REV1.
>>
>> drivers/hwmon/pmbus/ltc2978.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/hwmon/pmbus/ltc2978.c
>> b/drivers/hwmon/pmbus/ltc2978.c
>> index de3c152..629bfe0 100644
>> --- a/drivers/hwmon/pmbus/ltc2978.c
>> +++ b/drivers/hwmon/pmbus/ltc2978.c
>> @@ -53,7 +53,8 @@ enum chips { ltc2974, ltc2977, ltc2978, ltc3880,
>> ltc3883 };
>> /* LTC3883 only */
>> #define LTC3883_MFR_IIN_PEAK 0xe1
>>
>> -#define LTC2974_ID 0x0212
>> +#define LTC2974_ID_REV1 0x0212
>> +#define LTC2974_ID_REV2 0x0213
>> #define LTC2977_ID 0x0130
>> #define LTC2978_ID_REV1 0x0121
>> #define LTC2978_ID_REV2 0x0122
>> @@ -394,7 +395,7 @@ static int ltc2978_probe(struct i2c_client
>> *client,
>> if (chip_id < 0)
>> return chip_id;
>>
>> - if (chip_id = LTC2974_ID) {
>> + if (chip_id = LTC2974_ID_REV1 || chip_id = LTC2974_ID_REV2)
>> {
>> data->id = ltc2974;
>> } else if (chip_id = LTC2977_ID) {
>> data->id = ltc2977;
>> --
>> 1.7.9.7
>>
>>
>> _______________________________________________
>> lm-sensors mailing list
>> lm-sensors@lm-sensors.org <mailto:lm-sensors@lm-sensors.org>
>> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>>
>>
>>
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-07 15:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 5:26 [lm-sensors] [PATCH v2] hwmon: (pmbus/ltc2978) Add new chip ID for LTC2974 Guenter Roeck
2014-03-06 5:37 ` Robert Coulson
2014-03-06 5:53 ` Guenter Roeck
2014-03-07 15:46 ` Robert Coulson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.