[PATCH 0/5] Add USB nodes for am43xx epos and gp evm

[PATCH 0/5] Add USB nodes for am43xx epos and gp evm

[George Cherian]

The patch series adds USB dt nodes for am43xx epos and gp evm

Boot tested with  Benoit's for_3.15 + following patches

https://patchwork.kernel.org/patch/3600821/
https://patchwork.kernel.org/patch/3600831/
https://patchwork.kernel.org/patch/3600851/
https://patchwork.kernel.org/patch/3600841/



George Cherian (5):
  ARM: dts: am43xx clock data
  ARM: dts: AM4372: Add USB nodes
  ARM: dts: am437x-gp-evm: Enable USB
  ARM: dts: am43x-epos-evm: Enable USB
  doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

 Documentation/devicetree/bindings/usb/omap-usb.txt |  4 +-
 arch/arm/boot/dts/am4372.dtsi                      | 99 ++++++++++++++++++++++
 arch/arm/boot/dts/am437x-gp-evm.dts                | 44 ++++++++++
 arch/arm/boot/dts/am43x-epos-evm.dts               | 44 ++++++++++
 arch/arm/boot/dts/am43xx-clocks.dtsi               | 17 ++++
 5 files changed, 207 insertions(+), 1 deletion(-)

-- 
1.8.3.1

[PATCH 0/5] Add USB nodes for am43xx epos and gp evm

[George Cherian]

The patch series adds USB dt nodes for am43xx epos and gp evm

Boot tested with  Benoit's for_3.15 + following patches

https://patchwork.kernel.org/patch/3600821/
https://patchwork.kernel.org/patch/3600831/
https://patchwork.kernel.org/patch/3600851/
https://patchwork.kernel.org/patch/3600841/



George Cherian (5):
  ARM: dts: am43xx clock data
  ARM: dts: AM4372: Add USB nodes
  ARM: dts: am437x-gp-evm: Enable USB
  ARM: dts: am43x-epos-evm: Enable USB
  doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

 Documentation/devicetree/bindings/usb/omap-usb.txt |  4 +-
 arch/arm/boot/dts/am4372.dtsi                      | 99 ++++++++++++++++++++++
 arch/arm/boot/dts/am437x-gp-evm.dts                | 44 ++++++++++
 arch/arm/boot/dts/am43x-epos-evm.dts               | 44 ++++++++++
 arch/arm/boot/dts/am43xx-clocks.dtsi               | 17 ++++
 5 files changed, 207 insertions(+), 1 deletion(-)

-- 
1.8.3.1

[PATCH 1/5] ARM: dts: am43xx clock data

[George Cherian]

Add USB reference clock data

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am43xx-clocks.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi
index 142009c..506d036 100644
--- a/arch/arm/boot/dts/am43xx-clocks.dtsi
+++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
@@ -653,4 +653,21 @@
 		clocks = <&clk_32768_ck>, <&clk_32k_tpm_ck>;
 		reg = <0x4260>;
 	};
+
+	usb_otg_ss0_refclk960m: usb_otg_ss0_refclk960m {
+		#clock-cells = <0>;
+	        compatible = "ti,gate-clock";
+		clocks = <&dpll_per_clkdcoldo>;
+	        ti,bit-shift = <8>;
+	        reg = <0x8a60>;
+	};
+
+	usb_otg_ss1_refclk960m: usb_otg_ss1_refclk960m {
+		#clock-cells = <0>;
+	        compatible = "ti,gate-clock";
+		clocks = <&dpll_per_clkdcoldo>;
+	        ti,bit-shift = <8>;
+		reg = <0x8a68>;
+	};
+
 };
-- 
1.8.3.1

[PATCH 1/5] ARM: dts: am43xx clock data

[George Cherian]

Add USB reference clock data

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am43xx-clocks.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/arch/arm/boot/dts/am43xx-clocks.dtsi b/arch/arm/boot/dts/am43xx-clocks.dtsi
index 142009c..506d036 100644
--- a/arch/arm/boot/dts/am43xx-clocks.dtsi
+++ b/arch/arm/boot/dts/am43xx-clocks.dtsi
@@ -653,4 +653,21 @@
 		clocks = <&clk_32768_ck>, <&clk_32k_tpm_ck>;
 		reg = <0x4260>;
 	};
+
+	usb_otg_ss0_refclk960m: usb_otg_ss0_refclk960m {
+		#clock-cells = <0>;
+	        compatible = "ti,gate-clock";
+		clocks = <&dpll_per_clkdcoldo>;
+	        ti,bit-shift = <8>;
+	        reg = <0x8a60>;
+	};
+
+	usb_otg_ss1_refclk960m: usb_otg_ss1_refclk960m {
+		#clock-cells = <0>;
+	        compatible = "ti,gate-clock";
+		clocks = <&dpll_per_clkdcoldo>;
+	        ti,bit-shift = <8>;
+		reg = <0x8a68>;
+	};
+
 };
-- 
1.8.3.1

[PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[George Cherian]

Add nodes for 2 instances each of
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB

for AM43xx.

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 5a7cc38..90408b3 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -698,6 +698,105 @@
 			       <&edma 11>;
 			dma-names = "tx", "rx";
 		};
+
+		am43xx_control_usb2phy1: control-phy@44e10620 {
+			compatible = "ti,control-phy-am437usb2";
+			reg = <0x44e10620 0x4>;
+			reg-names = "power";
+			status = "disabled";
+		};
+
+		am43xx_control_usb2phy2: control-phy@0x44e10628 {
+			compatible = "ti,control-phy-am437usb2";
+			reg = <0x44e10628 0x4>;
+			reg-names = "power";
+			status = "disabled";
+		};
+
+		ocp2scp0: ocp2scp@483a8000 {
+			compatible = "ti,omap-ocp2scp";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			ti,hwmods = "ocp2scp0";
+			status = "disabled";
+
+			usb2_phy1: usb2phy1@483a8000 {
+				compatible = "ti,am437x-usb2";
+				reg = <0x483a8000 0x8000>;
+				ctrl-module = <&am43xx_control_usb2phy1>;
+				clocks = <&clk_32768_ck>,
+					 <&usb_otg_ss0_refclk960m>;
+				clock-names = "usb_phy_cm_clk32k",
+					      "usb_otg_ss_refclk960m";
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+		};
+
+		ocp2scp1: ocp2scp@483e8000 {
+			compatible = "ti,omap-ocp2scp";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			ti,hwmods = "ocp2scp1";
+			status = "disabled";
+
+			usb2_phy2: usb2phy2@483e8000 {
+				compatible = "ti,am437x-usb2";
+				reg = <0x483e8000 0x8000>;
+				ctrl-module = <&am43xx_control_usb2phy2>;
+				clocks = <&clk_32768_ck>,
+					 <&usb_otg_ss1_refclk960m>;
+				clock-names = "usb_phy_cm_clk32k",
+					      "usb_otg_ss_refclk960m";
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+		};
+
+		dwc3_1: omap_dwc3_1@48380000 {
+			compatible = "ti,am437x-dwc3";
+			ti,hwmods = "usb_otg_ss0";
+			reg = <0x48380000 0x10000>;
+			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <1>;
+			ranges;
+			status = "disabled";
+
+			usb1: usb@48390000 {
+				compatible = "synopsys,dwc3";
+				reg = <0x48390000 0x17000>;
+				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
+				usb-phy = <&usb2_phy1>;
+				phy-names = "usb2-phy";
+				status = "disabled";
+			};
+		};
+
+		dwc3_2: omap_dwc3_2@483c0000 {
+			compatible = "ti,am437x-dwc3";
+			ti,hwmods = "usb_otg_ss1";
+			reg = <0x483c0000 0x10000>;
+			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <1>;
+			ranges;
+			status = "disabled";
+
+			usb2: usb@483d0000 {
+				compatible = "synopsys,dwc3";
+				reg = <0x483d0000 0x17000>;
+				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+				usb-phy = <&usb2_phy2>;
+				phy-names = "usb2-phy";
+				status = "disabled";
+			};
+		};
+
 	};
 };
 
-- 
1.8.3.1

[PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[George Cherian]

Add nodes for 2 instances each of
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB

for AM43xx.

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index 5a7cc38..90408b3 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -698,6 +698,105 @@
 			       <&edma 11>;
 			dma-names = "tx", "rx";
 		};
+
+		am43xx_control_usb2phy1: control-phy@44e10620 {
+			compatible = "ti,control-phy-am437usb2";
+			reg = <0x44e10620 0x4>;
+			reg-names = "power";
+			status = "disabled";
+		};
+
+		am43xx_control_usb2phy2: control-phy@0x44e10628 {
+			compatible = "ti,control-phy-am437usb2";
+			reg = <0x44e10628 0x4>;
+			reg-names = "power";
+			status = "disabled";
+		};
+
+		ocp2scp0: ocp2scp@483a8000 {
+			compatible = "ti,omap-ocp2scp";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			ti,hwmods = "ocp2scp0";
+			status = "disabled";
+
+			usb2_phy1: usb2phy1@483a8000 {
+				compatible = "ti,am437x-usb2";
+				reg = <0x483a8000 0x8000>;
+				ctrl-module = <&am43xx_control_usb2phy1>;
+				clocks = <&clk_32768_ck>,
+					 <&usb_otg_ss0_refclk960m>;
+				clock-names = "usb_phy_cm_clk32k",
+					      "usb_otg_ss_refclk960m";
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+		};
+
+		ocp2scp1: ocp2scp@483e8000 {
+			compatible = "ti,omap-ocp2scp";
+			#address-cells = <1>;
+			#size-cells = <1>;
+			ranges;
+			ti,hwmods = "ocp2scp1";
+			status = "disabled";
+
+			usb2_phy2: usb2phy2@483e8000 {
+				compatible = "ti,am437x-usb2";
+				reg = <0x483e8000 0x8000>;
+				ctrl-module = <&am43xx_control_usb2phy2>;
+				clocks = <&clk_32768_ck>,
+					 <&usb_otg_ss1_refclk960m>;
+				clock-names = "usb_phy_cm_clk32k",
+					      "usb_otg_ss_refclk960m";
+				#phy-cells = <0>;
+				status = "disabled";
+			};
+		};
+
+		dwc3_1: omap_dwc3_1@48380000 {
+			compatible = "ti,am437x-dwc3";
+			ti,hwmods = "usb_otg_ss0";
+			reg = <0x48380000 0x10000>;
+			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <1>;
+			ranges;
+			status = "disabled";
+
+			usb1: usb@48390000 {
+				compatible = "synopsys,dwc3";
+				reg = <0x48390000 0x17000>;
+				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
+				usb-phy = <&usb2_phy1>;
+				phy-names = "usb2-phy";
+				status = "disabled";
+			};
+		};
+
+		dwc3_2: omap_dwc3_2@483c0000 {
+			compatible = "ti,am437x-dwc3";
+			ti,hwmods = "usb_otg_ss1";
+			reg = <0x483c0000 0x10000>;
+			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <1>;
+			utmi-mode = <1>;
+			ranges;
+			status = "disabled";
+
+			usb2: usb@483d0000 {
+				compatible = "synopsys,dwc3";
+				reg = <0x483d0000 0x17000>;
+				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
+				usb-phy = <&usb2_phy2>;
+				phy-names = "usb2-phy";
+				status = "disabled";
+			};
+		};
+
 	};
 };
 
-- 
1.8.3.1

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[Roger Quadros]

Hi George,

On 03/03/2014 03:53 PM, George Cherian wrote:
> Add nodes for 2 instances each of
> 	- ocp2scp
> 	- USB PHY control module
> 	- USB PHY
> 	- dwc3_omap
> 	- USB
> 
> for AM43xx.
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
>  arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 99 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index 5a7cc38..90408b3 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -698,6 +698,105 @@
>  			       <&edma 11>;
>  			dma-names = "tx", "rx";
>  		};
> +
> +		am43xx_control_usb2phy1: control-phy@44e10620 {
> +			compatible = "ti,control-phy-am437usb2";

Since this is the first usage of this compatible ID, we still have room to
change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"

Please see
http://article.gmane.org/gmane.linux.drivers.devicetree/64833

> +			reg = <0x44e10620 0x4>;
> +			reg-names = "power";
> +			status = "disabled";

Why disable something that is within the SoC and does not affect board configurations? 

Question applies for all the nodes in this patch except the ones that come out on the
SoC pins. e.g. PHY.

> +		};
> +
> +		am43xx_control_usb2phy2: control-phy@0x44e10628 {
> +			compatible = "ti,control-phy-am437usb2";
> +			reg = <0x44e10628 0x4>;
> +			reg-names = "power";
> +			status = "disabled";
> +		};
> +
> +		ocp2scp0: ocp2scp@483a8000 {
> +			compatible = "ti,omap-ocp2scp";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			ti,hwmods = "ocp2scp0";
> +			status = "disabled";
> +
> +			usb2_phy1: usb2phy1@483a8000 {

should be
			usb2_phy1: phy@483a8000 {

> +				compatible = "ti,am437x-usb2";
> +				reg = <0x483a8000 0x8000>;
> +				ctrl-module = <&am43xx_control_usb2phy1>;
> +				clocks = <&clk_32768_ck>,
> +					 <&usb_otg_ss0_refclk960m>;
> +				clock-names = "usb_phy_cm_clk32k",
> +					      "usb_otg_ss_refclk960m";

clock-names should be platform independent. Better option would be to
modify the usb2 driver to use names like "wkupclk" and "refclk"

> +				#phy-cells = <0>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		ocp2scp1: ocp2scp@483e8000 {
> +			compatible = "ti,omap-ocp2scp";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			ti,hwmods = "ocp2scp1";
> +			status = "disabled";
> +
> +			usb2_phy2: usb2phy2@483e8000 {
> +				compatible = "ti,am437x-usb2";
> +				reg = <0x483e8000 0x8000>;
> +				ctrl-module = <&am43xx_control_usb2phy2>;
> +				clocks = <&clk_32768_ck>,
> +					 <&usb_otg_ss1_refclk960m>;
> +				clock-names = "usb_phy_cm_clk32k",
> +					      "usb_otg_ss_refclk960m";
> +				#phy-cells = <0>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		dwc3_1: omap_dwc3_1@48380000 {
> +			compatible = "ti,am437x-dwc3";
> +			ti,hwmods = "usb_otg_ss0";
> +			reg = <0x48380000 0x10000>;
> +			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			utmi-mode = <1>;
> +			ranges;
> +			status = "disabled";
> +
> +			usb1: usb@48390000 {
> +				compatible = "synopsys,dwc3";
> +				reg = <0x48390000 0x17000>;
> +				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> +				usb-phy = <&usb2_phy1>;

shouldn't this be		phys = <&usb2_phy1>;	?

> +				phy-names = "usb2-phy";

what about
	maximum-speed = "high-speed";
and
	dr_mode = "otg"; ?

> +				status = "disabled";
> +			};
> +		};
> +
> +		dwc3_2: omap_dwc3_2@483c0000 {
> +			compatible = "ti,am437x-dwc3";
> +			ti,hwmods = "usb_otg_ss1";
> +			reg = <0x483c0000 0x10000>;
> +			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			utmi-mode = <1>;
> +			ranges;
> +			status = "disabled";
> +
> +			usb2: usb@483d0000 {
> +				compatible = "synopsys,dwc3";
> +				reg = <0x483d0000 0x17000>;
> +				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> +				usb-phy = <&usb2_phy2>;
> +				phy-names = "usb2-phy";
> +				status = "disabled";
> +			};
> +		};
> +
>  	};
>  };
>  
> 

cheers,
-roger

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[Roger Quadros]

Hi George,

On 03/03/2014 03:53 PM, George Cherian wrote:
> Add nodes for 2 instances each of
> 	- ocp2scp
> 	- USB PHY control module
> 	- USB PHY
> 	- dwc3_omap
> 	- USB
> 
> for AM43xx.
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
>  arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 99 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index 5a7cc38..90408b3 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -698,6 +698,105 @@
>  			       <&edma 11>;
>  			dma-names = "tx", "rx";
>  		};
> +
> +		am43xx_control_usb2phy1: control-phy@44e10620 {
> +			compatible = "ti,control-phy-am437usb2";

Since this is the first usage of this compatible ID, we still have room to
change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"

Please see
http://article.gmane.org/gmane.linux.drivers.devicetree/64833

> +			reg = <0x44e10620 0x4>;
> +			reg-names = "power";
> +			status = "disabled";

Why disable something that is within the SoC and does not affect board configurations? 

Question applies for all the nodes in this patch except the ones that come out on the
SoC pins. e.g. PHY.

> +		};
> +
> +		am43xx_control_usb2phy2: control-phy@0x44e10628 {
> +			compatible = "ti,control-phy-am437usb2";
> +			reg = <0x44e10628 0x4>;
> +			reg-names = "power";
> +			status = "disabled";
> +		};
> +
> +		ocp2scp0: ocp2scp@483a8000 {
> +			compatible = "ti,omap-ocp2scp";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			ti,hwmods = "ocp2scp0";
> +			status = "disabled";
> +
> +			usb2_phy1: usb2phy1@483a8000 {

should be
			usb2_phy1: phy@483a8000 {

> +				compatible = "ti,am437x-usb2";
> +				reg = <0x483a8000 0x8000>;
> +				ctrl-module = <&am43xx_control_usb2phy1>;
> +				clocks = <&clk_32768_ck>,
> +					 <&usb_otg_ss0_refclk960m>;
> +				clock-names = "usb_phy_cm_clk32k",
> +					      "usb_otg_ss_refclk960m";

clock-names should be platform independent. Better option would be to
modify the usb2 driver to use names like "wkupclk" and "refclk"

> +				#phy-cells = <0>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		ocp2scp1: ocp2scp@483e8000 {
> +			compatible = "ti,omap-ocp2scp";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges;
> +			ti,hwmods = "ocp2scp1";
> +			status = "disabled";
> +
> +			usb2_phy2: usb2phy2@483e8000 {
> +				compatible = "ti,am437x-usb2";
> +				reg = <0x483e8000 0x8000>;
> +				ctrl-module = <&am43xx_control_usb2phy2>;
> +				clocks = <&clk_32768_ck>,
> +					 <&usb_otg_ss1_refclk960m>;
> +				clock-names = "usb_phy_cm_clk32k",
> +					      "usb_otg_ss_refclk960m";
> +				#phy-cells = <0>;
> +				status = "disabled";
> +			};
> +		};
> +
> +		dwc3_1: omap_dwc3_1@48380000 {
> +			compatible = "ti,am437x-dwc3";
> +			ti,hwmods = "usb_otg_ss0";
> +			reg = <0x48380000 0x10000>;
> +			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			utmi-mode = <1>;
> +			ranges;
> +			status = "disabled";
> +
> +			usb1: usb@48390000 {
> +				compatible = "synopsys,dwc3";
> +				reg = <0x48390000 0x17000>;
> +				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
> +				usb-phy = <&usb2_phy1>;

shouldn't this be		phys = <&usb2_phy1>;	?

> +				phy-names = "usb2-phy";

what about
	maximum-speed = "high-speed";
and
	dr_mode = "otg"; ?

> +				status = "disabled";
> +			};
> +		};
> +
> +		dwc3_2: omap_dwc3_2@483c0000 {
> +			compatible = "ti,am437x-dwc3";
> +			ti,hwmods = "usb_otg_ss1";
> +			reg = <0x483c0000 0x10000>;
> +			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			utmi-mode = <1>;
> +			ranges;
> +			status = "disabled";
> +
> +			usb2: usb@483d0000 {
> +				compatible = "synopsys,dwc3";
> +				reg = <0x483d0000 0x17000>;
> +				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
> +				usb-phy = <&usb2_phy2>;
> +				phy-names = "usb2-phy";
> +				status = "disabled";
> +			};
> +		};
> +
>  	};
>  };
>  
> 

cheers,
-roger

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[George Cherian]

Hi Roger,

On 3/6/2014 2:19 PM, Roger Quadros wrote:
> Hi George,
>
> On 03/03/2014 03:53 PM, George Cherian wrote:
>> Add nodes for 2 instances each of
>> 	- ocp2scp
>> 	- USB PHY control module
>> 	- USB PHY
>> 	- dwc3_omap
>> 	- USB
>>
>> for AM43xx.
>>
>> Signed-off-by: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 99 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index 5a7cc38..90408b3 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -698,6 +698,105 @@
>>   			       <&edma 11>;
>>   			dma-names = "tx", "rx";
>>   		};
>> +
>> +		am43xx_control_usb2phy1: control-phy@44e10620 {
>> +			compatible = "ti,control-phy-am437usb2";
> Since this is the first usage of this compatible ID, we still have room to
> change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"
>
> Please see
> http://article.gmane.org/gmane.linux.drivers.devicetree/64833

Okay.
>> +			reg = <0x44e10620 0x4>;
>> +			reg-names = "power";
>> +			status = "disabled";
> Why disable something that is within the SoC and does not affect board configurations?
>
> Question applies for all the nodes in this patch except the ones that come out on the
> SoC pins. e.g. PHY.
Okay
>> +		};
>> +
>> +		am43xx_control_usb2phy2: control-phy@0x44e10628 {
>> +			compatible = "ti,control-phy-am437usb2";
>> +			reg = <0x44e10628 0x4>;
>> +			reg-names = "power";
>> +			status = "disabled";
>> +		};
>> +
>> +		ocp2scp0: ocp2scp@483a8000 {
>> +			compatible = "ti,omap-ocp2scp";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			ranges;
>> +			ti,hwmods = "ocp2scp0";
>> +			status = "disabled";
>> +
>> +			usb2_phy1: usb2phy1@483a8000 {
> should be
okay
> 			usb2_phy1: phy@483a8000 {
>
>> +				compatible = "ti,am437x-usb2";
>> +				reg = <0x483a8000 0x8000>;
>> +				ctrl-module = <&am43xx_control_usb2phy1>;
>> +				clocks = <&clk_32768_ck>,
>> +					 <&usb_otg_ss0_refclk960m>;
>> +				clock-names = "usb_phy_cm_clk32k",
>> +					      "usb_otg_ss_refclk960m";
> clock-names should be platform independent. Better option would be to
> modify the usb2 driver to use names like "wkupclk" and "refclk"
The phy driver still does devm_get_clk using above clock names and not 
"wkupclk" and "refclk".

>> +				#phy-cells = <0>;
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>> +		ocp2scp1: ocp2scp@483e8000 {
>> +			compatible = "ti,omap-ocp2scp";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			ranges;
>> +			ti,hwmods = "ocp2scp1";
>> +			status = "disabled";
>> +
>> +			usb2_phy2: usb2phy2@483e8000 {
>> +				compatible = "ti,am437x-usb2";
>> +				reg = <0x483e8000 0x8000>;
>> +				ctrl-module = <&am43xx_control_usb2phy2>;
>> +				clocks = <&clk_32768_ck>,
>> +					 <&usb_otg_ss1_refclk960m>;
>> +				clock-names = "usb_phy_cm_clk32k",
>> +					      "usb_otg_ss_refclk960m";
>> +				#phy-cells = <0>;
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>> +		dwc3_1: omap_dwc3_1@48380000 {
>> +			compatible = "ti,am437x-dwc3";
>> +			ti,hwmods = "usb_otg_ss0";
>> +			reg = <0x48380000 0x10000>;
>> +			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			utmi-mode = <1>;
>> +			ranges;
>> +			status = "disabled";
>> +
>> +			usb1: usb@48390000 {
>> +				compatible = "synopsys,dwc3";
>> +				reg = <0x48390000 0x17000>;
>> +				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>> +				usb-phy = <&usb2_phy1>;
> shouldn't this be		phys = <&usb2_phy1>;	?

At the time of writing this patch phys property is still not in.
Also generic-phy conversion for dwc3 was recently posted by kishon.
>> +				phy-names = "usb2-phy";
> what about
> 	maximum-speed = "high-speed";
> and
> 	dr_mode = "otg"; ?

Done from board file. Actually maximum-speed I can set here.
dr_mode is a board property.
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>> +		dwc3_2: omap_dwc3_2@483c0000 {
>> +			compatible = "ti,am437x-dwc3";
>> +			ti,hwmods = "usb_otg_ss1";
>> +			reg = <0x483c0000 0x10000>;
>> +			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			utmi-mode = <1>;
>> +			ranges;
>> +			status = "disabled";
>> +
>> +			usb2: usb@483d0000 {
>> +				compatible = "synopsys,dwc3";
>> +				reg = <0x483d0000 0x17000>;
>> +				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>> +				usb-phy = <&usb2_phy2>;
>> +				phy-names = "usb2-phy";
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>>   	};
>>   };
>>   
>>
> cheers,
> -roger


-- 
-George

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[George Cherian]

Hi Roger,

On 3/6/2014 2:19 PM, Roger Quadros wrote:
> Hi George,
>
> On 03/03/2014 03:53 PM, George Cherian wrote:
>> Add nodes for 2 instances each of
>> 	- ocp2scp
>> 	- USB PHY control module
>> 	- USB PHY
>> 	- dwc3_omap
>> 	- USB
>>
>> for AM43xx.
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>>   arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 99 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index 5a7cc38..90408b3 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -698,6 +698,105 @@
>>   			       <&edma 11>;
>>   			dma-names = "tx", "rx";
>>   		};
>> +
>> +		am43xx_control_usb2phy1: control-phy@44e10620 {
>> +			compatible = "ti,control-phy-am437usb2";
> Since this is the first usage of this compatible ID, we still have room to
> change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"
>
> Please see
> http://article.gmane.org/gmane.linux.drivers.devicetree/64833

Okay.
>> +			reg = <0x44e10620 0x4>;
>> +			reg-names = "power";
>> +			status = "disabled";
> Why disable something that is within the SoC and does not affect board configurations?
>
> Question applies for all the nodes in this patch except the ones that come out on the
> SoC pins. e.g. PHY.
Okay
>> +		};
>> +
>> +		am43xx_control_usb2phy2: control-phy@0x44e10628 {
>> +			compatible = "ti,control-phy-am437usb2";
>> +			reg = <0x44e10628 0x4>;
>> +			reg-names = "power";
>> +			status = "disabled";
>> +		};
>> +
>> +		ocp2scp0: ocp2scp@483a8000 {
>> +			compatible = "ti,omap-ocp2scp";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			ranges;
>> +			ti,hwmods = "ocp2scp0";
>> +			status = "disabled";
>> +
>> +			usb2_phy1: usb2phy1@483a8000 {
> should be
okay
> 			usb2_phy1: phy@483a8000 {
>
>> +				compatible = "ti,am437x-usb2";
>> +				reg = <0x483a8000 0x8000>;
>> +				ctrl-module = <&am43xx_control_usb2phy1>;
>> +				clocks = <&clk_32768_ck>,
>> +					 <&usb_otg_ss0_refclk960m>;
>> +				clock-names = "usb_phy_cm_clk32k",
>> +					      "usb_otg_ss_refclk960m";
> clock-names should be platform independent. Better option would be to
> modify the usb2 driver to use names like "wkupclk" and "refclk"
The phy driver still does devm_get_clk using above clock names and not 
"wkupclk" and "refclk".

>> +				#phy-cells = <0>;
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>> +		ocp2scp1: ocp2scp@483e8000 {
>> +			compatible = "ti,omap-ocp2scp";
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			ranges;
>> +			ti,hwmods = "ocp2scp1";
>> +			status = "disabled";
>> +
>> +			usb2_phy2: usb2phy2@483e8000 {
>> +				compatible = "ti,am437x-usb2";
>> +				reg = <0x483e8000 0x8000>;
>> +				ctrl-module = <&am43xx_control_usb2phy2>;
>> +				clocks = <&clk_32768_ck>,
>> +					 <&usb_otg_ss1_refclk960m>;
>> +				clock-names = "usb_phy_cm_clk32k",
>> +					      "usb_otg_ss_refclk960m";
>> +				#phy-cells = <0>;
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>> +		dwc3_1: omap_dwc3_1@48380000 {
>> +			compatible = "ti,am437x-dwc3";
>> +			ti,hwmods = "usb_otg_ss0";
>> +			reg = <0x48380000 0x10000>;
>> +			interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			utmi-mode = <1>;
>> +			ranges;
>> +			status = "disabled";
>> +
>> +			usb1: usb@48390000 {
>> +				compatible = "synopsys,dwc3";
>> +				reg = <0x48390000 0x17000>;
>> +				interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>> +				usb-phy = <&usb2_phy1>;
> shouldn't this be		phys = <&usb2_phy1>;	?

At the time of writing this patch phys property is still not in.
Also generic-phy conversion for dwc3 was recently posted by kishon.
>> +				phy-names = "usb2-phy";
> what about
> 	maximum-speed = "high-speed";
> and
> 	dr_mode = "otg"; ?

Done from board file. Actually maximum-speed I can set here.
dr_mode is a board property.
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>> +		dwc3_2: omap_dwc3_2@483c0000 {
>> +			compatible = "ti,am437x-dwc3";
>> +			ti,hwmods = "usb_otg_ss1";
>> +			reg = <0x483c0000 0x10000>;
>> +			interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +			utmi-mode = <1>;
>> +			ranges;
>> +			status = "disabled";
>> +
>> +			usb2: usb@483d0000 {
>> +				compatible = "synopsys,dwc3";
>> +				reg = <0x483d0000 0x17000>;
>> +				interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>> +				usb-phy = <&usb2_phy2>;
>> +				phy-names = "usb2-phy";
>> +				status = "disabled";
>> +			};
>> +		};
>> +
>>   	};
>>   };
>>   
>>
> cheers,
> -roger


-- 
-George

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[Roger Quadros]

On 03/06/2014 02:27 PM, George Cherian wrote:
> Hi Roger,
> 
> On 3/6/2014 2:19 PM, Roger Quadros wrote:
>> Hi George,
>>
>> On 03/03/2014 03:53 PM, George Cherian wrote:
>>> Add nodes for 2 instances each of
>>>     - ocp2scp
>>>     - USB PHY control module
>>>     - USB PHY
>>>     - dwc3_omap
>>>     - USB
>>>
>>> for AM43xx.
>>>
>>> Signed-off-by: George Cherian <george.cherian@ti.com>
>>> ---
>>>   arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 99 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>>> index 5a7cc38..90408b3 100644
>>> --- a/arch/arm/boot/dts/am4372.dtsi
>>> +++ b/arch/arm/boot/dts/am4372.dtsi
>>> @@ -698,6 +698,105 @@
>>>                      <&edma 11>;
>>>               dma-names = "tx", "rx";
>>>           };
>>> +
>>> +        am43xx_control_usb2phy1: control-phy@44e10620 {
>>> +            compatible = "ti,control-phy-am437usb2";
>> Since this is the first usage of this compatible ID, we still have room to
>> change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"
>>
>> Please see
>> http://article.gmane.org/gmane.linux.drivers.devicetree/64833
> 
> Okay.
>>> +            reg = <0x44e10620 0x4>;
>>> +            reg-names = "power";
>>> +            status = "disabled";
>> Why disable something that is within the SoC and does not affect board configurations?
>>
>> Question applies for all the nodes in this patch except the ones that come out on the
>> SoC pins. e.g. PHY.
> Okay
>>> +        };
>>> +
>>> +        am43xx_control_usb2phy2: control-phy@0x44e10628 {
>>> +            compatible = "ti,control-phy-am437usb2";
>>> +            reg = <0x44e10628 0x4>;
>>> +            reg-names = "power";
>>> +            status = "disabled";
>>> +        };
>>> +
>>> +        ocp2scp0: ocp2scp@483a8000 {
>>> +            compatible = "ti,omap-ocp2scp";
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            ranges;
>>> +            ti,hwmods = "ocp2scp0";
>>> +            status = "disabled";
>>> +
>>> +            usb2_phy1: usb2phy1@483a8000 {
>> should be
> okay
>>             usb2_phy1: phy@483a8000 {
>>
>>> +                compatible = "ti,am437x-usb2";
>>> +                reg = <0x483a8000 0x8000>;
>>> +                ctrl-module = <&am43xx_control_usb2phy1>;
>>> +                clocks = <&clk_32768_ck>,
>>> +                     <&usb_otg_ss0_refclk960m>;
>>> +                clock-names = "usb_phy_cm_clk32k",
>>> +                          "usb_otg_ss_refclk960m";
>> clock-names should be platform independent. Better option would be to
>> modify the usb2 driver to use names like "wkupclk" and "refclk"
> The phy driver still does devm_get_clk using above clock names and not "wkupclk" and "refclk".
> 

I'll post a patch soon that takes care of both clock names and the compatible ids in
the phy-omap-usb2.c driver.

>>> +                #phy-cells = <0>;
>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>> +        ocp2scp1: ocp2scp@483e8000 {
>>> +            compatible = "ti,omap-ocp2scp";
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            ranges;
>>> +            ti,hwmods = "ocp2scp1";
>>> +            status = "disabled";
>>> +
>>> +            usb2_phy2: usb2phy2@483e8000 {
>>> +                compatible = "ti,am437x-usb2";
>>> +                reg = <0x483e8000 0x8000>;
>>> +                ctrl-module = <&am43xx_control_usb2phy2>;
>>> +                clocks = <&clk_32768_ck>,
>>> +                     <&usb_otg_ss1_refclk960m>;
>>> +                clock-names = "usb_phy_cm_clk32k",
>>> +                          "usb_otg_ss_refclk960m";
>>> +                #phy-cells = <0>;
>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>> +        dwc3_1: omap_dwc3_1@48380000 {
>>> +            compatible = "ti,am437x-dwc3";
>>> +            ti,hwmods = "usb_otg_ss0";
>>> +            reg = <0x48380000 0x10000>;
>>> +            interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            utmi-mode = <1>;
>>> +            ranges;
>>> +            status = "disabled";
>>> +
>>> +            usb1: usb@48390000 {
>>> +                compatible = "synopsys,dwc3";
>>> +                reg = <0x48390000 0x17000>;
>>> +                interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>>> +                usb-phy = <&usb2_phy1>;
>> shouldn't this be        phys = <&usb2_phy1>;    ?
> 
> At the time of writing this patch phys property is still not in.
> Also generic-phy conversion for dwc3 was recently posted by kishon.
>>> +                phy-names = "usb2-phy";
>> what about
>>     maximum-speed = "high-speed";
>> and
>>     dr_mode = "otg"; ?
> 
> Done from board file. Actually maximum-speed I can set here.
> dr_mode is a board property.

Is it a known standard that dr_mode must come from board dts?

I think dr_mode can be set here by default. Board can always override if it
needs non otg operation.

cheers,
-roger

>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>> +        dwc3_2: omap_dwc3_2@483c0000 {
>>> +            compatible = "ti,am437x-dwc3";
>>> +            ti,hwmods = "usb_otg_ss1";
>>> +            reg = <0x483c0000 0x10000>;
>>> +            interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            utmi-mode = <1>;
>>> +            ranges;
>>> +            status = "disabled";
>>> +
>>> +            usb2: usb@483d0000 {
>>> +                compatible = "synopsys,dwc3";
>>> +                reg = <0x483d0000 0x17000>;
>>> +                interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>>> +                usb-phy = <&usb2_phy2>;
>>> +                phy-names = "usb2-phy";
>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>>       };
>>>   };
>>>  
>> cheers,
>> -roger
> 
> 

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[Roger Quadros]

On 03/06/2014 02:27 PM, George Cherian wrote:
> Hi Roger,
> 
> On 3/6/2014 2:19 PM, Roger Quadros wrote:
>> Hi George,
>>
>> On 03/03/2014 03:53 PM, George Cherian wrote:
>>> Add nodes for 2 instances each of
>>>     - ocp2scp
>>>     - USB PHY control module
>>>     - USB PHY
>>>     - dwc3_omap
>>>     - USB
>>>
>>> for AM43xx.
>>>
>>> Signed-off-by: George Cherian <george.cherian@ti.com>
>>> ---
>>>   arch/arm/boot/dts/am4372.dtsi | 99 +++++++++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 99 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>>> index 5a7cc38..90408b3 100644
>>> --- a/arch/arm/boot/dts/am4372.dtsi
>>> +++ b/arch/arm/boot/dts/am4372.dtsi
>>> @@ -698,6 +698,105 @@
>>>                      <&edma 11>;
>>>               dma-names = "tx", "rx";
>>>           };
>>> +
>>> +        am43xx_control_usb2phy1: control-phy@44e10620 {
>>> +            compatible = "ti,control-phy-am437usb2";
>> Since this is the first usage of this compatible ID, we still have room to
>> change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"
>>
>> Please see
>> http://article.gmane.org/gmane.linux.drivers.devicetree/64833
> 
> Okay.
>>> +            reg = <0x44e10620 0x4>;
>>> +            reg-names = "power";
>>> +            status = "disabled";
>> Why disable something that is within the SoC and does not affect board configurations?
>>
>> Question applies for all the nodes in this patch except the ones that come out on the
>> SoC pins. e.g. PHY.
> Okay
>>> +        };
>>> +
>>> +        am43xx_control_usb2phy2: control-phy@0x44e10628 {
>>> +            compatible = "ti,control-phy-am437usb2";
>>> +            reg = <0x44e10628 0x4>;
>>> +            reg-names = "power";
>>> +            status = "disabled";
>>> +        };
>>> +
>>> +        ocp2scp0: ocp2scp@483a8000 {
>>> +            compatible = "ti,omap-ocp2scp";
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            ranges;
>>> +            ti,hwmods = "ocp2scp0";
>>> +            status = "disabled";
>>> +
>>> +            usb2_phy1: usb2phy1@483a8000 {
>> should be
> okay
>>             usb2_phy1: phy@483a8000 {
>>
>>> +                compatible = "ti,am437x-usb2";
>>> +                reg = <0x483a8000 0x8000>;
>>> +                ctrl-module = <&am43xx_control_usb2phy1>;
>>> +                clocks = <&clk_32768_ck>,
>>> +                     <&usb_otg_ss0_refclk960m>;
>>> +                clock-names = "usb_phy_cm_clk32k",
>>> +                          "usb_otg_ss_refclk960m";
>> clock-names should be platform independent. Better option would be to
>> modify the usb2 driver to use names like "wkupclk" and "refclk"
> The phy driver still does devm_get_clk using above clock names and not "wkupclk" and "refclk".
> 

I'll post a patch soon that takes care of both clock names and the compatible ids in
the phy-omap-usb2.c driver.

>>> +                #phy-cells = <0>;
>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>> +        ocp2scp1: ocp2scp@483e8000 {
>>> +            compatible = "ti,omap-ocp2scp";
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            ranges;
>>> +            ti,hwmods = "ocp2scp1";
>>> +            status = "disabled";
>>> +
>>> +            usb2_phy2: usb2phy2@483e8000 {
>>> +                compatible = "ti,am437x-usb2";
>>> +                reg = <0x483e8000 0x8000>;
>>> +                ctrl-module = <&am43xx_control_usb2phy2>;
>>> +                clocks = <&clk_32768_ck>,
>>> +                     <&usb_otg_ss1_refclk960m>;
>>> +                clock-names = "usb_phy_cm_clk32k",
>>> +                          "usb_otg_ss_refclk960m";
>>> +                #phy-cells = <0>;
>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>> +        dwc3_1: omap_dwc3_1@48380000 {
>>> +            compatible = "ti,am437x-dwc3";
>>> +            ti,hwmods = "usb_otg_ss0";
>>> +            reg = <0x48380000 0x10000>;
>>> +            interrupts = <GIC_SPI 172 IRQ_TYPE_LEVEL_HIGH>;
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            utmi-mode = <1>;
>>> +            ranges;
>>> +            status = "disabled";
>>> +
>>> +            usb1: usb@48390000 {
>>> +                compatible = "synopsys,dwc3";
>>> +                reg = <0x48390000 0x17000>;
>>> +                interrupts = <GIC_SPI 168 IRQ_TYPE_LEVEL_HIGH>;
>>> +                usb-phy = <&usb2_phy1>;
>> shouldn't this be        phys = <&usb2_phy1>;    ?
> 
> At the time of writing this patch phys property is still not in.
> Also generic-phy conversion for dwc3 was recently posted by kishon.
>>> +                phy-names = "usb2-phy";
>> what about
>>     maximum-speed = "high-speed";
>> and
>>     dr_mode = "otg"; ?
> 
> Done from board file. Actually maximum-speed I can set here.
> dr_mode is a board property.

Is it a known standard that dr_mode must come from board dts?

I think dr_mode can be set here by default. Board can always override if it
needs non otg operation.

cheers,
-roger

>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>> +        dwc3_2: omap_dwc3_2@483c0000 {
>>> +            compatible = "ti,am437x-dwc3";
>>> +            ti,hwmods = "usb_otg_ss1";
>>> +            reg = <0x483c0000 0x10000>;
>>> +            interrupts = <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>;
>>> +            #address-cells = <1>;
>>> +            #size-cells = <1>;
>>> +            utmi-mode = <1>;
>>> +            ranges;
>>> +            status = "disabled";
>>> +
>>> +            usb2: usb@483d0000 {
>>> +                compatible = "synopsys,dwc3";
>>> +                reg = <0x483d0000 0x17000>;
>>> +                interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
>>> +                usb-phy = <&usb2_phy2>;
>>> +                phy-names = "usb2-phy";
>>> +                status = "disabled";
>>> +            };
>>> +        };
>>> +
>>>       };
>>>   };
>>>  
>> cheers,
>> -roger
> 
> 

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[Tony Lindgren]

* Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> [140306 00:52]:
> On 03/03/2014 03:53 PM, George Cherian wrote:
> > --- a/arch/arm/boot/dts/am4372.dtsi
> > +++ b/arch/arm/boot/dts/am4372.dtsi
> > @@ -698,6 +698,105 @@
> >  			       <&edma 11>;
> >  			dma-names = "tx", "rx";
> >  		};
> > +
> > +		am43xx_control_usb2phy1: control-phy@44e10620 {
> > +			compatible = "ti,control-phy-am437usb2";
> 
> Since this is the first usage of this compatible ID, we still have room to
> change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"

Or from grepping point of view ti,control-phy-usb2-am437 might be better?

Regards,

Tony 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] ARM: dts: AM4372: Add USB nodes

[Tony Lindgren]

* Roger Quadros <rogerq@ti.com> [140306 00:52]:
> On 03/03/2014 03:53 PM, George Cherian wrote:
> > --- a/arch/arm/boot/dts/am4372.dtsi
> > +++ b/arch/arm/boot/dts/am4372.dtsi
> > @@ -698,6 +698,105 @@
> >  			       <&edma 11>;
> >  			dma-names = "tx", "rx";
> >  		};
> > +
> > +		am43xx_control_usb2phy1: control-phy@44e10620 {
> > +			compatible = "ti,control-phy-am437usb2";
> 
> Since this is the first usage of this compatible ID, we still have room to
> change it to be better. Tony's suggestion was to use "ti,control-phy-am437-usb2"

Or from grepping point of view ti,control-phy-usb2-am437 might be better?

Regards,

Tony 

[PATCH 3/5] ARM: dts: am437x-gp-evm: Enable USB

[George Cherian]

Enable
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB
for am437x-gp-evm

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 44 +++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 4eb72b8..89e08cd 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -98,3 +98,47 @@
 &gpio4 {
 	status = "okay";
 };
+
+&am43xx_control_usb2phy1 {
+	status = "okay";
+};
+
+&ocp2scp0 {
+	status = "okay";
+};
+
+&usb2_phy1 {
+	status = "okay";
+};
+
+&dwc3_1 {
+	status = "okay";
+};
+
+&usb1 {
+	dr_mode = "peripheral";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
+
+&am43xx_control_usb2phy2 {
+	status = "okay";
+};
+
+&ocp2scp1 {
+	status = "okay";
+};
+
+&usb2_phy2 {
+	status = "okay";
+};
+
+&dwc3_2 {
+	status = "okay";
+};
+
+&usb2 {
+	dr_mode = "host";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
-- 
1.8.3.1

[PATCH 3/5] ARM: dts: am437x-gp-evm: Enable USB

[George Cherian]

Enable
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB
for am437x-gp-evm

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am437x-gp-evm.dts | 44 +++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 4eb72b8..89e08cd 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -98,3 +98,47 @@
 &gpio4 {
 	status = "okay";
 };
+
+&am43xx_control_usb2phy1 {
+	status = "okay";
+};
+
+&ocp2scp0 {
+	status = "okay";
+};
+
+&usb2_phy1 {
+	status = "okay";
+};
+
+&dwc3_1 {
+	status = "okay";
+};
+
+&usb1 {
+	dr_mode = "peripheral";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
+
+&am43xx_control_usb2phy2 {
+	status = "okay";
+};
+
+&ocp2scp1 {
+	status = "okay";
+};
+
+&usb2_phy2 {
+	status = "okay";
+};
+
+&dwc3_2 {
+	status = "okay";
+};
+
+&usb2 {
+	dr_mode = "host";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
-- 
1.8.3.1

[PATCH 4/5] ARM: dts: am43x-epos-evm: Enable USB

[George Cherian]

Enable
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB

for am43x-epos-evm

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am43x-epos-evm.dts | 44 ++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index a7d0db1..165026b 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -251,3 +251,47 @@
 	pinctrl-0 = <&spi1_pins>;
 	status = "okay";
 };
+
+&am43xx_control_usb2phy1 {
+	status = "okay";
+};
+
+&ocp2scp0 {
+	status = "okay";
+};
+
+&usb2_phy1 {
+	status = "okay";
+};
+
+&dwc3_1 {
+	status = "okay";
+};
+
+&usb1 {
+	dr_mode = "peripheral";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
+
+&am43xx_control_usb2phy2 {
+	status = "okay";
+};
+
+&ocp2scp1 {
+	status = "okay";
+};
+
+&usb2_phy2 {
+	status = "okay";
+};
+
+&dwc3_2 {
+	status = "okay";
+};
+
+&usb2 {
+	dr_mode = "host";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
-- 
1.8.3.1

[PATCH 4/5] ARM: dts: am43x-epos-evm: Enable USB

[George Cherian]

Enable
	- ocp2scp
	- USB PHY control module
	- USB PHY
	- dwc3_omap
	- USB

for am43x-epos-evm

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 arch/arm/boot/dts/am43x-epos-evm.dts | 44 ++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/arch/arm/boot/dts/am43x-epos-evm.dts b/arch/arm/boot/dts/am43x-epos-evm.dts
index a7d0db1..165026b 100644
--- a/arch/arm/boot/dts/am43x-epos-evm.dts
+++ b/arch/arm/boot/dts/am43x-epos-evm.dts
@@ -251,3 +251,47 @@
 	pinctrl-0 = <&spi1_pins>;
 	status = "okay";
 };
+
+&am43xx_control_usb2phy1 {
+	status = "okay";
+};
+
+&ocp2scp0 {
+	status = "okay";
+};
+
+&usb2_phy1 {
+	status = "okay";
+};
+
+&dwc3_1 {
+	status = "okay";
+};
+
+&usb1 {
+	dr_mode = "peripheral";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
+
+&am43xx_control_usb2phy2 {
+	status = "okay";
+};
+
+&ocp2scp1 {
+	status = "okay";
+};
+
+&usb2_phy2 {
+	status = "okay";
+};
+
+&dwc3_2 {
+	status = "okay";
+};
+
+&usb2 {
+	dr_mode = "host";
+	maximum-speed = "high-speed";
+	status = "okay";
+};
-- 
1.8.3.1

[PATCH 5/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[George Cherian]

Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
index c495135..1d38569 100644
--- a/Documentation/devicetree/bindings/usb/omap-usb.txt
+++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
@@ -44,7 +44,9 @@ Board specific device node entry
 };
 
 OMAP DWC3 GLUE
- - compatible : Should be "ti,dwc3"
+ - compatible : Should be
+	* "ti,dwc3" for OMAP5 and DRA7
+	* "ti,am437x-dwc3" for AM437x
  - ti,hwmods : Should be "usb_otg_ss"
  - reg : Address and length of the register set for the device.
  - interrupts : The irq number of this device that is used to interrupt the
-- 
1.8.3.1

[PATCH 5/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[George Cherian]

Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.

Signed-off-by: George Cherian <george.cherian@ti.com>
---
 Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
index c495135..1d38569 100644
--- a/Documentation/devicetree/bindings/usb/omap-usb.txt
+++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
@@ -44,7 +44,9 @@ Board specific device node entry
 };
 
 OMAP DWC3 GLUE
- - compatible : Should be "ti,dwc3"
+ - compatible : Should be
+	* "ti,dwc3" for OMAP5 and DRA7
+	* "ti,am437x-dwc3" for AM437x
  - ti,hwmods : Should be "usb_otg_ss"
  - reg : Address and length of the register set for the device.
  - interrupts : The irq number of this device that is used to interrupt the
-- 
1.8.3.1

Re: [PATCH 5/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[Roger Quadros]

On 03/03/2014 03:53 PM, George Cherian wrote:
> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
>  Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

The patch order could be the rearranged so that this appears before the
am437x bindings are used.

cheers,
-roger

> 
> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
> index c495135..1d38569 100644
> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
> @@ -44,7 +44,9 @@ Board specific device node entry
>  };
>  
>  OMAP DWC3 GLUE
> - - compatible : Should be "ti,dwc3"
> + - compatible : Should be
> +	* "ti,dwc3" for OMAP5 and DRA7
> +	* "ti,am437x-dwc3" for AM437x
>   - ti,hwmods : Should be "usb_otg_ss"
>   - reg : Address and length of the register set for the device.
>   - interrupts : The irq number of this device that is used to interrupt the
> 

Re: [PATCH 5/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[Roger Quadros]

On 03/03/2014 03:53 PM, George Cherian wrote:
> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
> 
> Signed-off-by: George Cherian <george.cherian@ti.com>
> ---
>  Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

The patch order could be the rearranged so that this appears before the
am437x bindings are used.

cheers,
-roger

> 
> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
> index c495135..1d38569 100644
> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
> @@ -44,7 +44,9 @@ Board specific device node entry
>  };
>  
>  OMAP DWC3 GLUE
> - - compatible : Should be "ti,dwc3"
> + - compatible : Should be
> +	* "ti,dwc3" for OMAP5 and DRA7
> +	* "ti,am437x-dwc3" for AM437x
>   - ti,hwmods : Should be "usb_otg_ss"
>   - reg : Address and length of the register set for the device.
>   - interrupts : The irq number of this device that is used to interrupt the
> 

Re: [PATCH 5/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[George Cherian]

Hi Roger,
On 3/6/2014 2:25 PM, Roger Quadros wrote:
> On 03/03/2014 03:53 PM, George Cherian wrote:
>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>>   Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
> The patch order could be the rearranged so that this appears before the
> am437x bindings are used.
>
> cheers,
> -roger

okay will do in v2
>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> index c495135..1d38569 100644
>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> @@ -44,7 +44,9 @@ Board specific device node entry
>>   };
>>   
>>   OMAP DWC3 GLUE
>> - - compatible : Should be "ti,dwc3"
>> + - compatible : Should be
>> +	* "ti,dwc3" for OMAP5 and DRA7
>> +	* "ti,am437x-dwc3" for AM437x
>>    - ti,hwmods : Should be "usb_otg_ss"
>>    - reg : Address and length of the register set for the device.
>>    - interrupts : The irq number of this device that is used to interrupt the
>>


-- 
-George

Re: [PATCH 5/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue

[George Cherian]

Hi Roger,
On 3/6/2014 2:25 PM, Roger Quadros wrote:
> On 03/03/2014 03:53 PM, George Cherian wrote:
>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
>>
>> Signed-off-by: George Cherian <george.cherian@ti.com>
>> ---
>>   Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
> The patch order could be the rearranged so that this appears before the
> am437x bindings are used.
>
> cheers,
> -roger

okay will do in v2
>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> index c495135..1d38569 100644
>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>> @@ -44,7 +44,9 @@ Board specific device node entry
>>   };
>>   
>>   OMAP DWC3 GLUE
>> - - compatible : Should be "ti,dwc3"
>> + - compatible : Should be
>> +	* "ti,dwc3" for OMAP5 and DRA7
>> +	* "ti,am437x-dwc3" for AM437x
>>    - ti,hwmods : Should be "usb_otg_ss"
>>    - reg : Address and length of the register set for the device.
>>    - interrupts : The irq number of this device that is used to interrupt the
>>


-- 
-George

Re: [PATCH 0/5] Add USB nodes for am43xx epos and gp evm

[Tony Lindgren]

* George Cherian <george.cherian@ti.com> [140303 05:58]:
> The patch series adds USB dt nodes for am43xx epos and gp evm
> 
> Boot tested with  Benoit's for_3.15 + following patches
> 
> https://patchwork.kernel.org/patch/3600821/
> https://patchwork.kernel.org/patch/3600831/
> https://patchwork.kernel.org/patch/3600851/
> https://patchwork.kernel.org/patch/3600841/

Roger, care to look through these and ack if OK?

Regards,

Tony

> George Cherian (5):
>   ARM: dts: am43xx clock data
>   ARM: dts: AM4372: Add USB nodes
>   ARM: dts: am437x-gp-evm: Enable USB
>   ARM: dts: am43x-epos-evm: Enable USB
>   doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue
> 
>  Documentation/devicetree/bindings/usb/omap-usb.txt |  4 +-
>  arch/arm/boot/dts/am4372.dtsi                      | 99 ++++++++++++++++++++++
>  arch/arm/boot/dts/am437x-gp-evm.dts                | 44 ++++++++++
>  arch/arm/boot/dts/am43x-epos-evm.dts               | 44 ++++++++++
>  arch/arm/boot/dts/am43xx-clocks.dtsi               | 17 ++++
>  5 files changed, 207 insertions(+), 1 deletion(-)
> 
> -- 
> 1.8.3.1
>