* [Buildroot] [PATCH v2 1/4] webkit: fix mmu reverse dependency moving it to %_ARCH_SUPPORTS
2014-03-06 9:42 [Buildroot] [PATCH v2 0/4] Misc patches Fabio Porcedda
@ 2014-03-06 9:42 ` Fabio Porcedda
2014-03-06 17:27 ` Arnout Vandecappelle
2014-03-06 9:42 ` [Buildroot] [PATCH v2 2/4] Makefile: remove BASE_TARGETS variable Fabio Porcedda
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Fabio Porcedda @ 2014-03-06 9:42 UTC (permalink / raw)
To: buildroot
Because mmu dependency was not propagated move it to
BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS to automatically propagate it.
It can ben moved to BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS because like
target architecture dependencies it doesn't modify the comment string.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
package/webkit/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/webkit/Config.in b/package/webkit/Config.in
index 2b0addc..5ba2eb3 100644
--- a/package/webkit/Config.in
+++ b/package/webkit/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
!(BR2_arm7tdmi || BR2_arm720t || BR2_arm920t || BR2_arm922t || BR2_fa526)
default y if BR2_i386 || BR2_mips || BR2_mipsel || \
BR2_sh || BR2_sparc || BR2_x86_64
+ depends on BR2_USE_MMU # libgail -> pango -> libglib2
# disabled on powerpc due to bug https://bugs.webkit.org/show_bug.cgi?id=113638
@@ -13,7 +14,6 @@ config BR2_PACKAGE_WEBKIT
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_USE_WCHAR # enchant -> libglib2
depends on BR2_TOOLCHAIN_HAS_THREADS # enchant -> libglib2
- depends on BR2_USE_MMU # libgail -> pango -> libglib2
depends on BR2_PACKAGE_LIBGTK2
depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
depends on !BR2_BINFMT_FLAT # icu
--
1.8.3.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Buildroot] [PATCH v2 1/4] webkit: fix mmu reverse dependency moving it to %_ARCH_SUPPORTS
2014-03-06 9:42 ` [Buildroot] [PATCH v2 1/4] webkit: fix mmu reverse dependency moving it to %_ARCH_SUPPORTS Fabio Porcedda
@ 2014-03-06 17:27 ` Arnout Vandecappelle
0 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2014-03-06 17:27 UTC (permalink / raw)
To: buildroot
On 06/03/14 10:42, Fabio Porcedda wrote:
> Because mmu dependency was not propagated move it to
> BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS to automatically propagate it.
> It can ben moved to BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS because like
> target architecture dependencies it doesn't modify the comment string.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/webkit/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/webkit/Config.in b/package/webkit/Config.in
> index 2b0addc..5ba2eb3 100644
> --- a/package/webkit/Config.in
> +++ b/package/webkit/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
> !(BR2_arm7tdmi || BR2_arm720t || BR2_arm920t || BR2_arm922t || BR2_fa526)
> default y if BR2_i386 || BR2_mips || BR2_mipsel || \
> BR2_sh || BR2_sparc || BR2_x86_64
> + depends on BR2_USE_MMU # libgail -> pango -> libglib2
>
> # disabled on powerpc due to bug https://bugs.webkit.org/show_bug.cgi?id=113638
>
> @@ -13,7 +14,6 @@ config BR2_PACKAGE_WEBKIT
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_USE_WCHAR # enchant -> libglib2
> depends on BR2_TOOLCHAIN_HAS_THREADS # enchant -> libglib2
> - depends on BR2_USE_MMU # libgail -> pango -> libglib2
> depends on BR2_PACKAGE_LIBGTK2
> depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
> depends on !BR2_BINFMT_FLAT # icu
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 2/4] Makefile: remove BASE_TARGETS variable
2014-03-06 9:42 [Buildroot] [PATCH v2 0/4] Misc patches Fabio Porcedda
2014-03-06 9:42 ` [Buildroot] [PATCH v2 1/4] webkit: fix mmu reverse dependency moving it to %_ARCH_SUPPORTS Fabio Porcedda
@ 2014-03-06 9:42 ` Fabio Porcedda
2014-03-06 17:30 ` Arnout Vandecappelle
2014-03-06 9:42 ` [Buildroot] [PATCH v2 3/4] linux: fix coding style Fabio Porcedda
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Fabio Porcedda @ 2014-03-06 9:42 UTC (permalink / raw)
To: buildroot
Because now the toolchain dependency is automatically added by the
package infrastructure the BASE_TARGETS variable is useless so just
remove it.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
Makefile | 10 ++++------
docs/manual/how-buildroot-works.txt | 9 ++++-----
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/Makefile b/Makefile
index 6eb9743..665865b 100644
--- a/Makefile
+++ b/Makefile
@@ -300,9 +300,7 @@ GNU_HOST_NAME:=$(shell support/gnuconfig/config.guess)
#
################################################################################
-BASE_TARGETS = toolchain
-
-TARGETS:=
+TARGETS:= toolchain
# silent mode requested?
QUIET:=$(if $(findstring s,$(MAKEFLAGS)),-q)
@@ -411,7 +409,7 @@ endif
include fs/common.mk
-TARGETS_SOURCE:=$(patsubst %,%-source,$(TARGETS) $(BASE_TARGETS))
+TARGETS_SOURCE:=$(patsubst %,%-source,$(TARGETS))
TARGETS_DIRCLEAN:=$(patsubst %,%-dirclean,$(TARGETS))
# host-* dependencies have to be handled specially, as those aren't
@@ -433,7 +431,7 @@ HOST_DEPS = $(sort $(foreach dep,\
HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
TARGETS_LEGAL_INFO:=$(patsubst %,%-legal-info,\
- $(TARGETS) $(BASE_TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
+ $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
$(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR)
@@ -452,7 +450,7 @@ world: target-post-image
.PHONY: all world toolchain dirs clean distclean source outputmakefile \
legal-info legal-info-prepare legal-info-clean printvars \
target-finalize target-post-image \
- $(BASE_TARGETS) $(TARGETS) $(TARGETS_ROOTFS) \
+ $(TARGETS) $(TARGETS_ROOTFS) \
$(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \
$(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
$(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR)
diff --git a/docs/manual/how-buildroot-works.txt b/docs/manual/how-buildroot-works.txt
index 68ddd13..a96e45b 100644
--- a/docs/manual/how-buildroot-works.txt
+++ b/docs/manual/how-buildroot-works.txt
@@ -56,11 +56,10 @@ configuration is done):
+stamps+, etc. in the output directory (+output/+ by default,
another value can be specified using +O=+)
-* Generate all the targets listed in the +BASE_TARGETS+ variable. When
- an internal toolchain is used, this means generating the
- cross-compilation toolchain. When an external toolchain is used,
- this means checking the features of the external toolchain and
- importing it into the Buildroot environment.
+* Generate the toolchain target. When an internal toolchain is used, this
+ means generating the cross-compilation toolchain. When an external
+ toolchain is used, this means checking the features of the external
+ toolchain and importing it into the Buildroot environment.
* Generate all the targets listed in the +TARGETS+ variable. This
variable is filled by all the individual components'
--
1.8.3.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Buildroot] [PATCH v2 2/4] Makefile: remove BASE_TARGETS variable
2014-03-06 9:42 ` [Buildroot] [PATCH v2 2/4] Makefile: remove BASE_TARGETS variable Fabio Porcedda
@ 2014-03-06 17:30 ` Arnout Vandecappelle
0 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2014-03-06 17:30 UTC (permalink / raw)
To: buildroot
On 06/03/14 10:42, Fabio Porcedda wrote:
> Because now the toolchain dependency is automatically added by the
> package infrastructure the BASE_TARGETS variable is useless so just
> remove it.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> Makefile | 10 ++++------
> docs/manual/how-buildroot-works.txt | 9 ++++-----
> 2 files changed, 8 insertions(+), 11 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 6eb9743..665865b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -300,9 +300,7 @@ GNU_HOST_NAME:=$(shell support/gnuconfig/config.guess)
> #
> ################################################################################
>
> -BASE_TARGETS = toolchain
> -
> -TARGETS:=
> +TARGETS:= toolchain
>
> # silent mode requested?
> QUIET:=$(if $(findstring s,$(MAKEFLAGS)),-q)
> @@ -411,7 +409,7 @@ endif
>
> include fs/common.mk
>
> -TARGETS_SOURCE:=$(patsubst %,%-source,$(TARGETS) $(BASE_TARGETS))
> +TARGETS_SOURCE:=$(patsubst %,%-source,$(TARGETS))
> TARGETS_DIRCLEAN:=$(patsubst %,%-dirclean,$(TARGETS))
>
> # host-* dependencies have to be handled specially, as those aren't
> @@ -433,7 +431,7 @@ HOST_DEPS = $(sort $(foreach dep,\
> HOST_SOURCE += $(addsuffix -source,$(sort $(TARGETS_HOST_DEPS) $(HOST_DEPS)))
>
> TARGETS_LEGAL_INFO:=$(patsubst %,%-legal-info,\
> - $(TARGETS) $(BASE_TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
> + $(TARGETS) $(TARGETS_HOST_DEPS) $(HOST_DEPS))))
>
> dirs: $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
> $(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR)
> @@ -452,7 +450,7 @@ world: target-post-image
> .PHONY: all world toolchain dirs clean distclean source outputmakefile \
> legal-info legal-info-prepare legal-info-clean printvars \
> target-finalize target-post-image \
> - $(BASE_TARGETS) $(TARGETS) $(TARGETS_ROOTFS) \
> + $(TARGETS) $(TARGETS_ROOTFS) \
> $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \
> $(BUILD_DIR) $(STAGING_DIR) $(TARGET_DIR) \
> $(HOST_DIR) $(BINARIES_DIR) $(STAMP_DIR)
> diff --git a/docs/manual/how-buildroot-works.txt b/docs/manual/how-buildroot-works.txt
> index 68ddd13..a96e45b 100644
> --- a/docs/manual/how-buildroot-works.txt
> +++ b/docs/manual/how-buildroot-works.txt
> @@ -56,11 +56,10 @@ configuration is done):
> +stamps+, etc. in the output directory (+output/+ by default,
> another value can be specified using +O=+)
>
> -* Generate all the targets listed in the +BASE_TARGETS+ variable. When
> - an internal toolchain is used, this means generating the
> - cross-compilation toolchain. When an external toolchain is used,
> - this means checking the features of the external toolchain and
> - importing it into the Buildroot environment.
> +* Generate the toolchain target. When an internal toolchain is used, this
> + means generating the cross-compilation toolchain. When an external
> + toolchain is used, this means checking the features of the external
> + toolchain and importing it into the Buildroot environment.
>
> * Generate all the targets listed in the +TARGETS+ variable. This
> variable is filled by all the individual components'
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 3/4] linux: fix coding style
2014-03-06 9:42 [Buildroot] [PATCH v2 0/4] Misc patches Fabio Porcedda
2014-03-06 9:42 ` [Buildroot] [PATCH v2 1/4] webkit: fix mmu reverse dependency moving it to %_ARCH_SUPPORTS Fabio Porcedda
2014-03-06 9:42 ` [Buildroot] [PATCH v2 2/4] Makefile: remove BASE_TARGETS variable Fabio Porcedda
@ 2014-03-06 9:42 ` Fabio Porcedda
2014-03-06 17:34 ` Arnout Vandecappelle
2014-03-06 9:42 ` [Buildroot] [PATCH v2 4/4] linux: remove dirs dependency Fabio Porcedda
2014-03-06 21:52 ` [Buildroot] [PATCH v2 0/4] Misc patches Thomas Petazzoni
4 siblings, 1 reply; 11+ messages in thread
From: Fabio Porcedda @ 2014-03-06 9:42 UTC (permalink / raw)
To: buildroot
As stated in the Buildroot user manual add one space before and after
a = sign.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
linux/linux.mk | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/linux/linux.mk b/linux/linux.mk
index f948e6c..3d52e69 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -41,7 +41,7 @@ endif
LINUX_PATCHES = $(call qstrip,$(BR2_LINUX_KERNEL_PATCH))
LINUX_INSTALL_IMAGES = YES
-LINUX_DEPENDENCIES += host-kmod host-lzop
+LINUX_DEPENDENCIES += host-kmod host-lzop
ifeq ($(BR2_LINUX_KERNEL_UBOOT_IMAGE),y)
LINUX_DEPENDENCIES += host-uboot-tools
@@ -80,36 +80,36 @@ endif
KERNEL_DTBS = $(addsuffix .dtb,$(KERNEL_DTS_NAME))
ifeq ($(BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM),y)
-LINUX_IMAGE_NAME=$(call qstrip,$(BR2_LINUX_KERNEL_IMAGE_TARGET_NAME))
+LINUX_IMAGE_NAME = $(call qstrip,$(BR2_LINUX_KERNEL_IMAGE_TARGET_NAME))
else
ifeq ($(BR2_LINUX_KERNEL_UIMAGE),y)
-LINUX_IMAGE_NAME=uImage
+LINUX_IMAGE_NAME = uImage
else ifeq ($(BR2_LINUX_KERNEL_APPENDED_UIMAGE),y)
-LINUX_IMAGE_NAME=uImage
+LINUX_IMAGE_NAME = uImage
else ifeq ($(BR2_LINUX_KERNEL_BZIMAGE),y)
-LINUX_IMAGE_NAME=bzImage
+LINUX_IMAGE_NAME = bzImage
else ifeq ($(BR2_LINUX_KERNEL_ZIMAGE),y)
-LINUX_IMAGE_NAME=zImage
+LINUX_IMAGE_NAME = zImage
else ifeq ($(BR2_LINUX_KERNEL_APPENDED_ZIMAGE),y)
-LINUX_IMAGE_NAME=zImage
+LINUX_IMAGE_NAME = zImage
else ifeq ($(BR2_LINUX_KERNEL_CUIMAGE),y)
-LINUX_IMAGE_NAME=cuImage.$(KERNEL_DTS_NAME)
+LINUX_IMAGE_NAME = cuImage.$(KERNEL_DTS_NAME)
else ifeq ($(BR2_LINUX_KERNEL_SIMPLEIMAGE),y)
-LINUX_IMAGE_NAME=simpleImage.$(KERNEL_DTS_NAME)
+LINUX_IMAGE_NAME = simpleImage.$(KERNEL_DTS_NAME)
else ifeq ($(BR2_LINUX_KERNEL_LINUX_BIN),y)
-LINUX_IMAGE_NAME=linux.bin
+LINUX_IMAGE_NAME = linux.bin
else ifeq ($(BR2_LINUX_KERNEL_VMLINUX_BIN),y)
-LINUX_IMAGE_NAME=vmlinux.bin
+LINUX_IMAGE_NAME = vmlinux.bin
else ifeq ($(BR2_LINUX_KERNEL_VMLINUX),y)
-LINUX_IMAGE_NAME=vmlinux
+LINUX_IMAGE_NAME = vmlinux
else ifeq ($(BR2_LINUX_KERNEL_VMLINUZ),y)
-LINUX_IMAGE_NAME=vmlinuz
+LINUX_IMAGE_NAME = vmlinuz
endif
endif
LINUX_KERNEL_UIMAGE_LOADADDR=$(call qstrip,$(BR2_LINUX_KERNEL_UIMAGE_LOADADDR))
ifneq ($(LINUX_KERNEL_UIMAGE_LOADADDR),)
-LINUX_MAKE_FLAGS+=LOADADDR="$(LINUX_KERNEL_UIMAGE_LOADADDR)"
+LINUX_MAKE_FLAGS += LOADADDR="$(LINUX_KERNEL_UIMAGE_LOADADDR)"
endif
# Compute the arch path, since i386 and x86_64 are in arch/x86 and not
@@ -117,22 +117,22 @@ endif
# for bzImage, arch/i386 and arch/x86_64 do not exist when copying the
# defconfig file.
ifeq ($(KERNEL_ARCH),i386)
-KERNEL_ARCH_PATH=$(LINUX_DIR)/arch/x86
+KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/x86
else ifeq ($(KERNEL_ARCH),x86_64)
-KERNEL_ARCH_PATH=$(LINUX_DIR)/arch/x86
+KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/x86
else
-KERNEL_ARCH_PATH=$(LINUX_DIR)/arch/$(KERNEL_ARCH)
+KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/$(KERNEL_ARCH)
endif
ifeq ($(BR2_LINUX_KERNEL_VMLINUX),y)
-LINUX_IMAGE_PATH=$(LINUX_DIR)/$(LINUX_IMAGE_NAME)
+LINUX_IMAGE_PATH = $(LINUX_DIR)/$(LINUX_IMAGE_NAME)
else ifeq ($(BR2_LINUX_KERNEL_VMLINUZ),y)
-LINUX_IMAGE_PATH=$(LINUX_DIR)/$(LINUX_IMAGE_NAME)
+LINUX_IMAGE_PATH = $(LINUX_DIR)/$(LINUX_IMAGE_NAME)
else
ifeq ($(KERNEL_ARCH),avr32)
-LINUX_IMAGE_PATH=$(KERNEL_ARCH_PATH)/boot/images/$(LINUX_IMAGE_NAME)
+LINUX_IMAGE_PATH = $(KERNEL_ARCH_PATH)/boot/images/$(LINUX_IMAGE_NAME)
else
-LINUX_IMAGE_PATH=$(KERNEL_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME)
+LINUX_IMAGE_PATH = $(KERNEL_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME)
endif
endif # BR2_LINUX_KERNEL_VMLINUX
--
1.8.3.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 3/4] linux: fix coding style
2014-03-06 9:42 ` [Buildroot] [PATCH v2 3/4] linux: fix coding style Fabio Porcedda
@ 2014-03-06 17:34 ` Arnout Vandecappelle
0 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2014-03-06 17:34 UTC (permalink / raw)
To: buildroot
On 06/03/14 10:42, Fabio Porcedda wrote:
> As stated in the Buildroot user manual add one space before and after
> a = sign.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> linux/linux.mk | 42 +++++++++++++++++++++---------------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index f948e6c..3d52e69 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -41,7 +41,7 @@ endif
> LINUX_PATCHES = $(call qstrip,$(BR2_LINUX_KERNEL_PATCH))
>
> LINUX_INSTALL_IMAGES = YES
> -LINUX_DEPENDENCIES += host-kmod host-lzop
> +LINUX_DEPENDENCIES += host-kmod host-lzop
>
> ifeq ($(BR2_LINUX_KERNEL_UBOOT_IMAGE),y)
> LINUX_DEPENDENCIES += host-uboot-tools
> @@ -80,36 +80,36 @@ endif
> KERNEL_DTBS = $(addsuffix .dtb,$(KERNEL_DTS_NAME))
>
> ifeq ($(BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM),y)
> -LINUX_IMAGE_NAME=$(call qstrip,$(BR2_LINUX_KERNEL_IMAGE_TARGET_NAME))
> +LINUX_IMAGE_NAME = $(call qstrip,$(BR2_LINUX_KERNEL_IMAGE_TARGET_NAME))
> else
> ifeq ($(BR2_LINUX_KERNEL_UIMAGE),y)
> -LINUX_IMAGE_NAME=uImage
> +LINUX_IMAGE_NAME = uImage
> else ifeq ($(BR2_LINUX_KERNEL_APPENDED_UIMAGE),y)
> -LINUX_IMAGE_NAME=uImage
> +LINUX_IMAGE_NAME = uImage
> else ifeq ($(BR2_LINUX_KERNEL_BZIMAGE),y)
> -LINUX_IMAGE_NAME=bzImage
> +LINUX_IMAGE_NAME = bzImage
> else ifeq ($(BR2_LINUX_KERNEL_ZIMAGE),y)
> -LINUX_IMAGE_NAME=zImage
> +LINUX_IMAGE_NAME = zImage
> else ifeq ($(BR2_LINUX_KERNEL_APPENDED_ZIMAGE),y)
> -LINUX_IMAGE_NAME=zImage
> +LINUX_IMAGE_NAME = zImage
> else ifeq ($(BR2_LINUX_KERNEL_CUIMAGE),y)
> -LINUX_IMAGE_NAME=cuImage.$(KERNEL_DTS_NAME)
> +LINUX_IMAGE_NAME = cuImage.$(KERNEL_DTS_NAME)
> else ifeq ($(BR2_LINUX_KERNEL_SIMPLEIMAGE),y)
> -LINUX_IMAGE_NAME=simpleImage.$(KERNEL_DTS_NAME)
> +LINUX_IMAGE_NAME = simpleImage.$(KERNEL_DTS_NAME)
> else ifeq ($(BR2_LINUX_KERNEL_LINUX_BIN),y)
> -LINUX_IMAGE_NAME=linux.bin
> +LINUX_IMAGE_NAME = linux.bin
> else ifeq ($(BR2_LINUX_KERNEL_VMLINUX_BIN),y)
> -LINUX_IMAGE_NAME=vmlinux.bin
> +LINUX_IMAGE_NAME = vmlinux.bin
> else ifeq ($(BR2_LINUX_KERNEL_VMLINUX),y)
> -LINUX_IMAGE_NAME=vmlinux
> +LINUX_IMAGE_NAME = vmlinux
> else ifeq ($(BR2_LINUX_KERNEL_VMLINUZ),y)
> -LINUX_IMAGE_NAME=vmlinuz
> +LINUX_IMAGE_NAME = vmlinuz
> endif
> endif
>
> LINUX_KERNEL_UIMAGE_LOADADDR=$(call qstrip,$(BR2_LINUX_KERNEL_UIMAGE_LOADADDR))
> ifneq ($(LINUX_KERNEL_UIMAGE_LOADADDR),)
> -LINUX_MAKE_FLAGS+=LOADADDR="$(LINUX_KERNEL_UIMAGE_LOADADDR)"
> +LINUX_MAKE_FLAGS += LOADADDR="$(LINUX_KERNEL_UIMAGE_LOADADDR)"
> endif
>
> # Compute the arch path, since i386 and x86_64 are in arch/x86 and not
> @@ -117,22 +117,22 @@ endif
> # for bzImage, arch/i386 and arch/x86_64 do not exist when copying the
> # defconfig file.
> ifeq ($(KERNEL_ARCH),i386)
> -KERNEL_ARCH_PATH=$(LINUX_DIR)/arch/x86
> +KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/x86
> else ifeq ($(KERNEL_ARCH),x86_64)
> -KERNEL_ARCH_PATH=$(LINUX_DIR)/arch/x86
> +KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/x86
> else
> -KERNEL_ARCH_PATH=$(LINUX_DIR)/arch/$(KERNEL_ARCH)
> +KERNEL_ARCH_PATH = $(LINUX_DIR)/arch/$(KERNEL_ARCH)
> endif
>
> ifeq ($(BR2_LINUX_KERNEL_VMLINUX),y)
> -LINUX_IMAGE_PATH=$(LINUX_DIR)/$(LINUX_IMAGE_NAME)
> +LINUX_IMAGE_PATH = $(LINUX_DIR)/$(LINUX_IMAGE_NAME)
> else ifeq ($(BR2_LINUX_KERNEL_VMLINUZ),y)
> -LINUX_IMAGE_PATH=$(LINUX_DIR)/$(LINUX_IMAGE_NAME)
> +LINUX_IMAGE_PATH = $(LINUX_DIR)/$(LINUX_IMAGE_NAME)
> else
> ifeq ($(KERNEL_ARCH),avr32)
> -LINUX_IMAGE_PATH=$(KERNEL_ARCH_PATH)/boot/images/$(LINUX_IMAGE_NAME)
> +LINUX_IMAGE_PATH = $(KERNEL_ARCH_PATH)/boot/images/$(LINUX_IMAGE_NAME)
> else
> -LINUX_IMAGE_PATH=$(KERNEL_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME)
> +LINUX_IMAGE_PATH = $(KERNEL_ARCH_PATH)/boot/$(LINUX_IMAGE_NAME)
> endif
> endif # BR2_LINUX_KERNEL_VMLINUX
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 4/4] linux: remove dirs dependency
2014-03-06 9:42 [Buildroot] [PATCH v2 0/4] Misc patches Fabio Porcedda
` (2 preceding siblings ...)
2014-03-06 9:42 ` [Buildroot] [PATCH v2 3/4] linux: fix coding style Fabio Porcedda
@ 2014-03-06 9:42 ` Fabio Porcedda
2014-03-06 17:37 ` Arnout Vandecappelle
2014-03-06 21:52 ` [Buildroot] [PATCH v2 0/4] Misc patches Thomas Petazzoni
4 siblings, 1 reply; 11+ messages in thread
From: Fabio Porcedda @ 2014-03-06 9:42 UTC (permalink / raw)
To: buildroot
The "dirs" dependency is redundant because now the "generic-package"
infrastructure add automatically the "dirs" dependency so just remove
the redundant references.
Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
linux/linux.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux/linux.mk b/linux/linux.mk
index 3d52e69..e270705 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -302,12 +302,12 @@ include $(sort $(wildcard linux/linux-ext-*.mk))
$(eval $(generic-package))
ifeq ($(BR2_LINUX_KERNEL),y)
-linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: dirs linux-configure
+linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: linux-configure
$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \
$(subst linux-,,$(subst linux26-,,$@))
rm -f $(LINUX_DIR)/.stamp_{built,target_installed,images_installed}
-linux-savedefconfig linux26-savedefconfig: dirs linux-configure
+linux-savedefconfig linux26-savedefconfig: linux-configure
$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \
$(subst linux-,,$(subst linux26-,,$@))
--
1.8.3.2
^ permalink raw reply related [flat|nested] 11+ messages in thread* [Buildroot] [PATCH v2 4/4] linux: remove dirs dependency
2014-03-06 9:42 ` [Buildroot] [PATCH v2 4/4] linux: remove dirs dependency Fabio Porcedda
@ 2014-03-06 17:37 ` Arnout Vandecappelle
2014-03-07 8:41 ` Fabio Porcedda
0 siblings, 1 reply; 11+ messages in thread
From: Arnout Vandecappelle @ 2014-03-06 17:37 UTC (permalink / raw)
To: buildroot
On 06/03/14 10:42, Fabio Porcedda wrote:
> The "dirs" dependency is redundant because now the "generic-package"
> infrastructure add automatically the "dirs" dependency so just remove
> the redundant references.
>
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
There are also redundant dependencies on dirs in Makefile and in
package/uclibc/uclibc.mk - that can be done in a separate patch, but if
you get around to fixing the other places before this one gets committed
please do include it.
Regards,
Arnout
> ---
> linux/linux.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 3d52e69..e270705 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -302,12 +302,12 @@ include $(sort $(wildcard linux/linux-ext-*.mk))
> $(eval $(generic-package))
>
> ifeq ($(BR2_LINUX_KERNEL),y)
> -linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: dirs linux-configure
> +linux-menuconfig linux-xconfig linux-gconfig linux-nconfig linux26-menuconfig linux26-xconfig linux26-gconfig linux26-nconfig: linux-configure
> $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \
> $(subst linux-,,$(subst linux26-,,$@))
> rm -f $(LINUX_DIR)/.stamp_{built,target_installed,images_installed}
>
> -linux-savedefconfig linux26-savedefconfig: dirs linux-configure
> +linux-savedefconfig linux26-savedefconfig: linux-configure
> $(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \
> $(subst linux-,,$(subst linux26-,,$@))
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 11+ messages in thread* [Buildroot] [PATCH v2 4/4] linux: remove dirs dependency
2014-03-06 17:37 ` Arnout Vandecappelle
@ 2014-03-07 8:41 ` Fabio Porcedda
0 siblings, 0 replies; 11+ messages in thread
From: Fabio Porcedda @ 2014-03-07 8:41 UTC (permalink / raw)
To: buildroot
On Thu, Mar 6, 2014 at 6:37 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 06/03/14 10:42, Fabio Porcedda wrote:
>> The "dirs" dependency is redundant because now the "generic-package"
>> infrastructure add automatically the "dirs" dependency so just remove
>> the redundant references.
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
>
> There are also redundant dependencies on dirs in Makefile and in
> package/uclibc/uclibc.mk - that can be done in a separate patch, but if
> you get around to fixing the other places before this one gets committed
> please do include it.
Hi Arnout,
thanks for reviewing.
I will send a patch to remove the dirs dependency from the other files.
Regards
Fabio Porcedda
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v2 0/4] Misc patches
2014-03-06 9:42 [Buildroot] [PATCH v2 0/4] Misc patches Fabio Porcedda
` (3 preceding siblings ...)
2014-03-06 9:42 ` [Buildroot] [PATCH v2 4/4] linux: remove dirs dependency Fabio Porcedda
@ 2014-03-06 21:52 ` Thomas Petazzoni
4 siblings, 0 replies; 11+ messages in thread
From: Thomas Petazzoni @ 2014-03-06 21:52 UTC (permalink / raw)
To: buildroot
Dear Fabio Porcedda,
On Thu, 6 Mar 2014 10:42:25 +0100, Fabio Porcedda wrote:
> Some misc patches.
>
> v2:
> - Add three more patches
>
> Regards
> Fabio Porcedda
>
> Fabio Porcedda (4):
> webkit: fix mmu reverse dependency moving it to %_ARCH_SUPPORTS
> Makefile: remove BASE_TARGETS variable
> linux: fix coding style
> linux: remove dirs dependency
Series applied, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 11+ messages in thread