* [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
@ 2014-03-05 0:17 Peter F. Patel-Schneider
2014-03-05 19:08 ` Srinivas Pandruvada
0 siblings, 1 reply; 8+ messages in thread
From: Peter F. Patel-Schneider @ 2014-03-05 0:17 UTC (permalink / raw)
To: linux-iio@vger.kernel.org
The sensor hub in Lenovo Yogas needs the ennumeration quirk. I've been
running the patch for about a week with no problems, whereas theunpatched
drivers reliably mis-initialized the sensors.
Signed-off-by: Peter F. Patel-Schneider <pfpschneider@gmail.com>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/hid-sensor-hub.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5a5248f..f944e37 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -823,6 +823,9 @@
#define USB_DEVICE_ID_SYNAPTICS_HD 0x0ac3
#define USB_DEVICE_ID_SYNAPTICS_QUAD_HD 0x1ac3
+#define USB_VENDOR_ID_TEXAS_INSTRUMENTS 0x2047
+#define USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA 0x0855
+
#define USB_VENDOR_ID_THINGM 0x27b8
#define USB_DEVICE_ID_BLINK1 0x01ed
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 46f4480..597732b 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -665,6 +665,9 @@ static const struct hid_device_id sensor_hub_devices[] = {
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1,
USB_DEVICE_ID_INTEL_HID_SENSOR),
.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
+ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
USB_VENDOR_ID_TEXAS_INSTRUMENTS,
+ USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA),
+ .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
HID_ANY_ID) },
{ }
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
2014-03-05 0:17 Peter F. Patel-Schneider
@ 2014-03-05 19:08 ` Srinivas Pandruvada
2014-03-06 9:57 ` Jiri Kosina
0 siblings, 1 reply; 8+ messages in thread
From: Srinivas Pandruvada @ 2014-03-05 19:08 UTC (permalink / raw)
To: Peter F. Patel-Schneider; +Cc: linux-iio@vger.kernel.org, Jiri Kosina
Looks good, but need to post to linux_input mailing list for Jiri to
pick up.
Thanks,
Srinivas
On 03/04/2014 04:17 PM, Peter F. Patel-Schneider wrote:
> The sensor hub in Lenovo Yogas needs the ennumeration quirk. I've
> been running the patch for about a week with no problems, whereas
> theunpatched drivers reliably mis-initialized the sensors.
>
> Signed-off-by: Peter F. Patel-Schneider <pfpschneider@gmail.com>
> ---
> drivers/hid/hid-ids.h | 3 +++
> drivers/hid/hid-sensor-hub.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5a5248f..f944e37 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -823,6 +823,9 @@
> #define USB_DEVICE_ID_SYNAPTICS_HD 0x0ac3
> #define USB_DEVICE_ID_SYNAPTICS_QUAD_HD 0x1ac3
>
> +#define USB_VENDOR_ID_TEXAS_INSTRUMENTS 0x2047
> +#define USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA 0x0855
> +
> #define USB_VENDOR_ID_THINGM 0x27b8
> #define USB_DEVICE_ID_BLINK1 0x01ed
>
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 46f4480..597732b 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -665,6 +665,9 @@ static const struct hid_device_id
> sensor_hub_devices[] = {
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_INTEL_1,
> USB_DEVICE_ID_INTEL_HID_SENSOR),
> .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_TEXAS_INSTRUMENTS,
> + USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA),
> + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
> HID_ANY_ID) },
> { }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
2014-03-05 19:08 ` Srinivas Pandruvada
@ 2014-03-06 9:57 ` Jiri Kosina
0 siblings, 0 replies; 8+ messages in thread
From: Jiri Kosina @ 2014-03-06 9:57 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: Peter F. Patel-Schneider, linux-iio@vger.kernel.org
On Wed, 5 Mar 2014, Srinivas Pandruvada wrote:
> Looks good, but need to post to linux_input mailing list for Jiri to pick up.
Indeed, please resend so that I have non-quoted version to apply.
Also if Srinivas can provide his Ack/Signoff, that'd be helpful.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
@ 2014-03-06 20:57 Peter F. Patel-Schneider
2014-03-06 22:43 ` Srinivas Pandruvada
0 siblings, 1 reply; 8+ messages in thread
From: Peter F. Patel-Schneider @ 2014-03-06 20:57 UTC (permalink / raw)
To: linux-input; +Cc: srinivas.pandruvada
The sensor hub in Lenovo Yogas needs the enumeration quirk. I've been running
the patch for about a week with no problems, whereas the unpatched drivers
reliably mis-initialized the sensors.
Signed-off-by: Peter F. Patel-Schneider <pfpschneider@gmail.com>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/hid-sensor-hub.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5a5248f..f944e37 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -823,6 +823,9 @@
#define USB_DEVICE_ID_SYNAPTICS_HD 0x0ac3
#define USB_DEVICE_ID_SYNAPTICS_QUAD_HD 0x1ac3
+#define USB_VENDOR_ID_TEXAS_INSTRUMENTS 0x2047
+#define USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA 0x0855
+
#define USB_VENDOR_ID_THINGM 0x27b8
#define USB_DEVICE_ID_BLINK1 0x01ed
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 46f4480..597732b 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -665,6 +665,9 @@ static const struct hid_device_id sensor_hub_devices[] = {
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1,
USB_DEVICE_ID_INTEL_HID_SENSOR),
.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
+ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
USB_VENDOR_ID_TEXAS_INSTRUMENTS,
+ USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA),
+ .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
HID_ANY_ID) },
{ }
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
2014-03-06 20:57 [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas Peter F. Patel-Schneider
@ 2014-03-06 22:43 ` Srinivas Pandruvada
0 siblings, 0 replies; 8+ messages in thread
From: Srinivas Pandruvada @ 2014-03-06 22:43 UTC (permalink / raw)
To: Peter F. Patel-Schneider; +Cc: linux-input
On 03/06/2014 12:57 PM, Peter F. Patel-Schneider wrote:
> The sensor hub in Lenovo Yogas needs the enumeration quirk. I've been
> running the patch for about a week with no problems, whereas the
> unpatched drivers reliably mis-initialized the sensors.
>
> Signed-off-by: Peter F. Patel-Schneider <pfpschneider@gmail.com>
> ---
> drivers/hid/hid-ids.h | 3 +++
> drivers/hid/hid-sensor-hub.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5a5248f..f944e37 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -823,6 +823,9 @@
> #define USB_DEVICE_ID_SYNAPTICS_HD 0x0ac3
> #define USB_DEVICE_ID_SYNAPTICS_QUAD_HD 0x1ac3
>
> +#define USB_VENDOR_ID_TEXAS_INSTRUMENTS 0x2047
> +#define USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA 0x0855
> +
> #define USB_VENDOR_ID_THINGM 0x27b8
> #define USB_DEVICE_ID_BLINK1 0x01ed
>
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 46f4480..597732b 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -665,6 +665,9 @@ static const struct hid_device_id
> sensor_hub_devices[] = {
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_INTEL_1,
> USB_DEVICE_ID_INTEL_HID_SENSOR),
> .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_TEXAS_INSTRUMENTS,
> + USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA),
> + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
> HID_ANY_ID) },
> { }
>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
@ 2014-05-05 22:55 Peter F. Patel-Schneider
2014-05-05 23:02 ` Jiri Kosina
2014-05-05 23:03 ` Srinivas Pandruvada
0 siblings, 2 replies; 8+ messages in thread
From: Peter F. Patel-Schneider @ 2014-05-05 22:55 UTC (permalink / raw)
To: linux-input, jkosina; +Cc: Srinivas Pandruvada
The sensor hub in Lenovo Yogas needs the enumeration quirk. I've been running
the patch for over a month with no problems, whereas the unpatched drivers
reliably mis-initialized the sensors. (This is a resending of a previous patch
that had formatting issues.)
Signed-off-by: Peter F. Patel-Schneider <pfpschneider@gmail.com>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/hid-sensor-hub.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5a5248f..f944e37 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -823,6 +823,9 @@
#define USB_DEVICE_ID_SYNAPTICS_HD 0x0ac3
#define USB_DEVICE_ID_SYNAPTICS_QUAD_HD 0x1ac3
+#define USB_VENDOR_ID_TEXAS_INSTRUMENTS 0x2047
+#define USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA 0x0855
+
#define USB_VENDOR_ID_THINGM 0x27b8
#define USB_DEVICE_ID_BLINK1 0x01ed
diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
index 46f4480..597732b 100644
--- a/drivers/hid/hid-sensor-hub.c
+++ b/drivers/hid/hid-sensor-hub.c
@@ -665,6 +665,9 @@ static const struct hid_device_id sensor_hub_devices[] = {
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_INTEL_1,
USB_DEVICE_ID_INTEL_HID_SENSOR),
.driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
+ { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, USB_VENDOR_ID_TEXAS_INSTRUMENTS,
+ USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA),
+ .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
HID_ANY_ID) },
{ }
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
2014-05-05 22:55 Peter F. Patel-Schneider
@ 2014-05-05 23:02 ` Jiri Kosina
2014-05-05 23:03 ` Srinivas Pandruvada
1 sibling, 0 replies; 8+ messages in thread
From: Jiri Kosina @ 2014-05-05 23:02 UTC (permalink / raw)
To: Peter F. Patel-Schneider; +Cc: linux-input, Srinivas Pandruvada
On Mon, 5 May 2014, Peter F. Patel-Schneider wrote:
> The sensor hub in Lenovo Yogas needs the enumeration quirk. I've been running
> the patch for over a month with no problems, whereas the unpatched drivers
> reliably mis-initialized the sensors. (This is a resending of a previous patch
> that had formatting issues.)
>
> Signed-off-by: Peter F. Patel-Schneider <pfpschneider@gmail.com>
Now applied. Will be pushing it for 3.15. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas
2014-05-05 22:55 Peter F. Patel-Schneider
2014-05-05 23:02 ` Jiri Kosina
@ 2014-05-05 23:03 ` Srinivas Pandruvada
1 sibling, 0 replies; 8+ messages in thread
From: Srinivas Pandruvada @ 2014-05-05 23:03 UTC (permalink / raw)
To: Peter F. Patel-Schneider; +Cc: linux-input, jkosina
On 05/05/2014 03:55 PM, Peter F. Patel-Schneider wrote:
> The sensor hub in Lenovo Yogas needs the enumeration quirk. I've been
> running the patch for over a month with no problems, whereas the
> unpatched drivers reliably mis-initialized the sensors. (This is a
> resending of a previous patch that had formatting issues.)
>
> Signed-off-by: Peter F. Patel-Schneider <pfpschneider@gmail.com>
> ---
> drivers/hid/hid-ids.h | 3 +++
> drivers/hid/hid-sensor-hub.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5a5248f..f944e37 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -823,6 +823,9 @@
> #define USB_DEVICE_ID_SYNAPTICS_HD 0x0ac3
> #define USB_DEVICE_ID_SYNAPTICS_QUAD_HD 0x1ac3
>
> +#define USB_VENDOR_ID_TEXAS_INSTRUMENTS 0x2047
> +#define USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA 0x0855
> +
> #define USB_VENDOR_ID_THINGM 0x27b8
> #define USB_DEVICE_ID_BLINK1 0x01ed
>
> diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> index 46f4480..597732b 100644
> --- a/drivers/hid/hid-sensor-hub.c
> +++ b/drivers/hid/hid-sensor-hub.c
> @@ -665,6 +665,9 @@ static const struct hid_device_id
> sensor_hub_devices[] = {
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_INTEL_1,
> USB_DEVICE_ID_INTEL_HID_SENSOR),
> .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> + { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB,
> USB_VENDOR_ID_TEXAS_INSTRUMENTS,
> + USB_DEVICE_ID_TEXAS_INSTRUMENTS_LENOVO_YOGA),
> + .driver_data = HID_SENSOR_HUB_ENUM_QUIRK},
> { HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
> HID_ANY_ID) },
> { }
>
>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Thanks,
Srinivas
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-05-05 23:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-06 20:57 [PATCH] iio:hid-sensor-hub: Add in quirk for sensor hub in Lenovo Ideapad Yogas Peter F. Patel-Schneider
2014-03-06 22:43 ` Srinivas Pandruvada
-- strict thread matches above, loose matches on Subject: below --
2014-05-05 22:55 Peter F. Patel-Schneider
2014-05-05 23:02 ` Jiri Kosina
2014-05-05 23:03 ` Srinivas Pandruvada
2014-03-05 0:17 Peter F. Patel-Schneider
2014-03-05 19:08 ` Srinivas Pandruvada
2014-03-06 9:57 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.