Let ath10k_err take 'ar' argument?

Let ath10k_err take 'ar' argument?

[Ben Greear]

I have two NICs in a system, and it died overnight (full host lockup).
Console shows this:

[root@ct523-9292 ~]# ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5
ath10k: target stalled
ath10k: failed to wait for target to init: -5


I was thinking of changing ath10k_err to take
'ar' as argument and then print out pci-id or some
other identifier so that we can tell which
NIC is having issues on systems with multiple NICs?

Any opinions on this before I get started?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Let ath10k_err take 'ar' argument?

[Kalle Valo]

Ben Greear <greearb@candelatech.com> writes:

> I have two NICs in a system, and it died overnight (full host lockup).
> Console shows this:
>
> [root@ct523-9292 ~]# ath10k: target stalled
> ath10k: failed to wait for target to init: -5
> ath10k: target stalled

Damn. Do you have anything before the target stalled message?

> I was thinking of changing ath10k_err to take
> 'ar' as argument and then print out pci-id or some
> other identifier so that we can tell which
> NIC is having issues on systems with multiple NICs?
>
> Any opinions on this before I get started?

I have been thinking exactly the same. I think we should add struct
ath10k to all of our logging and debugging macros. IIRC iwlwifi does
this already, you might want to check that first.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Let ath10k_err take 'ar' argument?

[Ben Greear]

On 03/06/2014 11:49 PM, Kalle Valo wrote:
> Ben Greear <greearb@candelatech.com> writes:
>
>> I have two NICs in a system, and it died overnight (full host lockup).
>> Console shows this:
>>
>> [root@ct523-9292 ~]# ath10k: target stalled
>> ath10k: failed to wait for target to init: -5
>> ath10k: target stalled
>
> Damn. Do you have anything before the target stalled message?

No, nothing useful.

I reproduced this on WLE900VX as well (and posted a week or so about it).

Well, the one above is from system with two different NICs (CUS223, WLE900VX)
so not sure exactly which one had the issue...

>> I was thinking of changing ath10k_err to take
>> 'ar' as argument and then print out pci-id or some
>> other identifier so that we can tell which
>> NIC is having issues on systems with multiple NICs?
>>
>> Any opinions on this before I get started?
>
> I have been thinking exactly the same. I think we should add struct
> ath10k to all of our logging and debugging macros. IIRC iwlwifi does
> this already, you might want to check that first.

I'll take a stab at it today if I can find time.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k