From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marcel Apfelbaum" <marcel.a@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com,
Alexey Kardashevskiy <aik@ozlabs.ru>,
armbru@redhat.com, lcapitulino@redhat.com, blauwirbel@gmail.com,
aliguori@amazon.com, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass
Date: Fri, 07 Mar 2014 17:27:26 +0100 [thread overview]
Message-ID: <5319F36E.2040603@redhat.com> (raw)
In-Reply-To: <1394209338.2663.51.camel@localhost.localdomain>
Il 07/03/2014 17:22, Marcel Apfelbaum ha scritto:
> There is a problem with it: 'make check fails' on test-qdev-global-props.
> - 'qdev_get_machine()' is called by 'device_set_realized()' because static_prop_type
> has TYPE_DEVICE as parent.
> - The machine is added to the QOM tree *only in vl's main* and this test does not
> reach it, but assumes that always will be a machine in the QOM tree.
> This is no longer true.
>
> Possible solution would be making existing 'null machine' a subclass of MachineClass
> and add it manually to QOM on this test(and other places as necessary). The risk here is
> that there are other places where the machine needs to be added manually to the QOM tree.
> (I am trying this option, but make check gets stuck !!!, debugging)
This is probably the right thing to do, but I guess it means it's better
to leave this series to 2.1.
Paolo
next prev parent reply other threads:[~2014-03-07 16:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 17:30 [Qemu-devel] [PATCH v3 0/3] qemu-machine as a QOM object Marcel Apfelbaum
2014-03-05 17:30 ` [Qemu-devel] [PATCH v3 1/3] hw/core: introduced qemu machine as " Marcel Apfelbaum
2014-03-06 22:43 ` Andreas Färber
2014-03-07 11:31 ` Andreas Färber
2014-03-05 17:30 ` [Qemu-devel] [PATCH v3 2/3] vl: use qemu machine QOM class instead of global machines list Marcel Apfelbaum
2014-03-06 22:55 ` Andreas Färber
2014-03-05 17:30 ` [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass Marcel Apfelbaum
2014-03-05 17:36 ` Eric Blake
2014-03-05 17:59 ` Marcel Apfelbaum
2014-03-06 23:44 ` Andreas Färber
2014-03-07 1:16 ` Alexey Kardashevskiy
2014-03-07 5:40 ` Marcel Apfelbaum
2014-03-07 5:32 ` Marcel Apfelbaum
2014-03-07 11:27 ` Andreas Färber
2014-03-07 16:22 ` Marcel Apfelbaum
2014-03-07 16:27 ` Paolo Bonzini [this message]
2014-03-07 17:30 ` Andreas Färber
2014-03-07 20:41 ` Marcel Apfelbaum
2014-03-11 15:44 ` Marcel Apfelbaum
2014-03-11 16:48 ` Andreas Färber
2014-03-11 19:28 ` Marcel Apfelbaum
2014-03-07 8:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5319F36E.2040603@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aik@ozlabs.ru \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.