[PATCH] spi/qspi: Fix return from mmap path

[PATCH] spi/qspi: Fix return from mmap path

[Sourav Poddar]

mmap resource requirement is only for memory mapped operations.
If the user does not populate mmap resource, dont call return,
instead we go on for normal spi mode operations.

Signed-off-by: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
---
 drivers/spi/spi-ti-qspi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 49ddfc7..6c211d1 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -461,7 +461,6 @@ static int ti_qspi_probe(struct platform_device *pdev)
 		if (res_mmap == NULL) {
 			dev_err(&pdev->dev,
 				"memory mapped resource not required\n");
-			return -ENODEV;
 		}
 	}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi/qspi: Fix return from mmap path

[sourav]

+ Mark's kernel.org email
On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:
> mmap resource requirement is only for memory mapped operations.
> If the user does not populate mmap resource, dont call return,
> instead we go on for normal spi mode operations.
>
> Signed-off-by: Sourav Poddar<sourav.poddar-l0cyMroinI0@public.gmane.org>
> ---
>   drivers/spi/spi-ti-qspi.c |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index 49ddfc7..6c211d1 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -461,7 +461,6 @@ static int ti_qspi_probe(struct platform_device *pdev)
>   		if (res_mmap == NULL) {
>   			dev_err(&pdev->dev,
>   				"memory mapped resource not required\n");
> -			return -ENODEV;
>   		}
>   	}
>

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi/qspi: Fix return from mmap path

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

On Mon, Mar 10, 2014 at 03:19:21PM +0530, sourav wrote:
> + Mark's kernel.org email
> On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:

None of the tools can apply patches that have been quoted...

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] spi/qspi: Fix return from mmap path

[sourav]

On Monday 10 March 2014 03:45 PM, Mark Brown wrote:
> On Mon, Mar 10, 2014 at 03:19:21PM +0530, sourav wrote:
>> + Mark's kernel.org email
>> On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:
> None of the tools can apply patches that have been quoted...
I am not sure whats happening. I will send you the new version.
--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi/qspi: Fix return from mmap path

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 528 bytes --]

On Mon, Mar 10, 2014 at 03:50:42PM +0530, sourav wrote:
> On Monday 10 March 2014 03:45 PM, Mark Brown wrote:
> >On Mon, Mar 10, 2014 at 03:19:21PM +0530, sourav wrote:
> >>+ Mark's kernel.org email
> >>On Monday 10 March 2014 02:59 PM, Sourav Poddar wrote:

> >None of the tools can apply patches that have been quoted...

> I am not sure whats happening. I will send you the new version.

What I'm saying is that if you got the address wrong CCing me into a
reply isn't going to help much since the quoting mangles the patch.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[PATCH] spi/qspi: Fix return from mmap path

[Sourav Poddar]

mmap resource requirement is only for memory mapped operations.
If the user does not populate mmap resource, dont call return,
instead we go on for normal spi mode operations.

Signed-off-by: Sourav Poddar <sourav.poddar-l0cyMroinI0@public.gmane.org>
---
 drivers/spi/spi-ti-qspi.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
index 49ddfc7..6c211d1 100644
--- a/drivers/spi/spi-ti-qspi.c
+++ b/drivers/spi/spi-ti-qspi.c
@@ -461,7 +461,6 @@ static int ti_qspi_probe(struct platform_device *pdev)
 		if (res_mmap == NULL) {
 			dev_err(&pdev->dev,
 				"memory mapped resource not required\n");
-			return -ENODEV;
 		}
 	}
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] spi/qspi: Fix return from mmap path

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 263 bytes --]

On Mon, Mar 10, 2014 at 04:00:42PM +0530, Sourav Poddar wrote:
> mmap resource requirement is only for memory mapped operations.
> If the user does not populate mmap resource, dont call return,
> instead we go on for normal spi mode operations.

Applied, thanks.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]