From: monstr@monstr.eu (Michal Simek)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] edac: zynq: Added EDAC support for zynq ddr ecc controller
Date: Mon, 10 Mar 2014 12:58:56 +0100 [thread overview]
Message-ID: <531DA900.5060202@monstr.eu> (raw)
In-Reply-To: <20140310105655.GH14999@e106331-lin.cambridge.arm.com>
On 03/10/2014 11:56 AM, Mark Rutland wrote:
> On Sun, Mar 09, 2014 at 02:57:16AM +0000, Punnaiah Choudary Kalluri wrote:
>> Added EDAC support for reporting the ecc errors of zynq ddr controller.
>> The ddr ecc controller corrects single bit errors and detects double bit
>> errors
>>
>> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
>> ---
>> .../devicetree/bindings/edac/zynq_edac.txt | 18 +
>> drivers/edac/Kconfig | 7 +
>> drivers/edac/Makefile | 1 +
>> drivers/edac/zynq_edac.c | 613 ++++++++++++++++++++
>> 4 files changed, 639 insertions(+), 0 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/edac/zynq_edac.txt
>> create mode 100644 drivers/edac/zynq_edac.c
>>
>> diff --git a/Documentation/devicetree/bindings/edac/zynq_edac.txt b/Documentation/devicetree/bindings/edac/zynq_edac.txt
>> new file mode 100644
>> index 0000000..c21ff83
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/edac/zynq_edac.txt
>> @@ -0,0 +1,18 @@
>> +Zynq EDAC driver, it does reports the DDR ECC single bit errors that are
>> +corrected and double bit ecc errors that are detected by the DDR ECC controller.
>> +ECC support for DDR is available in half-bus width(16 bit) configuration only.
>> +
>> +Required properties:
>> +- compatible: Should be "xlnx,ps7-ddrc" or "xlnx,ps7-ddrc-1.00.a"
>
> Is this an or or a xor?
Compatible string should be just xlnx,zynq-ddrc-1.00.a.
Nothing with ps7.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140310/e9df4092/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <monstr@monstr.eu>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Punnaiah Choudary Kalluri <punnaiah.choudary.kalluri@xilinx.com>,
"dougthompson@xmission.com" <dougthompson@xmission.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rob@landley.net" <rob@landley.net>,
"kpc528@gmail.com" <kpc528@gmail.com>,
"kalluripunnaiahchoudary@gmail.com"
<kalluripunnaiahchoudary@gmail.com>,
"punnaia@xilinx.com" <punnaia@xilinx.com>
Subject: Re: [RFC PATCH] edac: zynq: Added EDAC support for zynq ddr ecc controller
Date: Mon, 10 Mar 2014 12:58:56 +0100 [thread overview]
Message-ID: <531DA900.5060202@monstr.eu> (raw)
In-Reply-To: <20140310105655.GH14999@e106331-lin.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 1900 bytes --]
On 03/10/2014 11:56 AM, Mark Rutland wrote:
> On Sun, Mar 09, 2014 at 02:57:16AM +0000, Punnaiah Choudary Kalluri wrote:
>> Added EDAC support for reporting the ecc errors of zynq ddr controller.
>> The ddr ecc controller corrects single bit errors and detects double bit
>> errors
>>
>> Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
>> ---
>> .../devicetree/bindings/edac/zynq_edac.txt | 18 +
>> drivers/edac/Kconfig | 7 +
>> drivers/edac/Makefile | 1 +
>> drivers/edac/zynq_edac.c | 613 ++++++++++++++++++++
>> 4 files changed, 639 insertions(+), 0 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/edac/zynq_edac.txt
>> create mode 100644 drivers/edac/zynq_edac.c
>>
>> diff --git a/Documentation/devicetree/bindings/edac/zynq_edac.txt b/Documentation/devicetree/bindings/edac/zynq_edac.txt
>> new file mode 100644
>> index 0000000..c21ff83
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/edac/zynq_edac.txt
>> @@ -0,0 +1,18 @@
>> +Zynq EDAC driver, it does reports the DDR ECC single bit errors that are
>> +corrected and double bit ecc errors that are detected by the DDR ECC controller.
>> +ECC support for DDR is available in half-bus width(16 bit) configuration only.
>> +
>> +Required properties:
>> +- compatible: Should be "xlnx,ps7-ddrc" or "xlnx,ps7-ddrc-1.00.a"
>
> Is this an or or a xor?
Compatible string should be just xlnx,zynq-ddrc-1.00.a.
Nothing with ps7.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]
next prev parent reply other threads:[~2014-03-10 11:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 2:57 [RFC PATCH] edac: zynq: Added EDAC support for zynq ddr ecc controller Punnaiah Choudary Kalluri
2014-03-09 2:57 ` Punnaiah Choudary Kalluri
2014-03-09 2:57 ` Punnaiah Choudary Kalluri
2014-03-10 10:56 ` Mark Rutland
2014-03-10 10:56 ` Mark Rutland
2014-03-10 10:56 ` Mark Rutland
2014-03-10 11:58 ` Michal Simek [this message]
2014-03-10 11:58 ` Michal Simek
2014-03-10 22:32 ` Sören Brinkmann
2014-03-10 22:32 ` Sören Brinkmann
2014-03-10 22:32 ` Sören Brinkmann
2014-03-11 8:32 ` Michal Simek
2014-03-11 8:32 ` Michal Simek
2014-03-11 8:32 ` Michal Simek
2014-03-11 15:50 ` Sören Brinkmann
2014-03-11 15:50 ` Sören Brinkmann
2014-03-11 15:50 ` Sören Brinkmann
[not found] ` <20140311155057.GJ13293@xsjandreislx>
2014-03-12 10:27 ` Michal Simek
2014-03-12 10:27 ` Michal Simek
2014-03-12 10:27 ` Michal Simek
2014-03-12 16:13 ` Sören Brinkmann
2014-03-12 16:13 ` Sören Brinkmann
2014-03-12 16:13 ` Sören Brinkmann
[not found] ` <20140312161344.GA3000@xsjandreislx>
2014-03-12 16:50 ` Michal Simek
2014-03-12 16:50 ` Michal Simek
2014-03-12 16:50 ` Michal Simek
[not found] ` <53209047.8070308@xilinx.com>
2014-03-13 17:21 ` Punnaiah Choudary Kalluri
2014-03-13 17:21 ` Punnaiah Choudary Kalluri
2014-03-13 17:21 ` Punnaiah Choudary Kalluri
2014-03-11 7:25 ` Punnaiah Choudary Kalluri
2014-03-11 7:25 ` Punnaiah Choudary Kalluri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531DA900.5060202@monstr.eu \
--to=monstr@monstr.eu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.