From: Antti Palosaari <crope@iki.fi>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] rtl2832u_sdr: fixing v4l2-compliance issues
Date: Mon, 10 Mar 2014 17:29:12 +0200 [thread overview]
Message-ID: <531DDA48.9000702@iki.fi> (raw)
In-Reply-To: <5317B182.8050200@xs4all.nl>
Moikka Hans!
On 06.03.2014 01:21, Hans Verkuil wrote:
> Antti,
>
> Attached is a patch that fixed all but one v4l2-compliance error:
>
> fail: v4l2-test-controls.cpp(295): returned control value out of range
> fail: v4l2-test-controls.cpp(357): invalid control 00a2090c
> test VIDIOC_G/S_CTRL: FAIL
> fail: v4l2-test-controls.cpp(465): returned control value out of range
> fail: v4l2-test-controls.cpp(573): invalid control 00a2090c
> test VIDIOC_G/S/TRY_EXT_CTRLS: FAIL
>
> That's the BANDWIDTH control and it returned value 3200000 when the minimum was 6000000.
> I couldn't trace where that came from in the limited time I spent on it, I expect you
> can find it much quicker.
That is because I added native V4L2_CID_RF_TUNER_BANDWIDTH support only
for E4000 tuner driver. The others, FC0012, FC0013 and R820T are set via
DVB API by rtl2832_sdr driver, which is quite hackish solution. Devices
having E4000 works correctly.
Dunno if it wise to hack rtl2832_sdr and clamp values to valid per tuner
or leave it as it is. Adding V4L2_CID_RF_TUNER_BANDWIDTH to those 3
tuner drivers is also quite trivial...
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2014-03-10 15:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 23:21 [PATCH] rtl2832u_sdr: fixing v4l2-compliance issues Hans Verkuil
2014-03-10 10:36 ` Antti Palosaari
2014-03-10 15:29 ` Antti Palosaari [this message]
2014-03-10 15:36 ` Hans Verkuil
2014-03-10 15:40 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531DDA48.9000702@iki.fi \
--to=crope@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.