Re: [PATCH 5/5] ses: Use vpd information from scsi_device

[Hannes Reinecke <hare@suse.de>]

On 03/10/2014 07:20 PM, James Bottomley wrote:
> On Mon, 2014-03-10 at 15:28 +0100, Hannes Reinecke wrote:
>> The scsi_device now has VPD page83 information attached, so
>> there is no need to query it again.
>
> This is a bit new for a v8 patch, have you actually tested it?  I'm
> asking because it looks to me like the vpd attach is done just before
> the configure whereas the bindings are usually done in add.  I suspect
> this will work for ses because it's a device model binding rather than a
> transport class binding and the former occurs later, but knowing it
> actually all works would be useful.
>
Yes, correct. But the device_add() call is done in
scsi_sysfs_add_sdev(), which is done at the end of scsi_add_lun().
So that will be okay.

But nevertheless I'll be cross-checking.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html