Re: [PATCH 3/5] Add EVPD page 0x83 to sysfs

[Hannes Reinecke <hare@suse.de>]

On 03/10/2014 07:24 PM, James Bottomley wrote:
> On Mon, 2014-03-10 at 15:28 +0100, Hannes Reinecke wrote:
>> EVPD page 0x83 is used to uniquely identify the device.
>> So instead of having each and every program issue a separate
>> SG_IO call to retrieve this information it does make far more
>> sense to display it in sysfs.
>
> Christoph's suggestion of binary sysfs attributes for this rather than
> the text ones you have is better ... because your current ones are going
> to truncate when they run off the one page of data sysfs text attributes
> get (i.e. about 2k of vpd).
>
Yes, I thought of that, too.
I thought to remember that binary attributes are reserved for 
firmware/hardware-dependent interfaces.
If that's not the case I'll be moving to a binary attribute here.
Will be resending the patchset.

What should happen with the first patch in the series, then?
When moving to a binary attribute the first patch isn't required 
anymore; should I drop it or send as a separate patch?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html