From: Richard Henderson <rth@twiddle.net>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>,
qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
afaerber@suse.de, Fabien Chouteau <chouteau@adacore.com>
Subject: Re: [Qemu-devel] [PATCH v5] target-sparc: Add and use CPU_FEATURE_CASA
Date: Mon, 10 Mar 2014 13:48:19 -0700 [thread overview]
Message-ID: <531E2513.3060308@twiddle.net> (raw)
In-Reply-To: <531C4A43.1030309@embedded-brains.de>
On 03/09/2014 04:02 AM, Sebastian Huber wrote:
> #endif
> +#if !defined(CONFIG_USER_ONLY) || defined(TARGET_SPARC64)
> + case 0x3c: /* V9 or LEON3 casa */
> + CHECK_IU_FEATURE(dc, CASA);
> +#ifndef TARGET_SPARC64
> + if (IS_IMM) {
> + goto illegal_insn;
> + }
> + if (!supervisor(dc)) {
> + goto priv_insn;
> + }
> +#endif
> + rs2 = GET_FIELD(insn, 27, 31);
> + cpu_src2 = gen_load_gpr(dc, rs2);
> + gen_cas_asi(dc, cpu_addr, cpu_src2, insn, rd);
> + break;
> +#endif
Might as well put the feature check inside the ifndef sparc64,
since we know that sparc64 always has the feature.
Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
prev parent reply other threads:[~2014-03-10 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 11:02 [Qemu-devel] [PATCH v5] target-sparc: Add and use CPU_FEATURE_CASA Sebastian Huber
2014-03-09 21:57 ` Mark Cave-Ayland
2014-03-10 20:48 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531E2513.3060308@twiddle.net \
--to=rth@twiddle.net \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=chouteau@adacore.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=sebastian.huber@embedded-brains.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.