[PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

[PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

[Markos Chandras]

Fixes the following build problem with binutils-2.24

gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
In file included from bpf_jit_disasm.c:25:0:
/usr/include/bfd.h:35:2: error: #error config.h must be included
before this header
 #error config.h must be included before this header

This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
"perf tools: bfd.h/libbfd detection fails with recent binutils"

See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243

CC: David S. Miller <davem@davemloft.net>
CC: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
Changes since v1:
- Drop the 'bfd' word from the subject as requested by David Miller
---
 tools/net/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/net/Makefile b/tools/net/Makefile
index 004cd74..ee577ea 100644
--- a/tools/net/Makefile
+++ b/tools/net/Makefile
@@ -12,7 +12,7 @@ YACC = bison
 
 all : bpf_jit_disasm bpf_dbg bpf_asm
 
-bpf_jit_disasm : CFLAGS = -Wall -O2
+bpf_jit_disasm : CFLAGS = -Wall -O2 -DPACKAGE='bpf_jit_disasm'
 bpf_jit_disasm : LDLIBS = -lopcodes -lbfd -ldl
 bpf_jit_disasm : bpf_jit_disasm.o
 
-- 
1.9.0

Re: [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

[David Miller]

From: Markos Chandras <markos.chandras@imgtec.com>
Date: Mon, 10 Mar 2014 10:39:48 +0000

> Fixes the following build problem with binutils-2.24
> 
> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
> In file included from bpf_jit_disasm.c:25:0:
> /usr/include/bfd.h:35:2: error: #error config.h must be included
> before this header
>  #error config.h must be included before this header
> 
> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
> "perf tools: bfd.h/libbfd detection fails with recent binutils"
> 
> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
> 
> CC: David S. Miller <davem@davemloft.net>
> CC: Daniel Borkmann <dborkman@redhat.com>
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>

Please submit networking patches with netdev@vger.kernel.org at least
CC:'d so that such patches can be properly tracked in patchwork.

Thank you.

Re: [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

[Markos Chandras]

On 03/11/2014 01:53 AM, David Miller wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
> Date: Mon, 10 Mar 2014 10:39:48 +0000
>
>> Fixes the following build problem with binutils-2.24
>>
>> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
>> In file included from bpf_jit_disasm.c:25:0:
>> /usr/include/bfd.h:35:2: error: #error config.h must be included
>> before this header
>>   #error config.h must be included before this header
>>
>> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
>> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>>
>> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>>
>> CC: David S. Miller <davem@davemloft.net>
>> CC: Daniel Borkmann <dborkman@redhat.com>
>> Acked-by: Daniel Borkmann <dborkman@redhat.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
> Please submit networking patches with netdev@vger.kernel.org at least
> CC:'d so that such patches can be properly tracked in patchwork.
>
> Thank you.
>
Hi David,

Apologies. When I ran the scripts/get_maintainer.pl on my patch, 
netdev@vger.kernel.org was not listed there. I will send it again.

-- 
markos

[PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

[Markos Chandras]

Fixes the following build problem with binutils-2.24

gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
In file included from bpf_jit_disasm.c:25:0:
/usr/include/bfd.h:35:2: error: #error config.h must be included
before this header
 #error config.h must be included before this header

This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
"perf tools: bfd.h/libbfd detection fails with recent binutils"

See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243

CC: David S. Miller <davem@davemloft.net>
CC: Daniel Borkmann <dborkman@redhat.com>
CC: netdev@vger.kernel.org
Acked-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
Resend with netdev@vger.kernel.org on CC

Changes since v1:
- Drop the 'bfd' word from the subject as requested by David Miller
---
 tools/net/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/net/Makefile b/tools/net/Makefile
index 004cd74..ee577ea 100644
--- a/tools/net/Makefile
+++ b/tools/net/Makefile
@@ -12,7 +12,7 @@ YACC = bison
 
 all : bpf_jit_disasm bpf_dbg bpf_asm
 
-bpf_jit_disasm : CFLAGS = -Wall -O2
+bpf_jit_disasm : CFLAGS = -Wall -O2 -DPACKAGE='bpf_jit_disasm'
 bpf_jit_disasm : LDLIBS = -lopcodes -lbfd -ldl
 bpf_jit_disasm : bpf_jit_disasm.o
 
-- 
1.9.0

Re: [PATCH v2] tools/net/Makefile: Define PACKAGE to fix build problems

[David Miller]

From: Markos Chandras <markos.chandras@imgtec.com>
Date: Tue, 11 Mar 2014 08:49:39 +0000

> Fixes the following build problem with binutils-2.24
> 
> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
> In file included from bpf_jit_disasm.c:25:0:
> /usr/include/bfd.h:35:2: error: #error config.h must be included
> before this header
>  #error config.h must be included before this header
> 
> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
> "perf tools: bfd.h/libbfd detection fails with recent binutils"
> 
> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
> 
> CC: David S. Miller <davem@davemloft.net>
> CC: Daniel Borkmann <dborkman@redhat.com>
> CC: netdev@vger.kernel.org
> Acked-by: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>

Applied, thank you.