From: Peter Hurley <peter@hurleysoftware.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: serial core: crash / race condition on unbind
Date: Tue, 11 Mar 2014 11:49:56 +0000 [thread overview]
Message-ID: <531EF864.5020104@hurleysoftware.com> (raw)
In-Reply-To: <CAMuHMdUeUjuBe0tWpYBZqwqWT=euPAn6fwzmXMYCP573Q1BDXQ@mail.gmail.com>
On 03/11/2014 06:58 AM, Geert Uytterhoeven wrote:
> Hi Peter,
>
> On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley <peter@hurleysoftware.com> wrote:
>>>
>>> [...]
>>>
>>> /*
>>> * Indicate that there isn't a port here anymore.
>>> */
>>> uport->type = PORT_UNKNOWN;
>>>
>>> state->uart_port = NULL;
>>
>> How did this ever work?
>>
>> Detaching the ll driver from the tty port in this manner is not ok;
>> as you already note, it blows up if consoles are still running.
>
> No one unbinds serial drivers using serial_core, as all these drivers are
> for fixed hardware?
Yep, never tested until now :)
Do you need this to work?
> Hot-pluggable usb-serial doesn't use serial_core.
I guess none of the 8250 PCI adapters are hot-pluggable...
Regards,
Peter Hurley
WARNING: multiple messages have this Message-ID (diff)
From: Peter Hurley <peter@hurleysoftware.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: serial core: crash / race condition on unbind
Date: Tue, 11 Mar 2014 07:49:56 -0400 [thread overview]
Message-ID: <531EF864.5020104@hurleysoftware.com> (raw)
In-Reply-To: <CAMuHMdUeUjuBe0tWpYBZqwqWT=euPAn6fwzmXMYCP573Q1BDXQ@mail.gmail.com>
On 03/11/2014 06:58 AM, Geert Uytterhoeven wrote:
> Hi Peter,
>
> On Tue, Mar 11, 2014 at 4:14 AM, Peter Hurley <peter@hurleysoftware.com> wrote:
>>>
>>> [...]
>>>
>>> /*
>>> * Indicate that there isn't a port here anymore.
>>> */
>>> uport->type = PORT_UNKNOWN;
>>>
>>> state->uart_port = NULL;
>>
>> How did this ever work?
>>
>> Detaching the ll driver from the tty port in this manner is not ok;
>> as you already note, it blows up if consoles are still running.
>
> No one unbinds serial drivers using serial_core, as all these drivers are
> for fixed hardware?
Yep, never tested until now :)
Do you need this to work?
> Hot-pluggable usb-serial doesn't use serial_core.
I guess none of the 8250 PCI adapters are hot-pluggable...
Regards,
Peter Hurley
next prev parent reply other threads:[~2014-03-11 11:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 16:55 serial core: crash / race condition on unbind Geert Uytterhoeven
2014-03-07 16:55 ` Geert Uytterhoeven
2014-03-10 20:48 ` Geert Uytterhoeven
2014-03-10 20:48 ` Geert Uytterhoeven
2014-03-11 3:14 ` Peter Hurley
2014-03-11 3:14 ` Peter Hurley
2014-03-11 10:58 ` Geert Uytterhoeven
2014-03-11 10:58 ` Geert Uytterhoeven
2014-03-11 11:49 ` Peter Hurley [this message]
2014-03-11 11:49 ` Peter Hurley
2014-03-11 12:00 ` One Thousand Gnomes
2014-03-11 15:35 ` Geert Uytterhoeven
2014-03-11 15:35 ` Geert Uytterhoeven
2014-03-11 22:59 ` Peter Hurley
2014-03-11 22:59 ` Peter Hurley
2014-03-13 7:55 ` Geert Uytterhoeven
2014-03-13 7:55 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531EF864.5020104@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=geert@linux-m68k.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.