All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Mark Brown <broonie@kernel.org>, "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Mark Brown <broonie@linaro.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"rob.herring@linaro.org" <rob.herring@linaro.org>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] cpufreq: enable ARM drivers on arm64
Date: Tue, 11 Mar 2014 12:27:01 +0000	[thread overview]
Message-ID: <531F0115.4000109@arm.com> (raw)
In-Reply-To: <1393208877-15797-1-git-send-email-broonie@kernel.org>

Hi Mark,

Sorry for late response, looks like Rafael has pulled this change, but ...

On 24/02/14 02:27, Mark Brown wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq
> drivers. The power menu is needed for OPP support. At least on Calxeda
> systems, the same cpufreq driver is used for arm and arm64 based
> systems.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>   arch/arm64/Kconfig      | 8 ++++++++
>   drivers/cpufreq/Kconfig | 2 +-
>   2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index fea7b47..939e95a 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -327,6 +327,14 @@ source "drivers/cpuidle/Kconfig"
>
>   endmenu
>
> +menu "Power management options"
> +
> +source "kernel/power/Kconfig"
> +
> +source "drivers/cpufreq/Kconfig"
> +
> +endmenu
> +

Is this patch based on recent kernels ? If so, either it should have caused
conflicts or silently duplicated the entries. "Power management options" are
already present.

Also to be more consistent it with menu options, I would prefer this to be
placed under "CPU Power Management" like CPUIdle.

Regards,
Sudeep


WARNING: multiple messages have this Message-ID (diff)
From: sudeep.holla@arm.com (Sudeep Holla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: enable ARM drivers on arm64
Date: Tue, 11 Mar 2014 12:27:01 +0000	[thread overview]
Message-ID: <531F0115.4000109@arm.com> (raw)
In-Reply-To: <1393208877-15797-1-git-send-email-broonie@kernel.org>

Hi Mark,

Sorry for late response, looks like Rafael has pulled this change, but ...

On 24/02/14 02:27, Mark Brown wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> Enable cpufreq and power kconfig menus on arm64 along with arm cpufreq
> drivers. The power menu is needed for OPP support. At least on Calxeda
> systems, the same cpufreq driver is used for arm and arm64 based
> systems.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>   arch/arm64/Kconfig      | 8 ++++++++
>   drivers/cpufreq/Kconfig | 2 +-
>   2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index fea7b47..939e95a 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -327,6 +327,14 @@ source "drivers/cpuidle/Kconfig"
>
>   endmenu
>
> +menu "Power management options"
> +
> +source "kernel/power/Kconfig"
> +
> +source "drivers/cpufreq/Kconfig"
> +
> +endmenu
> +

Is this patch based on recent kernels ? If so, either it should have caused
conflicts or silently duplicated the entries. "Power management options" are
already present.

Also to be more consistent it with menu options, I would prefer this to be
placed under "CPU Power Management" like CPUIdle.

Regards,
Sudeep

  parent reply	other threads:[~2014-03-11 12:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-24  2:27 [PATCH] cpufreq: enable ARM drivers on arm64 Mark Brown
2014-02-24  2:27 ` Mark Brown
2014-03-02  0:03 ` Rafael J. Wysocki
2014-03-02  0:03   ` Rafael J. Wysocki
2014-03-11 12:27 ` Sudeep Holla [this message]
2014-03-11 12:27   ` Sudeep Holla
2014-03-11 12:53   ` Mark Brown
2014-03-11 12:53     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531F0115.4000109@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=broonie@kernel.org \
    --cc=broonie@linaro.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rob.herring@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.