Re: [Qemu-devel] [PATCH 02/10] migration: Add counters of updating the dirty bitmap

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]

On 03/11/2014 06:53 AM, arei.gonglei@huawei.com wrote:
> From: ChenLiang <chenliang88@huawei.com>
> 
> Add counters to log the times of updating the dirty bitmap.
> 
> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Wait - how did my Reviewed-by get here?  There is no [PATCHv2] in the
subject line to indicate that I reviewed an earlier revision. and the
only other mail I see from me in the archives with the same subject line
is here:
https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05143.html

where I made a comment, but did NOT give my signature on the patch.

Please follow http://wiki.qemu.org/Contribute/SubmitAPatch when using
Reviewed-by: tags and subject lines.  Otherwise, you are making life
harder for yourself and for reviewers.

> ---
>  arch_init.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch_init.c b/arch_init.c
> index 2ac68c2..37e4aa5 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -110,6 +110,23 @@ static bool mig_throttle_on;
>  static int dirty_rate_high_cnt;
>  static void check_guest_throttling(void);
>  
> +static uint64_t bitmap_sync_cnt;
> +/* the functions *_bitmap_sync_cnt only run in migrate thread */
> +static inline void reset_bitmap_sync_cnt(void)

Isn't static inline a bit much in a .c file?  You generally want inline
functions to appear in .h.  For this particular file, I think these
functions are overkill...

>  
> +    increase_bitmap_sync_cnt();

and that you could just directly write 'bitmap_sync_cnt++' here.

When you send v3, do NOT add my Reviewed-by yet, because I still want to
make sure that the new version is correct.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]