Re: [Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 856 bytes --]

On 03/11/2014 06:53 AM, arei.gonglei@huawei.com wrote:
> From: ChenLiang <chenliang88@huawei.com>
> 
> Rebuild the cache_is_cached function.
> 
> Signed-off-by: ChenLiang <chenliang88@huawei.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>

Once again, I did NOT give R-b in v1.

> ---
>  page_cache.c | 33 +++++++++++++++------------------
>  1 file changed, 15 insertions(+), 18 deletions(-)
> 

> +    if (it->it_addr == addr) {
> +        /* updata the it_age when the cache hit */

Furthermore, I made a review comment in v1 that you had a typo, but it
went unchanged in this version:

s/updata/update/

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]