All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Joe Perches <joe@perches.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Michal Kazior <michal.kazior@tieto.com>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: unify warning messages in mac.c
Date: Tue, 11 Mar 2014 10:56:15 -0700	[thread overview]
Message-ID: <531F4E3F.3020606@candelatech.com> (raw)
In-Reply-To: <1394559971.20021.1.camel@joe-AO722>

On 03/11/2014 10:46 AM, Joe Perches wrote:
> On Tue, 2014-03-11 at 10:37 -0700, Ben Greear wrote:
>> but I would also suggest giving user a clue as to the
>> severity.  Something starting with 'failed' or 'warning' is pretty obvious.
> 
> Isn't that the whole point of KERN_<LEVEL>?
> 
> I think duplicating it is pointless.

Normal users use dmesg or cat /var/log/messages.  The KERN_LEVEL is
not immediately obvious there (at least on my Fedora systems).

And either way, the driver may want to always show some interesting
thing and so put it at KERN_ERR when in fact is not a real error
that the user should be concerned about (think firmware version,
for instance)

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Joe Perches <joe@perches.com>
Cc: Kalle Valo <kvalo@qca.qualcomm.com>,
	Michal Kazior <michal.kazior@tieto.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: unify warning messages in mac.c
Date: Tue, 11 Mar 2014 10:56:15 -0700	[thread overview]
Message-ID: <531F4E3F.3020606@candelatech.com> (raw)
In-Reply-To: <1394559971.20021.1.camel@joe-AO722>

On 03/11/2014 10:46 AM, Joe Perches wrote:
> On Tue, 2014-03-11 at 10:37 -0700, Ben Greear wrote:
>> but I would also suggest giving user a clue as to the
>> severity.  Something starting with 'failed' or 'warning' is pretty obvious.
> 
> Isn't that the whole point of KERN_<LEVEL>?
> 
> I think duplicating it is pointless.

Normal users use dmesg or cat /var/log/messages.  The KERN_LEVEL is
not immediately obvious there (at least on my Fedora systems).

And either way, the driver may want to always show some interesting
thing and so put it at KERN_ERR when in fact is not a real error
that the user should be concerned about (think firmware version,
for instance)

Thanks,
Ben


-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2014-03-11 17:56 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 15:43 [PATCH] ath10k: unify warning messages in mac.c Kalle Valo
2014-03-03 15:43 ` Kalle Valo
2014-03-03 16:23 ` Michal Kazior
2014-03-03 16:23   ` Michal Kazior
2014-03-03 16:40   ` Kalle Valo
2014-03-03 16:40     ` Kalle Valo
2014-03-11 11:16     ` Kalle Valo
2014-03-11 11:16       ` Kalle Valo
2014-03-11 17:37       ` Ben Greear
2014-03-11 17:37         ` Ben Greear
2014-03-11 17:46         ` Joe Perches
2014-03-11 17:46           ` Joe Perches
2014-03-11 17:56           ` Ben Greear [this message]
2014-03-11 17:56             ` Ben Greear
2014-03-11 18:08             ` Joe Perches
2014-03-11 18:08               ` Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2014-03-24 15:00 Kalle Valo
2014-03-24 15:00 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531F4E3F.3020606@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=joe@perches.com \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.