[PATCH] irqchip: Silence sparse warning

[PATCH] irqchip: Silence sparse warning

[Stephen Boyd]

drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init'
was not declared. Should it be static?

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/irqchip/irqchip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c
index f496afce29de..3469141f10f6 100644
--- a/drivers/irqchip/irqchip.c
+++ b/drivers/irqchip/irqchip.c
@@ -10,6 +10,7 @@
 
 #include <linux/init.h>
 #include <linux/of_irq.h>
+#include <linux/irqchip.h>
 
 #include "irqchip.h"
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

[tip:irq/core] irqchip: Silence sparse warning

[tip-bot for Stephen Boyd]

Commit-ID:  559ba4b153acfbfe49007def9d0efc475d5f937c
Gitweb:     http://git.kernel.org/tip/559ba4b153acfbfe49007def9d0efc475d5f937c
Author:     Stephen Boyd <sboyd@codeaurora.org>
AuthorDate: Tue, 4 Mar 2014 17:01:21 -0800
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Thu, 6 Mar 2014 11:40:47 +0100

irqchip: Silence sparse warning

drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init'
was not declared. Should it be static?

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Cc: trivial@kernel.org
Link: http://lkml.kernel.org/r/1393981281-25553-1-git-send-email-sboyd@codeaurora.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irqchip.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c
index f496afc..3469141 100644
--- a/drivers/irqchip/irqchip.c
+++ b/drivers/irqchip/irqchip.c
@@ -10,6 +10,7 @@
 
 #include <linux/init.h>
 #include <linux/of_irq.h>
+#include <linux/irqchip.h>
 
 #include "irqchip.h"
 

Re: [PATCH] irqchip: Silence sparse warning

[Jiri Kosina]

On Tue, 4 Mar 2014, Stephen Boyd wrote:

> drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init'
> was not declared. Should it be static?
> 
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

Why do we have to have drivers/irqchip/irqchip.h and 
include/linux/irqchip.h anyway?

> ---
>  drivers/irqchip/irqchip.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c
> index f496afce29de..3469141f10f6 100644
> --- a/drivers/irqchip/irqchip.c
> +++ b/drivers/irqchip/irqchip.c
> @@ -10,6 +10,7 @@
>  
>  #include <linux/init.h>
>  #include <linux/of_irq.h>
> +#include <linux/irqchip.h>
>  
>  #include "irqchip.h"

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] irqchip: Silence sparse warning

[Stephen Boyd]

On 03/10/14 06:08, Jiri Kosina wrote:
> On Tue, 4 Mar 2014, Stephen Boyd wrote:
>
>> drivers/irqchip/irqchip.c:27:13: warning: symbol 'irqchip_init'
>> was not declared. Should it be static?
>>
>> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> Why do we have to have drivers/irqchip/irqchip.h and 
> include/linux/irqchip.h anyway?

include/linux/irqchip.h is for irqchip_init() which is typically called
from arch layers. drivers/irqchip/irqchip.h is for irqchip drivers to
include so they can use the IRQCHIP_DECLARE macro. Perhaps you're
pointing out that the "irqchip.h" include in irqchip.c is unused? How
about this patch?

----8<----

From: Stephen Boyd <sboyd@codeaurora.org>
Subject: [PATCH] irqchip: Remove unused include

The "irqchip.h" include here is not needed as the only thing in
irqchip.h is IRQCHIP_DECLARE which this file doesn't use. Drop
it.

Reported-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 drivers/irqchip/irqchip.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c
index 3469141f10f6..cad3e2495552 100644
--- a/drivers/irqchip/irqchip.c
+++ b/drivers/irqchip/irqchip.c
@@ -12,8 +12,6 @@
 #include <linux/of_irq.h>
 #include <linux/irqchip.h>
 
-#include "irqchip.h"
-
 /*
  * This special of_device_id is the sentinel at the end of the
  * of_device_id[] array of all irqchips. It is automatically placed at


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

[tip:irq/core] irqchip: Remove unused include

[tip-bot for Stephen Boyd]

Commit-ID:  1a75b8e64571a85d5e648cfdf4c40e0d9923abc5
Gitweb:     http://git.kernel.org/tip/1a75b8e64571a85d5e648cfdf4c40e0d9923abc5
Author:     Stephen Boyd <sboyd@codeaurora.org>
AuthorDate: Tue, 11 Mar 2014 13:51:49 -0700
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 12 Mar 2014 13:12:04 +0100

irqchip: Remove unused include

The "irqchip.h" include here is not needed as the only thing in
irqchip.h is IRQCHIP_DECLARE which this file doesn't use. Drop
it.

Reported-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Link: http://lkml.kernel.org/r/531F7765.40207@codeaurora.org
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/irqchip/irqchip.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/irqchip/irqchip.c b/drivers/irqchip/irqchip.c
index 3469141..cad3e24 100644
--- a/drivers/irqchip/irqchip.c
+++ b/drivers/irqchip/irqchip.c
@@ -12,8 +12,6 @@
 #include <linux/of_irq.h>
 #include <linux/irqchip.h>
 
-#include "irqchip.h"
-
 /*
  * This special of_device_id is the sentinel at the end of the
  * of_device_id[] array of all irqchips. It is automatically placed at