From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH for 3.14] ARM: at91: fix network interface ordering for sama5d36
Date: Wed, 12 Mar 2014 08:59:00 +0100 [thread overview]
Message-ID: <532013C4.1000107@atmel.com> (raw)
In-Reply-To: <366E83ED-36B1-469F-891C-5B0E8916D85A@jcrosoft.com>
On 11/03/2014 21:56, Jean-Christophe PLAGNIOL-VILLARD :
>
> On Mar 10, 2014, at 10:37 PM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> From: Boris BREZILLON <b.brezillon.dev@gmail.com>
>>
>> On the newly introduced sama5d36, Gigabit and 10/100 Ethernet network
>> interfaces are probed in a different order than for the sama5d35.
>> Moreover, users are accustomed to this order in bootloaders and backports
>> for older kernel revisions.
>> So this patch switches DT node order as it is done for the other dual-Ethernet
>> sama5d3 SoC.
>> Better interface numbering which does not depend on DT node order is being
>> developed for stronger interface identification.
>
> twick ethernet enumerating by playing on the DT order is week
Absolutely, that is what I said in the commit message.
> It?s better to introduce a new property
>
> linux,ethernet-id or something like or simply rely on other information on the userspace to identify the
> proper interface
We will rely on the alias number ; It's its purpose, after all. I think
that Boris already have a preliminary patch for the macb driver.
Bye,
> Nicolas for AT91 keep me in Cc
>
> Best Regards,
> J.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> Olof, Arnd and Kevin,
>>
>> I would like to include this fix in 3.14-final.
>> I do not have anymore patch for an at91-3.14-fixes branch so I only send this
>> single patch to you. Can you still take it?
>>
>> Thanks, best regards,
>>
>> arch/arm/boot/dts/sama5d36.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d36.dtsi b/arch/arm/boot/dts/sama5d36.dtsi
>> index 6c31c26e6cc0..db58cad6acd3 100644
>> --- a/arch/arm/boot/dts/sama5d36.dtsi
>> +++ b/arch/arm/boot/dts/sama5d36.dtsi
>> @@ -8,8 +8,8 @@
>> */
>> #include "sama5d3.dtsi"
>> #include "sama5d3_can.dtsi"
>> -#include "sama5d3_emac.dtsi"
>> #include "sama5d3_gmac.dtsi"
>> +#include "sama5d3_emac.dtsi"
>> #include "sama5d3_lcd.dtsi"
>> #include "sama5d3_mci2.dtsi"
>> #include "sama5d3_tcb1.dtsi"
>> --
>> 1.8.2.2
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: "<linux-arm-kernel@lists.infradead.org> mailing list"
<linux-arm-kernel@lists.infradead.org>,
Olof Johansson <olof@lixom.net>, "Arnd Bergmann" <arnd@arndb.de>,
ARM Maintainers <arm@kernel.org>,
Boris BREZILLON <b.brezillon.dev@gmail.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Boris BREZILLON <b.brezillon@overkiz.com>
Subject: Re: [PATCH for 3.14] ARM: at91: fix network interface ordering for sama5d36
Date: Wed, 12 Mar 2014 08:59:00 +0100 [thread overview]
Message-ID: <532013C4.1000107@atmel.com> (raw)
In-Reply-To: <366E83ED-36B1-469F-891C-5B0E8916D85A@jcrosoft.com>
On 11/03/2014 21:56, Jean-Christophe PLAGNIOL-VILLARD :
>
> On Mar 10, 2014, at 10:37 PM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
>
>> From: Boris BREZILLON <b.brezillon.dev@gmail.com>
>>
>> On the newly introduced sama5d36, Gigabit and 10/100 Ethernet network
>> interfaces are probed in a different order than for the sama5d35.
>> Moreover, users are accustomed to this order in bootloaders and backports
>> for older kernel revisions.
>> So this patch switches DT node order as it is done for the other dual-Ethernet
>> sama5d3 SoC.
>> Better interface numbering which does not depend on DT node order is being
>> developed for stronger interface identification.
>
> twick ethernet enumerating by playing on the DT order is week
Absolutely, that is what I said in the commit message.
> It’s better to introduce a new property
>
> linux,ethernet-id or something like or simply rely on other information on the userspace to identify the
> proper interface
We will rely on the alias number ; It's its purpose, after all. I think
that Boris already have a preliminary patch for the macb driver.
Bye,
> Nicolas for AT91 keep me in Cc
>
> Best Regards,
> J.
>>
>> Signed-off-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
>> ---
>> Olof, Arnd and Kevin,
>>
>> I would like to include this fix in 3.14-final.
>> I do not have anymore patch for an at91-3.14-fixes branch so I only send this
>> single patch to you. Can you still take it?
>>
>> Thanks, best regards,
>>
>> arch/arm/boot/dts/sama5d36.dtsi | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/sama5d36.dtsi b/arch/arm/boot/dts/sama5d36.dtsi
>> index 6c31c26e6cc0..db58cad6acd3 100644
>> --- a/arch/arm/boot/dts/sama5d36.dtsi
>> +++ b/arch/arm/boot/dts/sama5d36.dtsi
>> @@ -8,8 +8,8 @@
>> */
>> #include "sama5d3.dtsi"
>> #include "sama5d3_can.dtsi"
>> -#include "sama5d3_emac.dtsi"
>> #include "sama5d3_gmac.dtsi"
>> +#include "sama5d3_emac.dtsi"
>> #include "sama5d3_lcd.dtsi"
>> #include "sama5d3_mci2.dtsi"
>> #include "sama5d3_tcb1.dtsi"
>> --
>> 1.8.2.2
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-03-12 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 14:37 [PATCH for 3.14] ARM: at91: fix network interface ordering for sama5d36 Nicolas Ferre
2014-03-10 14:37 ` Nicolas Ferre
2014-03-11 19:49 ` Olof Johansson
2014-03-11 19:49 ` Olof Johansson
2014-03-11 20:56 ` Jean-Christophe PLAGNIOL-VILLARD
2014-03-11 20:56 ` Jean-Christophe PLAGNIOL-VILLARD
2014-03-12 7:59 ` Nicolas Ferre [this message]
2014-03-12 7:59 ` Nicolas Ferre
2014-03-12 10:30 ` [PATCH] net: macb: set interface name based on DT aliases Boris BREZILLON
2014-03-12 10:30 ` Boris BREZILLON
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532013C4.1000107@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.