From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Stefan Weil <sw@weilnetz.de>, Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] target-m68k: Remove custom qemu_assert() function
Date: Wed, 12 Mar 2014 15:18:45 +0100 [thread overview]
Message-ID: <53206CC5.6040902@suse.de> (raw)
In-Reply-To: <CAFEAcA9Le87gpzh-5cBtZVzYS05VfvKSnXZDuVRDC3XYUKiD=w@mail.gmail.com>
Am 12.03.2014 15:15, schrieb Peter Maydell:
> On 12 March 2014 13:24, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Remove the custom qemu_assert() function defined by target-m68k/translate.c
>> in favour of either using glib g_assert_not_reached() (for the genuinely
>> can't-happen cases) or cpu_abort() (for the "this isn't implemented",
>> in line with other unimplemented cases in the target).
>>
>> This has the benefit of silencing some clang warnings about
>> variables used while uninitialized (which are emitted because
>> clang can't figure out that qemu_assert(0, something) never
>> returns.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Andreas pointed out that we've had one attempt to fix this
> late last year:
> http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg02177.html
> which didn't work because hw_assert() is not present in user-mode
> compiles. This version of the patch doesn't suffer from that issue.
Reviewed-by: Andreas Färber <afaerber@suse.de>
Looks fine then, except that cpu_abort() will conflict with my series.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Stefan Weil <sw@weilnetz.de>, Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] target-m68k: Remove custom qemu_assert() function
Date: Wed, 12 Mar 2014 15:18:45 +0100 [thread overview]
Message-ID: <53206CC5.6040902@suse.de> (raw)
In-Reply-To: <CAFEAcA9Le87gpzh-5cBtZVzYS05VfvKSnXZDuVRDC3XYUKiD=w@mail.gmail.com>
Am 12.03.2014 15:15, schrieb Peter Maydell:
> On 12 March 2014 13:24, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Remove the custom qemu_assert() function defined by target-m68k/translate.c
>> in favour of either using glib g_assert_not_reached() (for the genuinely
>> can't-happen cases) or cpu_abort() (for the "this isn't implemented",
>> in line with other unimplemented cases in the target).
>>
>> This has the benefit of silencing some clang warnings about
>> variables used while uninitialized (which are emitted because
>> clang can't figure out that qemu_assert(0, something) never
>> returns.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>
> Andreas pointed out that we've had one attempt to fix this
> late last year:
> http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg02177.html
> which didn't work because hw_assert() is not present in user-mode
> compiles. This version of the patch doesn't suffer from that issue.
Reviewed-by: Andreas Färber <afaerber@suse.de>
Looks fine then, except that cpu_abort() will conflict with my series.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-12 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 13:24 [Qemu-trivial] [PATCH] target-m68k: Remove custom qemu_assert() function Peter Maydell
2014-03-12 13:24 ` [Qemu-devel] " Peter Maydell
2014-03-12 14:15 ` [Qemu-trivial] " Peter Maydell
2014-03-12 14:15 ` Peter Maydell
2014-03-12 14:18 ` Andreas Färber [this message]
2014-03-12 14:18 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53206CC5.6040902@suse.de \
--to=afaerber@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.