From: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
To: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: balbi-l0cyMroinI0@public.gmane.org,
kishon-l0cyMroinI0@public.gmane.org,
rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue
Date: Thu, 13 Mar 2014 14:17:09 +0200 [thread overview]
Message-ID: <5321A1C5.8020501@ti.com> (raw)
In-Reply-To: <53219970.6060002-l0cyMroinI0@public.gmane.org>
On 03/13/2014 01:41 PM, George Cherian wrote:
> On 3/13/2014 4:02 PM, Roger Quadros wrote:
>> Hi George,
>>
>> On 03/07/2014 01:56 PM, George Cherian wrote:
>>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
>>>
>>> Signed-off-by: George Cherian <george.cherian-l0cyMroinI0@public.gmane.org>
>>> ---
>>> Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> index 38b2fae..38d9bb8 100644
>>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> @@ -44,7 +44,9 @@ Board specific device node entry
>>> };
>>> OMAP DWC3 GLUE
>>> - - compatible : Should be "ti,dwc3"
>>> + - compatible : Should be
>>> + * "ti,dwc3" for OMAP5 and DRA7
>>> + * "ti,am437x-dwc3" for AM437x
>> Why do you need a new compatible for am437x? Isn't "ti,dwc3" sufficient?
>
> There is change in register offsets for AM437x as comapred to Omap5 and dra7x.
> The compatible is already added in dwc3-omap.c This patch just updates the Documentation.
Oh ok. Then it is fine. You can add my.
Acked-by: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
cheers,
-roger
>>
>>> - ti,hwmods : Should be "usb_otg_ss"
>>> - reg : Address and length of the register set for the device.
>>> - interrupts : The irq number of this device that is used to interrupt the
>>>
>> cheers,
>> -roger
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: George Cherian <george.cherian@ti.com>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>
Cc: <balbi@ti.com>, <kishon@ti.com>, <rob@landley.net>,
<galak@codeaurora.org>, <ijc+devicetree@hellion.org.uk>,
<mark.rutland@arm.com>, <pawel.moll@arm.com>,
<robh+dt@kernel.org>, <tony@atomide.com>,
<anatol.pomozov@gmail.com>, <bcousson@baylibre.com>
Subject: Re: [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue
Date: Thu, 13 Mar 2014 14:17:09 +0200 [thread overview]
Message-ID: <5321A1C5.8020501@ti.com> (raw)
In-Reply-To: <53219970.6060002@ti.com>
On 03/13/2014 01:41 PM, George Cherian wrote:
> On 3/13/2014 4:02 PM, Roger Quadros wrote:
>> Hi George,
>>
>> On 03/07/2014 01:56 PM, George Cherian wrote:
>>> Add the compatible "ti,am437x-dwc3" for dwc3 glue driver.
>>>
>>> Signed-off-by: George Cherian <george.cherian@ti.com>
>>> ---
>>> Documentation/devicetree/bindings/usb/omap-usb.txt | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/omap-usb.txt b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> index 38b2fae..38d9bb8 100644
>>> --- a/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> +++ b/Documentation/devicetree/bindings/usb/omap-usb.txt
>>> @@ -44,7 +44,9 @@ Board specific device node entry
>>> };
>>> OMAP DWC3 GLUE
>>> - - compatible : Should be "ti,dwc3"
>>> + - compatible : Should be
>>> + * "ti,dwc3" for OMAP5 and DRA7
>>> + * "ti,am437x-dwc3" for AM437x
>> Why do you need a new compatible for am437x? Isn't "ti,dwc3" sufficient?
>
> There is change in register offsets for AM437x as comapred to Omap5 and dra7x.
> The compatible is already added in dwc3-omap.c This patch just updates the Documentation.
Oh ok. Then it is fine. You can add my.
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
>>
>>> - ti,hwmods : Should be "usb_otg_ss"
>>> - reg : Address and length of the register set for the device.
>>> - interrupts : The irq number of this device that is used to interrupt the
>>>
>> cheers,
>> -roger
>
>
next prev parent reply other threads:[~2014-03-13 12:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 11:56 [PATCH v3 0/5] Add USB nodes for am43xx epos and gp evm George Cherian
2014-03-07 11:56 ` George Cherian
2014-03-07 11:56 ` [PATCH v3 1/5] doc: Add "ti,am437x-dwc3" comaptible for dwc3 glue George Cherian
2014-03-07 11:56 ` George Cherian
2014-03-13 10:32 ` Roger Quadros
2014-03-13 10:32 ` Roger Quadros
[not found] ` <53218944.7000102-l0cyMroinI0@public.gmane.org>
2014-03-13 11:41 ` George Cherian
2014-03-13 11:41 ` George Cherian
[not found] ` <53219970.6060002-l0cyMroinI0@public.gmane.org>
2014-03-13 12:17 ` Roger Quadros [this message]
2014-03-13 12:17 ` Roger Quadros
2014-03-07 11:56 ` [PATCH v3 2/5] ARM: dts: am43xx clock data George Cherian
2014-03-07 11:56 ` George Cherian
2014-03-13 10:35 ` Roger Quadros
2014-03-13 10:35 ` Roger Quadros
2014-03-13 12:14 ` George Cherian
2014-03-13 12:14 ` George Cherian
2014-03-07 11:57 ` [PATCH v3 3/5] ARM: dts: AM4372: Add USB nodes George Cherian
2014-03-07 11:57 ` George Cherian
[not found] ` <1394193422-18242-4-git-send-email-george.cherian-l0cyMroinI0@public.gmane.org>
2014-03-13 10:37 ` Roger Quadros
2014-03-13 10:37 ` Roger Quadros
2014-03-07 11:57 ` [PATCH v3 4/5] ARM: dts: am437x-gp-evm: Enable USB George Cherian
2014-03-07 11:57 ` George Cherian
[not found] ` <1394193422-18242-5-git-send-email-george.cherian-l0cyMroinI0@public.gmane.org>
2014-03-13 10:37 ` Roger Quadros
2014-03-13 10:37 ` Roger Quadros
2014-03-07 11:57 ` [PATCH v3 5/5] ARM: dts: am43x-epos-evm: " George Cherian
2014-03-07 11:57 ` George Cherian
2014-03-13 10:39 ` Roger Quadros
2014-03-13 10:39 ` Roger Quadros
2014-03-12 4:59 ` [PATCH v3 0/5] Add USB nodes for am43xx epos and gp evm George Cherian
2014-03-12 4:59 ` George Cherian
2014-03-12 17:50 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321A1C5.8020501@ti.com \
--to=rogerq-l0cymroini0@public.gmane.org \
--cc=anatol.pomozov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=george.cherian-l0cyMroinI0@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kishon-l0cyMroinI0@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rob-VoJi6FS/r0vR7s880joybQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.