From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions
Date: Thu, 13 Mar 2014 13:31:43 +0100 [thread overview]
Message-ID: <5321A52F.402@suse.de> (raw)
In-Reply-To: <1394710307-13187-1-git-send-email-peter.maydell@linaro.org>
Am 13.03.2014 12:31, schrieb Peter Maydell:
> Older versions of gcc (eg 4.6) can't handle varargs functions declared
> inline for anything other than completely trivial uses, and complain:
>
> tests/qom-test.c: In function 'qmp': tests/libqtest.h:359:60: sorry,
> unimplemented: function 'qmp' can never be inlined because it uses
> variable argument lists
>
> Avoid this problem by putting the functions into libqtest.c instead
> of using inline definitions in libqtest.h.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Feel free to go ahead with this.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-13 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 11:31 [Qemu-devel] [PATCH] libqtest: Avoid inline varargs functions Peter Maydell
2014-03-13 12:31 ` Andreas Färber [this message]
2014-03-13 12:35 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321A52F.402@suse.de \
--to=afaerber@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.