From: Keir Fraser <keir.xen@gmail.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Keir Fraser <keir@xen.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 5/5] xen/x86_emulate: Shuffle use of __attribute__((packed))
Date: Thu, 13 Mar 2014 16:08:13 +0000 [thread overview]
Message-ID: <5321D7ED.5070309@gmail.com> (raw)
In-Reply-To: <1394723060-24158-6-git-send-email-andrew.cooper3@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]
Andrew Cooper wrote:
>
> Also include #defines for the test code to allow compilation.
>
> Signed-off-by: Andrew Cooper<andrew.cooper3@citrix.com>
> CC: Keir Fraser<keir@xen.org>
> CC: Jan Beulich<JBeulich@suse.com>
> CC: Ian Campbell<Ian.Campbell@citrix.com>
> CC: Ian Jackson<Ian.Jackson@eu.citrix.com>
>
> ---
>
> I have mixed thoughts about this, which is why it is explicit
> separated from
> the rest of the series. On the one hand, consistency is good but on the
> other, it makes x86_emulate harder to use as a dropin in other code.
We already have a bunch of external definitions that must be provided
for x86_emulate.c. This merely adds another, but which is required for
x86_emulate.h. So it's perfectly fine by me.
Acked-by: Keir Fraser <keir@xen.org>
[-- Attachment #1.2: Type: text/html, Size: 1007 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-03-13 16:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 15:04 [PATCH v2 0/5] Improvements to the use of __attribute__((packed)) Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 1/5] xen/misc: Functional cleanup for __attribute__((packed)) changes Andrew Cooper
2014-03-13 16:22 ` Jan Beulich
2014-03-13 16:30 ` Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 2/5] xen/common: Shuffle use of __attribute__((packed)) Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 3/5] xen/x86: " Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 4/5] xen/arm: " Andrew Cooper
2014-03-13 15:04 ` [PATCH v2 5/5] xen/x86_emulate: " Andrew Cooper
2014-03-13 16:08 ` Keir Fraser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321D7ED.5070309@gmail.com \
--to=keir.xen@gmail.com \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.