All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] misc: Fix typos in comments
Date: Fri, 14 Mar 2014 20:25:44 +0400	[thread overview]
Message-ID: <53232D88.1000302@msgid.tls.msk.ru> (raw)
In-Reply-To: <531A18AC.20808@suse.de>

07.03.2014 23:06, Andreas Färber wrote:
> Am 07.03.2014 19:48, schrieb Stefan Weil:
[]
>>      if (flags & FCB_TX_IP && flags & FCB_TX_CIP) {
>> -        /* do IP4 checksum (TODO This funtion does TCP/UDP checksum but not sure
>> -         * if it also does IP4 checksum. */
>> +        /* do IP4 checksum (TODO This function does TCP/UDP checksum
>> +         * but not sure if it also does IP4 checksum. */
> 
> While rebreaking it, you could've also added the missing parenthesis,
> after the dot I guess. Apart from that,

Actually, that's a fun comment.  "do IP4 checksum, but unsure if it also does IP4 checksum".
Ie, do something but I'm not sure if it actually does that... ;)

Applied to -trivial, fixing both the commit comment and this parenthesis.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-trivial@nongnu.org, Stefan Weil <sw@weilnetz.de>,
	Alexander Graf <agraf@suse.de>,
	qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] misc: Fix typos in comments
Date: Fri, 14 Mar 2014 20:25:44 +0400	[thread overview]
Message-ID: <53232D88.1000302@msgid.tls.msk.ru> (raw)
In-Reply-To: <531A18AC.20808@suse.de>

07.03.2014 23:06, Andreas Färber wrote:
> Am 07.03.2014 19:48, schrieb Stefan Weil:
[]
>>      if (flags & FCB_TX_IP && flags & FCB_TX_CIP) {
>> -        /* do IP4 checksum (TODO This funtion does TCP/UDP checksum but not sure
>> -         * if it also does IP4 checksum. */
>> +        /* do IP4 checksum (TODO This function does TCP/UDP checksum
>> +         * but not sure if it also does IP4 checksum. */
> 
> While rebreaking it, you could've also added the missing parenthesis,
> after the dot I guess. Apart from that,

Actually, that's a fun comment.  "do IP4 checksum, but unsure if it also does IP4 checksum".
Ie, do something but I'm not sure if it actually does that... ;)

Applied to -trivial, fixing both the commit comment and this parenthesis.

Thanks,

/mjt

  reply	other threads:[~2014-03-14 16:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 18:48 [Qemu-trivial] [PATCH] misc: Fix typos in comments Stefan Weil
2014-03-07 18:48 ` [Qemu-devel] " Stefan Weil
2014-03-07 19:06 ` [Qemu-trivial] " Andreas Färber
2014-03-07 19:06   ` Andreas Färber
2014-03-14 16:25   ` Michael Tokarev [this message]
2014-03-14 16:25     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53232D88.1000302@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.