From: Tomasz Figa <t.figa@samsung.com>
To: Yuvaraj Kumar <yuvaraj.cd@gmail.com>,
"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-doc@vger.kernel.org
Cc: Grant Likely <grant.likely@linaro.org>,
Jingoo Han <jg1.han@samsung.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Mark Rutland <mark.rutland@arm.com>,
sunil joshi <joshi@samsung.com>,
"ks.giri@samsung.com" <ks.giri@samsung.com>,
thomas.ab@samsung.com, Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
Subject: Re: [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250
Date: Fri, 14 Mar 2014 18:18:35 +0100 [thread overview]
Message-ID: <532339EB.5090304@samsung.com> (raw)
In-Reply-To: <CAKuRcO+vudiKC1SRGMWgb3Ec0-JrVNeCxM5g5eTNR3OnQmmMTQ@mail.gmail.com>
Hi Yuvaraj,
On 14.03.2014 09:26, Yuvaraj Kumar wrote:
> Any comments on this?
>
> On Mon, Mar 3, 2014 at 4:45 PM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
>> Commit 275dcd2 "ARM: dts: add max77686 pmic node for smdk5250" added
>> required LDO's for SMDK5250 boards.Currently LDO10 is turned off.As LDO10,
>> enable/disable the LDO22 which is required for VDDQ_MMC2_AP.So this patch
>> makes LDO10 turn's on always.
This does not seem right to me. Why a regulator used by MMC should be
always enabled? Shouldn't it be specified as one of the MMC regulators
in corresponding MMC controller node?
Best regards,
Tomasz
prev parent reply other threads:[~2014-03-14 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 11:15 [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250 Yuvaraj Kumar C D
2014-03-14 8:26 ` Yuvaraj Kumar
2014-03-14 17:18 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532339EB.5090304@samsung.com \
--to=t.figa@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jg1.han@samsung.com \
--cc=joshi@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=ks.giri@samsung.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=swarren@wwwdotorg.org \
--cc=thomas.ab@samsung.com \
--cc=yuvaraj.cd@gmail.com \
--cc=yuvaraj.cd@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.