* [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250
@ 2014-03-03 11:15 Yuvaraj Kumar C D
2014-03-14 8:26 ` Yuvaraj Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Yuvaraj Kumar C D @ 2014-03-03 11:15 UTC (permalink / raw)
To: kgene.kim, linux-kernel, devicetree, linux-doc
Cc: grant.likely, t.figa, jg1.han, swarren, mark.rutland, joshi,
ks.giri, thomas.ab, Yuvaraj Kumar C D
Commit 275dcd2 "ARM: dts: add max77686 pmic node for smdk5250" added
required LDO's for SMDK5250 boards.Currently LDO10 is turned off.As LDO10,
enable/disable the LDO22 which is required for VDDQ_MMC2_AP.So this patch
makes LDO10 turn's on always.
Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
---
arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index f76946e..27a33d7 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -103,6 +103,7 @@
regulator-name = "P1.8V_LDO_OUT10";
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
+ regulator-always-on;
};
ldo11_reg: LDO11 {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250
2014-03-03 11:15 [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250 Yuvaraj Kumar C D
@ 2014-03-14 8:26 ` Yuvaraj Kumar
2014-03-14 17:18 ` Tomasz Figa
0 siblings, 1 reply; 3+ messages in thread
From: Yuvaraj Kumar @ 2014-03-14 8:26 UTC (permalink / raw)
To: kgene.kim@samsung.com, linux-kernel, devicetree@vger.kernel.org,
linux-doc
Cc: Grant Likely, Tomasz Figa, Jingoo Han, Stephen Warren,
Mark Rutland, sunil joshi, ks.giri@samsung.com, thomas.ab,
Yuvaraj Kumar C D
Any comments on this?
On Mon, Mar 3, 2014 at 4:45 PM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
> Commit 275dcd2 "ARM: dts: add max77686 pmic node for smdk5250" added
> required LDO's for SMDK5250 boards.Currently LDO10 is turned off.As LDO10,
> enable/disable the LDO22 which is required for VDDQ_MMC2_AP.So this patch
> makes LDO10 turn's on always.
>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index f76946e..27a33d7 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -103,6 +103,7 @@
> regulator-name = "P1.8V_LDO_OUT10";
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> };
>
> ldo11_reg: LDO11 {
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250
2014-03-14 8:26 ` Yuvaraj Kumar
@ 2014-03-14 17:18 ` Tomasz Figa
0 siblings, 0 replies; 3+ messages in thread
From: Tomasz Figa @ 2014-03-14 17:18 UTC (permalink / raw)
To: Yuvaraj Kumar, kgene.kim@samsung.com, linux-kernel,
devicetree@vger.kernel.org, linux-doc
Cc: Grant Likely, Jingoo Han, Stephen Warren, Mark Rutland,
sunil joshi, ks.giri@samsung.com, thomas.ab, Yuvaraj Kumar C D
Hi Yuvaraj,
On 14.03.2014 09:26, Yuvaraj Kumar wrote:
> Any comments on this?
>
> On Mon, Mar 3, 2014 at 4:45 PM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
>> Commit 275dcd2 "ARM: dts: add max77686 pmic node for smdk5250" added
>> required LDO's for SMDK5250 boards.Currently LDO10 is turned off.As LDO10,
>> enable/disable the LDO22 which is required for VDDQ_MMC2_AP.So this patch
>> makes LDO10 turn's on always.
This does not seem right to me. Why a regulator used by MMC should be
always enabled? Shouldn't it be specified as one of the MMC regulators
in corresponding MMC controller node?
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-14 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-03 11:15 [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250 Yuvaraj Kumar C D
2014-03-14 8:26 ` Yuvaraj Kumar
2014-03-14 17:18 ` Tomasz Figa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.