All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
	pbonzini@redhat.com, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-trivial] [PATCH] FSL eTSEC: Fix typo in rx ring
Date: Fri, 14 Mar 2014 21:35:11 +0400	[thread overview]
Message-ID: <53233DCF.3010706@msgid.tls.msk.ru> (raw)
In-Reply-To: <1394815901-7153-1-git-send-email-chouteau@adacore.com>

14.03.2014 20:51, Fabien Chouteau wrote:

>  hw/net/fsl_etsec/rings.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index 7760272..31e6f58 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -592,7 +592,7 @@ void etsec_walk_rx_ring(eTSEC *etsec, int ring_nbr)
>  
>                  /* TODO: Broadcast and Multicast */
>  
> -                if (bd.flags | BD_INTERRUPT) {
> +                if (bd.flags & BD_INTERRUPT) {
>                      /* Set RXFx */
[..etc..]

Hm.  Has this code _ever_ worked?? :(

Thanks, applied to -trivial.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
	pbonzini@redhat.com, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] FSL eTSEC: Fix typo in rx ring
Date: Fri, 14 Mar 2014 21:35:11 +0400	[thread overview]
Message-ID: <53233DCF.3010706@msgid.tls.msk.ru> (raw)
In-Reply-To: <1394815901-7153-1-git-send-email-chouteau@adacore.com>

14.03.2014 20:51, Fabien Chouteau wrote:

>  hw/net/fsl_etsec/rings.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/net/fsl_etsec/rings.c b/hw/net/fsl_etsec/rings.c
> index 7760272..31e6f58 100644
> --- a/hw/net/fsl_etsec/rings.c
> +++ b/hw/net/fsl_etsec/rings.c
> @@ -592,7 +592,7 @@ void etsec_walk_rx_ring(eTSEC *etsec, int ring_nbr)
>  
>                  /* TODO: Broadcast and Multicast */
>  
> -                if (bd.flags | BD_INTERRUPT) {
> +                if (bd.flags & BD_INTERRUPT) {
>                      /* Set RXFx */
[..etc..]

Hm.  Has this code _ever_ worked?? :(

Thanks, applied to -trivial.

/mjt

  reply	other threads:[~2014-03-14 17:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-14 16:51 [Qemu-trivial] [PATCH] FSL eTSEC: Fix typo in rx ring Fabien Chouteau
2014-03-14 16:51 ` [Qemu-devel] " Fabien Chouteau
2014-03-14 17:35 ` Michael Tokarev [this message]
2014-03-14 17:35   ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2014-03-17 17:08   ` Fabien Chouteau
2014-03-17 17:08     ` [Qemu-devel] " Fabien Chouteau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53233DCF.3010706@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=agraf@suse.de \
    --cc=chouteau@adacore.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.