From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Alexandre Belloni
<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Nicolas Ferre
<nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Jean-Christophe Plagniol-Villard
<plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH 01/15] ARM: at91: sam9g45: remove unused platform_data
Date: Sun, 16 Mar 2014 17:49:02 +0000 [thread overview]
Message-ID: <5325E40E.7050501@kernel.org> (raw)
In-Reply-To: <1394040940-18246-2-git-send-email-alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
On 05/03/14 17:35, Alexandre Belloni wrote:
> num_channels and registers are not used anymore since they are defined inside
> the at91_adc driver and assigned by matching the id_table.
>
> Also, remove the mach/at91_adc.h include that is not necessary anymore.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Acked-by: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> arch/arm/mach-at91/at91sam9g45_devices.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
> index 88554024eb2d..cd36009c3511 100644
> --- a/arch/arm/mach-at91/at91sam9g45_devices.c
> +++ b/arch/arm/mach-at91/at91sam9g45_devices.c
> @@ -25,7 +25,6 @@
> #include <linux/fb.h>
> #include <video/atmel_lcdc.h>
>
> -#include <mach/at91_adc.h>
> #include <mach/at91sam9g45.h>
> #include <mach/at91sam9g45_matrix.h>
> #include <mach/at91_matrix.h>
> @@ -1235,13 +1234,6 @@ static struct at91_adc_trigger at91_adc_triggers[] = {
> },
> };
>
> -static struct at91_adc_reg_desc at91_adc_register_g45 = {
> - .channel_base = AT91_ADC_CHR(0),
> - .drdy_mask = AT91_ADC_DRDY,
> - .status_register = AT91_ADC_SR,
> - .trigger_register = 0x08,
> -};
> -
> void __init at91_add_device_adc(struct at91_adc_data *data)
> {
> if (!data)
> @@ -1267,9 +1259,7 @@ void __init at91_add_device_adc(struct at91_adc_data *data)
> if (data->use_external_triggers)
> at91_set_A_periph(AT91_PIN_PD28, 0);
>
> - data->num_channels = 8;
> data->startup_time = 40;
> - data->registers = &at91_adc_register_g45;
> data->trigger_number = 4;
> data->trigger_list = at91_adc_triggers;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org,
linux-input@vger.kernel.org,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH 01/15] ARM: at91: sam9g45: remove unused platform_data
Date: Sun, 16 Mar 2014 17:49:02 +0000 [thread overview]
Message-ID: <5325E40E.7050501@kernel.org> (raw)
In-Reply-To: <1394040940-18246-2-git-send-email-alexandre.belloni@free-electrons.com>
On 05/03/14 17:35, Alexandre Belloni wrote:
> num_channels and registers are not used anymore since they are defined inside
> the at91_adc driver and assigned by matching the id_table.
>
> Also, remove the mach/at91_adc.h include that is not necessary anymore.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> arch/arm/mach-at91/at91sam9g45_devices.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
> index 88554024eb2d..cd36009c3511 100644
> --- a/arch/arm/mach-at91/at91sam9g45_devices.c
> +++ b/arch/arm/mach-at91/at91sam9g45_devices.c
> @@ -25,7 +25,6 @@
> #include <linux/fb.h>
> #include <video/atmel_lcdc.h>
>
> -#include <mach/at91_adc.h>
> #include <mach/at91sam9g45.h>
> #include <mach/at91sam9g45_matrix.h>
> #include <mach/at91_matrix.h>
> @@ -1235,13 +1234,6 @@ static struct at91_adc_trigger at91_adc_triggers[] = {
> },
> };
>
> -static struct at91_adc_reg_desc at91_adc_register_g45 = {
> - .channel_base = AT91_ADC_CHR(0),
> - .drdy_mask = AT91_ADC_DRDY,
> - .status_register = AT91_ADC_SR,
> - .trigger_register = 0x08,
> -};
> -
> void __init at91_add_device_adc(struct at91_adc_data *data)
> {
> if (!data)
> @@ -1267,9 +1259,7 @@ void __init at91_add_device_adc(struct at91_adc_data *data)
> if (data->use_external_triggers)
> at91_set_A_periph(AT91_PIN_PD28, 0);
>
> - data->num_channels = 8;
> data->startup_time = 40;
> - data->registers = &at91_adc_register_g45;
> data->trigger_number = 4;
> data->trigger_list = at91_adc_triggers;
>
>
WARNING: multiple messages have this Message-ID (diff)
From: jic23@kernel.org (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/15] ARM: at91: sam9g45: remove unused platform_data
Date: Sun, 16 Mar 2014 17:49:02 +0000 [thread overview]
Message-ID: <5325E40E.7050501@kernel.org> (raw)
In-Reply-To: <1394040940-18246-2-git-send-email-alexandre.belloni@free-electrons.com>
On 05/03/14 17:35, Alexandre Belloni wrote:
> num_channels and registers are not used anymore since they are defined inside
> the at91_adc driver and assigned by matching the id_table.
>
> Also, remove the mach/at91_adc.h include that is not necessary anymore.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> arch/arm/mach-at91/at91sam9g45_devices.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
> index 88554024eb2d..cd36009c3511 100644
> --- a/arch/arm/mach-at91/at91sam9g45_devices.c
> +++ b/arch/arm/mach-at91/at91sam9g45_devices.c
> @@ -25,7 +25,6 @@
> #include <linux/fb.h>
> #include <video/atmel_lcdc.h>
>
> -#include <mach/at91_adc.h>
> #include <mach/at91sam9g45.h>
> #include <mach/at91sam9g45_matrix.h>
> #include <mach/at91_matrix.h>
> @@ -1235,13 +1234,6 @@ static struct at91_adc_trigger at91_adc_triggers[] = {
> },
> };
>
> -static struct at91_adc_reg_desc at91_adc_register_g45 = {
> - .channel_base = AT91_ADC_CHR(0),
> - .drdy_mask = AT91_ADC_DRDY,
> - .status_register = AT91_ADC_SR,
> - .trigger_register = 0x08,
> -};
> -
> void __init at91_add_device_adc(struct at91_adc_data *data)
> {
> if (!data)
> @@ -1267,9 +1259,7 @@ void __init at91_add_device_adc(struct at91_adc_data *data)
> if (data->use_external_triggers)
> at91_set_A_periph(AT91_PIN_PD28, 0);
>
> - data->num_channels = 8;
> data->startup_time = 40;
> - data->registers = &at91_adc_register_g45;
> data->trigger_number = 4;
> data->trigger_list = at91_adc_triggers;
>
>
next prev parent reply other threads:[~2014-03-16 17:49 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 17:35 [PATCH 00/15] iio: adc: at91 cleanups and atmel_tsadcc removal Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 01/15] ARM: at91: sam9g45: remove unused platform_data Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
[not found] ` <1394040940-18246-2-git-send-email-alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-16 17:49 ` Jonathan Cameron [this message]
2014-03-16 17:49 ` Jonathan Cameron
2014-03-16 17:49 ` Jonathan Cameron
[not found] ` <1394040940-18246-1-git-send-email-alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-05 17:35 ` [PATCH 02/15] ARM: at91: sam9260: " Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
[not found] ` <1394040940-18246-3-git-send-email-alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-16 17:49 ` Jonathan Cameron
2014-03-16 17:49 ` Jonathan Cameron
2014-03-16 17:49 ` Jonathan Cameron
2014-03-05 17:35 ` [PATCH 13/15] ARM: at91: remove atmel_tsadcc from sama5_defconfig Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-16 18:30 ` [PATCH 00/15] iio: adc: at91 cleanups and atmel_tsadcc removal Jonathan Cameron
2014-03-16 18:30 ` Jonathan Cameron
2014-03-16 18:30 ` Jonathan Cameron
2014-03-16 19:29 ` Alexandre Belloni
2014-03-16 19:29 ` Alexandre Belloni
[not found] ` <5325EDAF.4060003-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-03-19 10:19 ` Nicolas Ferre
2014-03-19 10:19 ` Nicolas Ferre
2014-03-19 10:19 ` Nicolas Ferre
2014-03-22 12:31 ` Jonathan Cameron
2014-03-22 12:31 ` Jonathan Cameron
2014-03-24 9:00 ` Nicolas Ferre
2014-03-24 9:00 ` Nicolas Ferre
2014-03-24 9:00 ` Nicolas Ferre
2014-03-05 17:35 ` [PATCH 03/15] iio: adc: at91: cleanup platform_data Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-16 17:55 ` Jonathan Cameron
2014-03-16 17:55 ` Jonathan Cameron
2014-03-05 17:35 ` [PATCH 04/15] iio: adc: at91_adc: Add support for touchscreens without TSMR Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 18:27 ` Thomas Petazzoni
2014-03-05 18:27 ` Thomas Petazzoni
2014-03-05 18:50 ` Dmitry Torokhov
2014-03-05 18:50 ` Dmitry Torokhov
2014-03-16 18:16 ` Jonathan Cameron
2014-03-16 18:16 ` Jonathan Cameron
[not found] ` <5325EA96.9000907-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-03-16 19:16 ` Alexandre Belloni
2014-03-16 19:16 ` Alexandre Belloni
2014-03-16 19:16 ` Alexandre Belloni
[not found] ` <20140316191639.GJ3106-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2014-03-16 20:28 ` Jonathan Cameron
2014-03-16 20:28 ` Jonathan Cameron
2014-03-16 20:28 ` Jonathan Cameron
2014-03-05 17:35 ` [PATCH 05/15] ARM: at91: sam9m10g45ek: Add touchscreen support through at91_adc Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-16 18:18 ` Jonathan Cameron
2014-03-16 18:18 ` Jonathan Cameron
[not found] ` <5325EB01.5060700-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-03-16 20:00 ` Alexandre Belloni
2014-03-16 20:00 ` Alexandre Belloni
2014-03-16 20:00 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 06/15] iio: adc: at91: remove unused include from include/mach Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 07/15] iio: adc: at91: add sam9rl support Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 08/15] ARM: at91: sam9rl: add at91_adc to support adc and touchscreen Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 09/15] ARM: at91: sam9rlek add touchscreen support through at91_adc Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 10/15] ARM: at91: sam9g45: switch from atmel_tsadcc to at91_adc Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 11/15] ARM: at91: sam9rl: " Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 12/15] ARM: at91: remove atmel_tsadcc platform_data Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 17:35 ` [PATCH 14/15] Input: atmel_tsadcc: remove driver Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
2014-03-05 18:46 ` Dmitry Torokhov
2014-03-05 18:46 ` Dmitry Torokhov
2014-03-16 18:26 ` Jonathan Cameron
2014-03-16 18:26 ` Jonathan Cameron
[not found] ` <5325ECE3.5090800-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-03-16 19:26 ` Dmitry Torokhov
2014-03-16 19:26 ` Dmitry Torokhov
2014-03-16 19:26 ` Dmitry Torokhov
2014-03-05 17:35 ` [PATCH 15/15] ARM: at91/dt: at91-cosino_mega2560 remove useless tsadcc node Alexandre Belloni
2014-03-05 17:35 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5325E40E.7050501@kernel.org \
--to=jic23-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.