* [PATCH] drivers: rtc: rtc-s3c: remove NO_IRQ macro
@ 2014-03-05 11:12 Pankaj Dubey
2014-03-17 1:21 ` Pankaj Dubey
0 siblings, 1 reply; 2+ messages in thread
From: Pankaj Dubey @ 2014-03-05 11:12 UTC (permalink / raw)
To: linux-kernel, rtc-linux; +Cc: a.zummo, Pankaj Dubey
NO_IRQ may be defined as '(unsigned int) -1' in some architectures
(arm, sh ...), and either may not be defined in some architectures
(arm64) which can enable RTC_DRV_S3C.
Also since platform_get_irq returns err-code in case of any error,
we do not need to intialize s3c_rtc_alarmno and s3c_rtc_tickno.
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
---
drivers/rtc/rtc-s3c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 7afd373..cf2ebdd 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -48,8 +48,8 @@ struct s3c_rtc_drv_data {
static struct clk *rtc_clk;
static void __iomem *s3c_rtc_base;
-static int s3c_rtc_alarmno = NO_IRQ;
-static int s3c_rtc_tickno = NO_IRQ;
+static int s3c_rtc_alarmno;
+static int s3c_rtc_tickno;
static enum s3c_cpu_type s3c_rtc_cpu_type;
static DEFINE_SPINLOCK(s3c_rtc_pie_lock);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers: rtc: rtc-s3c: remove NO_IRQ macro
2014-03-05 11:12 [PATCH] drivers: rtc: rtc-s3c: remove NO_IRQ macro Pankaj Dubey
@ 2014-03-17 1:21 ` Pankaj Dubey
0 siblings, 0 replies; 2+ messages in thread
From: Pankaj Dubey @ 2014-03-17 1:21 UTC (permalink / raw)
To: Pankaj Dubey; +Cc: linux-kernel, rtc-linux, a.zummo
On 03/05/2014 08:12 PM, Pankaj Dubey wrote:
> NO_IRQ may be defined as '(unsigned int) -1' in some architectures
> (arm, sh ...), and either may not be defined in some architectures
> (arm64) which can enable RTC_DRV_S3C.
> Also since platform_get_irq returns err-code in case of any error,
> we do not need to intialize s3c_rtc_alarmno and s3c_rtc_tickno.
>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> drivers/rtc/rtc-s3c.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
> index 7afd373..cf2ebdd 100644
> --- a/drivers/rtc/rtc-s3c.c
> +++ b/drivers/rtc/rtc-s3c.c
> @@ -48,8 +48,8 @@ struct s3c_rtc_drv_data {
>
> static struct clk *rtc_clk;
> static void __iomem *s3c_rtc_base;
> -static int s3c_rtc_alarmno = NO_IRQ;
> -static int s3c_rtc_tickno = NO_IRQ;
> +static int s3c_rtc_alarmno;
> +static int s3c_rtc_tickno;
> static enum s3c_cpu_type s3c_rtc_cpu_type;
>
> static DEFINE_SPINLOCK(s3c_rtc_pie_lock);
Gentle Ping.
--
Best Regards,
Pankaj Dubey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-17 1:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 11:12 [PATCH] drivers: rtc: rtc-s3c: remove NO_IRQ macro Pankaj Dubey
2014-03-17 1:21 ` Pankaj Dubey
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.