All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tang Chen <tangchen@cn.fujitsu.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Gu Zheng <guz.fnst@cn.fujitsu.com>,
	viro@zeniv.linux.org.uk, jmoyer@redhat.com,
	kosaki.motohiro@gmail.com, kosaki.motohiro@jp.fujitsu.com,
	isimatu.yasuaki@jp.fujitsu.com, linux-fsdevel@vger.kernel.org,
	linux-aio@kvack.org, linux-kernel@vger.kernel.org,
	miaox@cn.fujitsu.com
Subject: Re: [RESEND v2 PATCH 1/2] aio, memory-hotplug: Fix confliction when migrating and accessing ring pages.
Date: Mon, 17 Mar 2014 14:50:34 +0800	[thread overview]
Message-ID: <53269B3A.4040900@cn.fujitsu.com> (raw)
In-Reply-To: <20140314151446.GE29206@kvack.org>

On 03/14/2014 11:14 PM, Benjamin LaHaise wrote:
......
>> What about the following patch? It adds additional reference to protect the page
>> avoid being freed when we reading it.
>> ps.It is applied on linux-next(3-13).
>
> I think that's even worse than the spinlock approach since we'll end up
> bouncing around the struct page's cacheline in addition to spinlock we're
> going to end up taking anyways.
>

Hi Benjamin,

I'm sorry, I don't quite understand the cacheline problem you mentioned 
above.
Would you please explain more ?

Thanks.

  parent reply	other threads:[~2014-03-17  6:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  8:15 [RESEND v2 PATCH 0/2] Bug fix in aio ring page migration Tang Chen
2014-03-10  8:15 ` Tang Chen
2014-03-10  8:15 ` [RESEND v2 PATCH 1/2] aio, memory-hotplug: Fix confliction when migrating and accessing ring pages Tang Chen
2014-03-10  8:15   ` Tang Chen
2014-03-11 18:46   ` Benjamin LaHaise
2014-03-11 18:46     ` Benjamin LaHaise
2014-03-12  5:25     ` Tang Chen
2014-03-12  5:25       ` Tang Chen
2014-03-12 22:17       ` Benjamin LaHaise
2014-03-12 22:17         ` Benjamin LaHaise
2014-03-14 10:25         ` Gu Zheng
2014-03-14 10:25           ` Gu Zheng
2014-03-14 15:14           ` Benjamin LaHaise
2014-03-14 15:14             ` Benjamin LaHaise
2014-03-16  2:06             ` Gu Zheng
2014-03-16  2:06               ` Gu Zheng
2014-03-17  6:50             ` Tang Chen [this message]
2014-03-10  8:15 ` [RESEND v2 PATCH 2/2] aio, mem-hotplug: Add memory barrier to aio ring page migration Tang Chen
2014-03-10  8:15   ` Tang Chen
2014-03-13  9:45 ` [RESEND v2 PATCH 0/2] Bug fix in " Gu Zheng
2014-03-13  9:45   ` Gu Zheng
2014-03-16 21:21   ` Ben Hutchings
2014-05-13 23:58   ` Greg Kroah-Hartman
2014-05-14  1:13     ` Gu Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53269B3A.4040900@cn.fujitsu.com \
    --to=tangchen@cn.fujitsu.com \
    --cc=bcrl@kvack.org \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=isimatu.yasuaki@jp.fujitsu.com \
    --cc=jmoyer@redhat.com \
    --cc=kosaki.motohiro@gmail.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-aio@kvack.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.