From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: "Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [PATCH] target-i386: Add missing 'static' and 'const' attributes
Date: Mon, 17 Mar 2014 10:56:11 +0100 [thread overview]
Message-ID: <5326C6BB.40105@redhat.com> (raw)
In-Reply-To: <1394978621-19738-1-git-send-email-sw@weilnetz.de>
Il 16/03/2014 15:03, Stefan Weil ha scritto:
> This fixes warnings from the static code analysis (smatch).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Why is array para_features in kvm.c terminated by a dummy entry?
> It is only used in a for loop with upper limit ARRAY_SIZE(para_features) - 1.
No particular reason.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
"Andreas Färber" <afaerber@suse.de>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH] target-i386: Add missing 'static' and 'const' attributes
Date: Mon, 17 Mar 2014 10:56:11 +0100 [thread overview]
Message-ID: <5326C6BB.40105@redhat.com> (raw)
In-Reply-To: <1394978621-19738-1-git-send-email-sw@weilnetz.de>
Il 16/03/2014 15:03, Stefan Weil ha scritto:
> This fixes warnings from the static code analysis (smatch).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Why is array para_features in kvm.c terminated by a dummy entry?
> It is only used in a for loop with upper limit ARRAY_SIZE(para_features) - 1.
No particular reason.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>, qemu-trivial@nongnu.org
Cc: "Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH] target-i386: Add missing 'static' and 'const' attributes
Date: Mon, 17 Mar 2014 10:56:11 +0100 [thread overview]
Message-ID: <5326C6BB.40105@redhat.com> (raw)
In-Reply-To: <1394978621-19738-1-git-send-email-sw@weilnetz.de>
Il 16/03/2014 15:03, Stefan Weil ha scritto:
> This fixes warnings from the static code analysis (smatch).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Why is array para_features in kvm.c terminated by a dummy entry?
> It is only used in a for loop with upper limit ARRAY_SIZE(para_features) - 1.
No particular reason.
Paolo
next prev parent reply other threads:[~2014-03-17 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-16 14:03 [Qemu-trivial] [PATCH] target-i386: Add missing 'static' and 'const' attributes Stefan Weil
2014-03-16 14:03 ` [Qemu-devel] " Stefan Weil
2014-03-16 14:03 ` Stefan Weil
2014-03-17 9:56 ` Paolo Bonzini [this message]
2014-03-17 9:56 ` [Qemu-devel] " Paolo Bonzini
2014-03-17 9:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5326C6BB.40105@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.