Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

[Boris BREZILLON <b.brezillon.dev@gmail.com>]

Hello Mark,

Le 17/03/2014 12:55, Mark Brown a écrit :
> On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote:
>
>>     - compatible: "atmel,asoc-wm8904"
>>     - atmel,model: The user-visible name of this sound complex.
>> +  - clocks: A list of clocks needed by the wm8904 chip.
>> +  - clock-output-names: Driver related clock names. Shall contain "pck0".
> If this is a clock for the CODEC it should be documented as part of the
> binding for the CODEC and connected to the CODEC in the device tree
> rather than being part of a machine driver binding.

Tell me if I'm mistaken, but doing this would implies a lot of changes.
The current wm8904 driver does not handle clk retrieval and configuration,
and I'm afraid that introducing these concepts would break other drivers 
(those
connecting to a wm8904 codec).

Do you see a simple alternative to this approach (or is there something 
I misunderstood
in your suggestion) ?

How about adding CCF support as proposed in this series and think about 
a cleaner
solution for a future release ?

Best Regards,

Boris